Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0036475
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] Y. DBSourceManagertrivialhave not tried2017-07-12 12:242017-07-14 11:41
ReporteralostaleView Statuspublic 
Assigned Toalostale 
PrioritynormalResolutionfixedFixed in Version3.0PR17Q4
StatusclosedFix in branchFixed in SCM revisione109968e82aa
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toinigosanchez
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0036475: update.database logs irrelevant information

Descriptionupdate database task logs "Executing database update process without checking changes in local files". This refers to an old feature not currently in use that allowed not to execute anything in case xml database files where not modified since last update.

In addition this log is not using standard logging but direct console output.

Together with it, there are two more lines that are directly written in console output:

     [java] Checking if database structure was modified locally.
     [java] Checking if data has changed in the application dictionary.
Steps To ReproduceExecute ant update.database and check logs:

     ...
     [java] Executing database update process without checking changes in local files.
     ...
     [java] Checking if database structure was modified locally.
     [java] Checking if data has changed in the application dictionary.
     [java] 18979 INFO - Executing default prescript
     ...
Proposed SolutionRemove 1st case as it does not provide any relevant information
Use standard logger for the other 2 lines
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks design defect 0036162 acknowledgedTriage Platform Base clean up openbravo.log 

-  Notes
(0098047)
hgbot (developer)
2017-07-12 12:29

 Repository: erp/devel/dbsm-main
Changeset: 373ec81adebe90434c4fa24b249a197dc1a85bce
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Jul 12 12:26:51 2017 +0200
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/373ec81adebe90434c4fa24b249a197dc1a85bce [^]

fixed 36475: update.database logs irrelevant information

  Removed irrelevant information + use standard logger in other cases

---
M src/org/openbravo/ddlutils/task/AlterDatabaseDataAll.java
M src/org/openbravo/ddlutils/util/DBSMOBUtil.java
---
(0098049)
hgbot (developer)
2017-07-12 12:29

 Repository: erp/devel/pi
Changeset: e109968e82aa10126efa6bf53b1a401f5d72d159
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Jul 12 12:28:55 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/e109968e82aa10126efa6bf53b1a401f5d72d159 [^]

fixed 36473, fixed 36475

  new jar including patches for both issues

---
M src-db/database/lib/dbsourcemanager.jar
---
(0098080)
inigosanchez (developer)
2017-07-14 11:41

 Tested and reviewed > Irrelevant logs have been removed.

- Issue History
Date Modified Username Field Change
2017-07-12 12:24 alostale New Issue
2017-07-12 12:24 alostale Assigned To => alostale
2017-07-12 12:24 alostale Modules => Core
2017-07-12 12:24 alostale Triggers an Emergency Pack => No
2017-07-12 12:25 alostale Review Assigned To => caristu
2017-07-12 12:25 alostale Relationship added blocks 0036162
2017-07-12 12:29 hgbot Checkin
2017-07-12 12:29 hgbot Note Added: 0098047
2017-07-12 12:29 hgbot Status new => resolved
2017-07-12 12:29 hgbot Resolution open => fixed
2017-07-12 12:29 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/dbsm-main/rev/373ec81adebe90434c4fa24b249a197dc1a85bce [^]
2017-07-12 12:29 hgbot Checkin
2017-07-12 12:29 hgbot Note Added: 0098049
2017-07-12 12:29 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/dbsm-main/rev/373ec81adebe90434c4fa24b249a197dc1a85bce [^] => http://code.openbravo.com/erp/devel/pi/rev/e109968e82aa10126efa6bf53b1a401f5d72d159 [^]
2017-07-12 12:30 alostale Review Assigned To caristu => inigosanchez
2017-07-14 11:41 inigosanchez Note Added: 0098080
2017-07-14 11:41 inigosanchez Status resolved => closed
2017-07-14 11:41 inigosanchez Fixed in Version => 3.0PR17Q4

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker