Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0036357 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] StoreServer | major | have not tried | 2017-06-27 11:04 | 2017-06-29 12:23 | |||
| Reporter | AugustoMauch | View Status | public | |||||
| Assigned To | mtaal | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | RR17Q3 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 158855ed844f | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | AugustoMauch | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0036357: If the OBSTSYN_SERVER_MODULE is empty in the store server, force its population | |||||||
| Description | When a store server is going to compare its module versions to those of the central server, it looks for the central server versions in the OBSTSYN_SERVER_MODULE table. If the table is empty, then it assumes the module versions are different, and the store server is put offline. It is very easy to reproduce this, just by updating to this changeset [1]. I think it is better to proactively request the missing info to the central server instead of forcing to re-export the store server data. [1] https://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/b119473822cb [^] | |||||||
| Steps To Reproduce | In any multiserver environment - Update the [1] module to this changeset [2] in both central and store servers. - When they start, the store server will go offline because its OBSTSYN_SERVER_MODULE will not contain the records related with the central server. This already happened in CI: [3], look for "Transition to online failed because of handlers: Incompatible versions with Central Server" [1] https://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization [^] [2] https://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/b119473822cb [^] [3] http://ci.openbravo.com/view/storeserver/job/ret-ms-store2-pgsql/492/console [^] | |||||||
| Proposed Solution | When Tomcat is started in the store server, check if the OBSTSYN_SERVER_MODULE table contains rows for the Central Server. If not, retrieve them either by: - Updating them in the central server so that they are refreshed in all store server or - Send that info in the request response, so that only the store server that did not have this data will receive it | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0097716) hgbot (developer) 2017-06-27 18:50 |
Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization Changeset: 158855ed844fe259e8f4d562eeb8f90cee12e97e Author: Martin Taal <martin.taal <at> openbravo.com> Date: Tue Jun 27 18:49:57 2017 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/158855ed844fe259e8f4d562eeb8f90cee12e97e [^] Fixes issue 36357: If the OBSTSYN_SERVER_MODULE is empty in the store server, force its population Do not let missing central server modules mean diff-version and offline, be less strong --- M src/org/openbravo/retail/storeserver/synchronization/StoreServerVersionHandler.java --- |
|
(0097717) mtaal (manager) 2017-06-27 18:51 |
After further exchange of thoughts the conclusion has been that for now we only make the current test less strict. Normally the server modules are replicated and there is an easy way of re-replicating them. |
|
(0097759) AugustoMauch (manager) 2017-06-29 12:23 |
Code reviewed and verified |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2017-06-27 11:04 | AugustoMauch | New Issue | |
| 2017-06-27 11:04 | AugustoMauch | Assigned To | => mtaal |
| 2017-06-27 11:04 | AugustoMauch | Triggers an Emergency Pack | => No |
| 2017-06-27 11:04 | AugustoMauch | Relationship added | related to 0035819 |
| 2017-06-27 11:05 | AugustoMauch | Steps to Reproduce Updated | View Revisions |
| 2017-06-27 18:50 | hgbot | Checkin | |
| 2017-06-27 18:50 | hgbot | Note Added: 0097716 | |
| 2017-06-27 18:50 | hgbot | Status | new => resolved |
| 2017-06-27 18:50 | hgbot | Resolution | open => fixed |
| 2017-06-27 18:50 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/158855ed844fe259e8f4d562eeb8f90cee12e97e [^] |
| 2017-06-27 18:50 | mtaal | Review Assigned To | => AugustoMauch |
| 2017-06-27 18:51 | mtaal | Note Added: 0097717 | |
| 2017-06-29 12:23 | AugustoMauch | Note Added: 0097759 | |
| 2017-06-29 12:23 | AugustoMauch | Status | resolved => closed |
| 2017-06-29 12:23 | AugustoMauch | Fixed in Version | => RR17Q3 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |