Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0036175
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2017-06-05 11:302017-12-13 11:33
ReporteregoitzView Statuspublic 
Assigned Toebecerra 
PrioritynormalResolutionfixedFixed in VersionRR17Q4
StatusclosedFix in branchFixed in SCM revision31e4ae9b1728
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0036175: Perforamnce problems loading the master data for discounts.

DescriptionOn environment with a lot of product characteristics, the load of the
DiscountFiltercharactaritic model takes long.
Steps To Reproduce-Login on webpos on an environment with a big amount of characteristics
*The query of the DiscountFiltercharactaritic model takes long.
Proposed SolutionON modules/org.openbravo.retail.posterminal/src/org/openbravo/retail/posterminal/master/DiscountFilterCharacteristic.java
replace
hql += " left join c.characteristic.productCharacteristicValueList cvl ";
with
hql += " left join c.characteristic.characteristicValueList cvl ";

and
hql += " and m_isparent_ch_value(cvl.characteristicValue.id, c.chValue.id, c.characteristic.id) != -1 ";
with
 hql += " and m_isparent_ch_value(cvl.id, c.chValue.id, c.characteristic.id) != -1 ";


Also edit the file
modules/org.openbravo.retail.posterminal/src/org/openbravo/retail/posterminal/master/DiscountFilterCharacteristicProperties.java
by replacing
add(new HQLProperty("distinct(coalesce(c.id,cvl.characteristicValue.id))", "id"));
with
add(new HQLProperty("distinct(coalesce(c.id,cvl.id))", "id"));

and
add(new HQLProperty("cvl.characteristicValue.id", "chValue"));
with
add(new HQLProperty("cvl.id", "chValue"));
TagsPerformance
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 0036426RR17Q3 closedebecerra Perforamnce problems loading the master data for discounts. 
depends on backport 0036427RR17Q2.2 closedebecerra Perforamnce problems loading the master data for discounts. 
depends on backport 0036428RR17Q1.3 closedebecerra Perforamnce problems loading the master data for discounts. 
related to defect 0050860 closedranjith_qualiantech_com Query for retrieving the Discount Filter Characteristics take too long 

-  Notes
(0097836)
hgbot (developer)
2017-07-04 13:14

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 31e4ae9b1728a4afcccb7c391392124513dcdb2f
Author: Eduardo Becerra <ebec70 <at> yahoo.com>
Date: Thu Jun 29 12:32:14 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/31e4ae9b1728a4afcccb7c391392124513dcdb2f [^]

Fixed issue 36175: Optimize loading the master data for discounts

---
M src/org/openbravo/retail/posterminal/master/DiscountFilterCharacteristic.java
M src/org/openbravo/retail/posterminal/master/DiscountFilterCharacteristicProperties.java
---

- Issue History
Date Modified Username Field Change
2017-06-05 11:30 egoitz New Issue
2017-06-05 11:30 egoitz Assigned To => Retail
2017-06-05 11:30 egoitz Resolution time => 1497909600
2017-06-05 11:30 egoitz Triggers an Emergency Pack => No
2017-06-26 08:40 marvintm Resolution time 1497909600 => 1499637600
2017-06-29 10:32 marvintm Proposed Solution updated
2017-07-04 13:14 hgbot Checkin
2017-07-04 13:14 hgbot Note Added: 0097836
2017-07-04 13:14 hgbot Status new => resolved
2017-07-04 13:14 hgbot Resolution open => fixed
2017-07-04 13:14 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/31e4ae9b1728a4afcccb7c391392124513dcdb2f [^]
2017-07-06 08:46 marvintm Assigned To Retail => ebecerra
2017-07-06 08:46 marvintm Status resolved => new
2017-07-06 08:46 marvintm Resolution fixed => open
2017-07-06 08:47 marvintm Status new => scheduled
2017-07-06 08:47 marvintm Status scheduled => resolved
2017-07-06 08:47 marvintm Fixed in Version => RR17Q4
2017-07-06 08:47 marvintm Resolution open => fixed
2017-07-07 09:16 marvintm Review Assigned To => marvintm
2017-07-07 09:16 marvintm Status resolved => closed
2017-12-13 11:33 malsasua Tag Attached: Performance
2022-11-11 13:08 ngarcia Relationship added related to 0050860

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker