Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0036163
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2017-06-01 13:252017-06-08 17:12
ReporteralostaleView Statuspublic 
Assigned Toalostale 
PrioritynormalResolutionfixedFixed in Version3.0PR17Q3
StatusclosedFix in branchFixed in SCM revision2750ad10ee7d
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tocaristu
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0036163: val rule referring non-existent col fails if there's a property field with same name

DescriptionHaving a validation rule in which expression participates a column (ie. @Fin_Financial_Account_ID@) which does not exist in its tab's fields columns, but there is in that tab a property field with the same name, makes FIC requests to incorrectly throw errors about cycles.

This can be reproduced in "Add Multiple Payment P&E" window which is based on FIN_Payement table. Currency column has a validation rule that depends on Fin_Financial_Account_ID, there is no field in this tab for that column, but there is a property field that has the same name.
Steps To Reproduce1. As System Admin
1.1. In Windows Tab and Fields select "Add Multiple Payments P&E" window
1.2. Select Business Partner (or any other) field and unset Read Only flag (this is done just to force FIC request on record selection, there's a validation rule that causes error to be logged for this window)
2. As Openbravo Admin
2.1. Open Financial Account window, select a record and click on "Add Multiple Payments" button
2.2. In P&E grid select any record
   -> Check in logs it complains about cycles in C_Currency val rule
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0036161 closedalostale useless log having an incorrect definition for validation rule 
related to defect 00284383.0PR15Q2 closedalostale Property fields cannot be included in validations 
related to design defect 0036164 acknowledgedTriage Platform Base non-existing columns can be included within validation rules 

-  Notes
(0097081)
hgbot (developer)
2017-06-01 16:49

 Repository: erp/devel/pi
Changeset: 2750ad10ee7d98245393053656fb86902faddd17
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Jun 01 14:24:49 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/2750ad10ee7d98245393053656fb86902faddd17 [^]

fixed bug 36163: val rule for non-existent col fails if prop fld has same name

  Having a validation rule referring to a non-existent column in tab fields, and
  having in the same tab a property field with the same name failed.

  This was caused because in the map of available columns used to parse validation
  rule, the column name was directly used withouth distinguishing property fields,
  so the validation rule was parsed assuming there was a column with the same name.

  Now this list differentiates property fields, so in this case that reference will
  just be skipped as non-existing (see also 0036164)

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/FormInitializationComponent.java
---
(0097111)
caristu (developer)
2017-06-02 18:06

 Code reviewed + tested OK.
(0097231)
hudsonbot (developer)
2017-06-08 17:12

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/fda0f16ab470 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2017-06-01 13:25 alostale New Issue
2017-06-01 13:25 alostale Assigned To => alostale
2017-06-01 13:25 alostale Modules => Core
2017-06-01 13:25 alostale Triggers an Emergency Pack => No
2017-06-01 13:26 alostale Relationship added related to 0036161
2017-06-01 13:29 alostale Relationship added related to 0028438
2017-06-01 13:33 alostale Relationship added related to 0036164
2017-06-01 16:39 eduardo_Argal Issue Monitored: eduardo_Argal
2017-06-01 16:49 hgbot Checkin
2017-06-01 16:49 hgbot Note Added: 0097081
2017-06-01 16:49 hgbot Status new => resolved
2017-06-01 16:49 hgbot Resolution open => fixed
2017-06-01 16:49 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/2750ad10ee7d98245393053656fb86902faddd17 [^]
2017-06-01 17:17 alostale Review Assigned To => caristu
2017-06-02 18:06 caristu Note Added: 0097111
2017-06-02 18:06 caristu Status resolved => closed
2017-06-02 18:06 caristu Fixed in Version => 3.0PR17Q3
2017-06-08 17:12 hudsonbot Checkin
2017-06-08 17:12 hudsonbot Note Added: 0097231

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker