0036150: OBUIAPP_ActionNotAllowed when trying to do a cash up from a master terminal without access to POS Terminal window

# HG changeset patch
# User Ranjith S R <ranjith@qualiantech.com>
# Date 1510575681 -19800
#      Mon Nov 13 17:51:21 2017 +0530
# Node ID 2abc6369b4c2d431c2c46b4251f73e489beb85b2
# Parent  c8f6c4c581b03e60fbfe1b56ac288abccb866b2b
Fixed issue 36150 : [3.0RR16Q4.1] Added AdminMode to Master Slave Cashup to avoid Entity Access error

diff -r c8f6c4c581b0 -r 2abc6369b4c2 src/org/openbravo/retail/posterminal/ProcessCashCloseMaster.java
--- a/src/org/openbravo/retail/posterminal/ProcessCashCloseMaster.java	Thu Jan 19 10:04:31 2017 +0000
+++ b/src/org/openbravo/retail/posterminal/ProcessCashCloseMaster.java	Mon Nov 13 17:51:21 2017 +0530
@@ -19,6 +19,7 @@
 import org.hibernate.Query;
 import org.hibernate.Session;
 import org.hibernate.criterion.Restrictions;
+import org.openbravo.dal.core.OBContext;
 import org.openbravo.dal.service.OBCriteria;
 import org.openbravo.dal.service.OBDal;
 import org.openbravo.model.financialmgmt.payment.FIN_FinaccTransaction;
@@ -27,55 +28,60 @@
 
   @Override
   public JSONObject exec(JSONObject jsonsent) throws JSONException, ServletException {
-    JSONObject result = new JSONObject();
-    String masterterminal = jsonsent.getString("masterterminal");
-    String cashUpId = jsonsent.getString("cashUpId");
-    OBCriteria<OBPOSApplications> obCriteria = OBDal.getInstance().createCriteria(
-        OBPOSApplications.class);
-    obCriteria.add(Restrictions.eq(OBPOSApplications.PROPERTY_MASTERTERMINAL + ".id",
-        masterterminal));
-    obCriteria.addOrderBy(OBPOSApplications.PROPERTY_SEARCHKEY, true);
-    List<OBPOSApplications> applications = obCriteria.list();
-    JSONArray terminals = new JSONArray();
-    boolean finishAll = true;
-    for (OBPOSApplications application : applications) {
-      JSONObject terminal = new JSONObject();
-      terminal.put("id", application.getId());
-      terminal.put("searchKey", application.getSearchKey());
-      terminal.put("name", application.getName());
-      OBPOSAppCashup terminalCashUp = getTerminalCashUp(application.getId(), cashUpId);
-      boolean finish = terminalCashUp != null && terminalCashUp.isProcessed()
-          && terminalCashUp.isProcessedbo();
-      terminal.put("finish", finish);
-      int noOfTransactions = (terminalCashUp != null ? getnoOfTransactions(terminalCashUp.getId())
-          : 0);
-      terminal.put("noOfTransactions", noOfTransactions);
-      terminal.put("cashUpId", terminalCashUp != null ? terminalCashUp.getId() : null);
-      if (!finish && noOfTransactions > 0) {
-        finishAll = false;
+    OBContext.setAdminMode(true);
+    try {
+      JSONObject result = new JSONObject();
+      String masterterminal = jsonsent.getString("masterterminal");
+      String cashUpId = jsonsent.getString("cashUpId");
+      OBCriteria<OBPOSApplications> obCriteria = OBDal.getInstance().createCriteria(
+          OBPOSApplications.class);
+      obCriteria.add(Restrictions.eq(OBPOSApplications.PROPERTY_MASTERTERMINAL + ".id",
+          masterterminal));
+      obCriteria.addOrderBy(OBPOSApplications.PROPERTY_SEARCHKEY, true);
+      List<OBPOSApplications> applications = obCriteria.list();
+      JSONArray terminals = new JSONArray();
+      boolean finishAll = true;
+      for (OBPOSApplications application : applications) {
+        JSONObject terminal = new JSONObject();
+        terminal.put("id", application.getId());
+        terminal.put("searchKey", application.getSearchKey());
+        terminal.put("name", application.getName());
+        OBPOSAppCashup terminalCashUp = getTerminalCashUp(application.getId(), cashUpId);
+        boolean finish = terminalCashUp != null && terminalCashUp.isProcessed()
+            && terminalCashUp.isProcessedbo();
+        terminal.put("finish", finish);
+        int noOfTransactions = (terminalCashUp != null ? getnoOfTransactions(terminalCashUp.getId())
+            : 0);
+        terminal.put("noOfTransactions", noOfTransactions);
+        terminal.put("cashUpId", terminalCashUp != null ? terminalCashUp.getId() : null);
+        if (!finish && noOfTransactions > 0) {
+          finishAll = false;
+        }
+        terminals.put(terminal);
       }
-      terminals.put(terminal);
-    }
-    JSONObject data = new JSONObject();
-    data.put("terminals", terminals);
-    data.put("finishAll", finishAll);
-    if (finishAll) {
-      JSONArray payments = new JSONArray();
-      data.put("payments", payments);
-      List<String> cashUpIds = new ArrayList<String>();
-      for (int i = 0; i < terminals.length(); i++) {
-        JSONObject terminal = terminals.getJSONObject(i);
-        if (terminal.getBoolean("finish")) {
-          cashUpIds.add(terminal.getString("cashUpId"));
+      JSONObject data = new JSONObject();
+      data.put("terminals", terminals);
+      data.put("finishAll", finishAll);
+      if (finishAll) {
+        JSONArray payments = new JSONArray();
+        data.put("payments", payments);
+        List<String> cashUpIds = new ArrayList<String>();
+        for (int i = 0; i < terminals.length(); i++) {
+          JSONObject terminal = terminals.getJSONObject(i);
+          if (terminal.getBoolean("finish")) {
+            cashUpIds.add(terminal.getString("cashUpId"));
+          }
+        }
+        if (cashUpIds.size() > 0) {
+          addPaymentmethodCashup(payments, cashUpIds);
         }
       }
-      if (cashUpIds.size() > 0) {
-        addPaymentmethodCashup(payments, cashUpIds);
-      }
+      result.put("data", data);
+      result.put("status", 0);
+      return result;
+    } finally {
+      OBContext.restorePreviousMode();
     }
-    result.put("data", data);
-    result.put("status", 0);
-    return result;
   }
 
   /**
diff -r c8f6c4c581b0 -r 2abc6369b4c2 src/org/openbravo/retail/posterminal/ProcessCashCloseSlave.java
--- a/src/org/openbravo/retail/posterminal/ProcessCashCloseSlave.java	Thu Jan 19 10:04:31 2017 +0000
+++ b/src/org/openbravo/retail/posterminal/ProcessCashCloseSlave.java	Mon Nov 13 17:51:21 2017 +0530
@@ -12,21 +12,27 @@
 
 import org.codehaus.jettison.json.JSONException;
 import org.codehaus.jettison.json.JSONObject;
+import org.openbravo.dal.core.OBContext;
 import org.openbravo.dal.service.OBDal;
 
 public class ProcessCashCloseSlave extends JSONProcessSimple {
 
   @Override
   public JSONObject exec(JSONObject jsonsent) throws JSONException, ServletException {
-    OBPOSAppCashup appCashup = OBDal.getInstance().get(OBPOSAppCashup.class,
-        jsonsent.getString("cashUpId"));
-    JSONObject result = new JSONObject();
-    JSONObject data = new JSONObject();
-    boolean hasMaster = appCashup != null && appCashup.getObposParentCashup() != null;
-    data.put("hasMaster", hasMaster);
-    result.put("data", data);
-    result.put("status", 0);
-    return result;
+    OBContext.setAdminMode(true);
+    try {
+      OBPOSAppCashup appCashup = OBDal.getInstance().get(OBPOSAppCashup.class,
+          jsonsent.getString("cashUpId"));
+      JSONObject result = new JSONObject();
+      JSONObject data = new JSONObject();
+      boolean hasMaster = appCashup != null && appCashup.getObposParentCashup() != null;
+      data.put("hasMaster", hasMaster);
+      result.put("data", data);
+      result.put("status", 0);
+      return result;
+    } finally {
+      OBContext.restorePreviousMode();
+    }
   }
 
 }