Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||||||
| ID | ||||||||||||
| 0036122 | ||||||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||||||
| design defect | [Retail Modules] Web POS | major | always | 2017-05-29 11:15 | 2017-06-20 09:48 | |||||||
| Reporter | jonibc | View Status | public | |||||||||
| Assigned To | jorge-garcia | |||||||||||
| Priority | high | Resolution | open | Fixed in Version | ||||||||
| Status | scheduled | Fix in branch | Fixed in SCM revision | c92cd921eee5 | ||||||||
| Projection | none | ETA | none | Target Version | ||||||||
| OS | Any | Database | Any | Java version | ||||||||
| OS Version | Database version | Ant version | ||||||||||
| Product Version | SCM revision | |||||||||||
| Review Assigned To | ||||||||||||
| Regression level | ||||||||||||
| Regression date | ||||||||||||
| Regression introduced in release | ||||||||||||
| Regression introduced by commit | ||||||||||||
| Triggers an Emergency Pack | No | |||||||||||
| Summary | 0036122: [SERQA 2908]If a partial payment is added, buttons and external input are not blocked. | |||||||||||
| Description | If a partial payment is added, buttons (UI) and external input are not blocked. This has special relevance in BUT implementation, since reservations for product are created in the moment that the first payment is done. The second payment added for an order can not execute the hook until the reservation has been created. It is necessary to take into account that also it is possible to add payments using external input. | |||||||||||
| Steps To Reproduce | Login to WebPOS: - Open chrome developer tools, put a breakpoint in prePayment hook. (Also it is possible to implement the hook and add a sleep instruction) - Add a product to the receipt. - Click on total amount. - Select cash payment method. Click several times in 10€ button. Check that the hook is raised several times and UI is not blocked. | |||||||||||
| Proposed Solution | Block UI and external input while adding payments until each payment has been processed. | |||||||||||
| Tags | No tags attached. | |||||||||||
| Attached Files | ||||||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0097426) hgbot (developer) 2017-06-16 08:46 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: c92cd921eee5f24927fa74857dc217f2d9cb2edc Author: Jorge Garcia <jorge.garcia <at> openbravo.com> Date: Thu Jun 15 16:50:40 2017 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c92cd921eee5f24927fa74857dc217f2d9cb2edc [^] Fixed issue 36122: [SERQA 2908]If a partial payment is added, buttons and external input are not blocked. The solution is to show the loading screen when the hook is going to be executed and hide the screen in the last part of the hook execution. --- M web/org.openbravo.retail.posterminal/js/model/order.js --- |
|
(0097486) jorge-garcia (reporter) 2017-06-19 17:09 |
If a popup is registered inside of preAddPayment hook, the webpos gets stuck in showLoading window. |
|
(0097502) marvintm (manager) 2017-06-20 09:46 |
After analyzing the problem further, we have found that currently there is no reliable way to enforce this which at the same time doesn't impact already existing payment gateway implementations which don't necessarily call the callbackExecutor in every flow. Therefore, as of now we consider it a design defect. In short we will discuss with all parties to reach a common solution which doesn't negatively impact existing payment providers. |
|
(0097503) hgbot (developer) 2017-06-20 09:48 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 6f4ce0bdcd19309a7ce62b71593625bdcd105b68 Author: Jorge Garcia <jorge.garcia <at> openbravo.com> Date: Tue Jun 20 09:48:11 2017 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6f4ce0bdcd19309a7ce62b71593625bdcd105b68 [^] Related to issue 36122: [SERQA 2908]If a partial payment is added, buttons and external input are not blocked. Backed out changeset c92cd921eee5. --- M web/org.openbravo.retail.posterminal/js/model/order.js --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2017-05-29 11:15 | jonibc | New Issue | |
| 2017-05-29 11:15 | jonibc | Assigned To | => Retail |
| 2017-05-29 11:15 | jonibc | Resolution time | => 1497218400 |
| 2017-05-29 11:15 | jonibc | Triggers an Emergency Pack | => No |
| 2017-06-15 12:34 | jorge-garcia | Assigned To | Retail => jorge-garcia |
| 2017-06-15 12:34 | jorge-garcia | Status | new => acknowledged |
| 2017-06-15 16:48 | jorge-garcia | Status | acknowledged => scheduled |
| 2017-06-16 08:46 | hgbot | Checkin | |
| 2017-06-16 08:46 | hgbot | Note Added: 0097426 | |
| 2017-06-16 08:46 | hgbot | Status | scheduled => resolved |
| 2017-06-16 08:46 | hgbot | Resolution | open => fixed |
| 2017-06-16 08:46 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c92cd921eee5f24927fa74857dc217f2d9cb2edc [^] |
| 2017-06-19 17:09 | jorge-garcia | Note Added: 0097486 | |
| 2017-06-19 17:09 | jorge-garcia | Status | resolved => new |
| 2017-06-19 17:09 | jorge-garcia | Resolution | fixed => open |
| 2017-06-19 17:13 | jorge-garcia | Status | new => scheduled |
| 2017-06-19 17:40 | Sandrahuguet | Relationship added | blocks 0036010 |
| 2017-06-20 09:44 | marvintm | Resolution time | 1497218400 => |
| 2017-06-20 09:44 | marvintm | Type | defect => design defect |
| 2017-06-20 09:46 | marvintm | Note Added: 0097502 | |
| 2017-06-20 09:48 | hgbot | Checkin | |
| 2017-06-20 09:48 | hgbot | Note Added: 0097503 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |