Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0036114
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2017-05-26 09:502017-06-12 09:22
ReporterAsantos9View Statuspublic 
Assigned Torqueralta 
PriorityhighResolutionfixedFixed in VersionRR17Q3
StatusclosedFix in branchFixed in SCM revision98e87f3b39b6
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0036114: Save customer in Web POS is only allowed for the business partners selected on the tickets

DescriptionIn order to modify a customer different from the one selected on the ticket, it is not possible to use saveCustomer method. In this point it is not the event necessary to save the customer.
Steps To Reproduce- Add a breakpoint in the client side in the following code:

    this.customer.on('customerSaved', function () {
      OB.DATA.executeCustomerSave(this.customer); <- here
    }, this);

- Open the customer selector, and then in the context menu select "Edit"
- Change the name of the customer, and click on Save. Notice that the flow stops in the breakpoint. This is correct, as the executeCustomerSave call will ensure that the customer is correctly saved.

However, this trigger doesn't happen if you get a customer in code, and try to execute saveCustomer to it:

OB.Dal.find(OB.Model.BusinessPartner, {
    id: 'D5BF95FA079B4248B2CA2E2DA477D1B8'
}, function(bps) {
    console.log(bps.at(0));
    bps.at(0).saveCustomer(function() {
        console.log('fin')
    })
})

Proposed SolutionWe need to think on the best solution for this, but maybe one possibility is to modify the saveCustomer function so that it calls OB.DATA.executeCustomerSave(this.customer) directly instead of delegating on the trigger for that.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0097197)
hgbot (developer)
2017-06-07 22:26

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 98e87f3b39b60df54dc7c55e01096439f926c925
Author: Rafael Queralta Pozo <rqueralta <at> nauta.cu>
Date: Thu Jun 01 09:23:15 2017 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/98e87f3b39b60df54dc7c55e01096439f926c925 [^]

Fixed issue 36114: Save customer in Web POS is only allowed for the business
partners selected on the tickets

---
M web/org.openbravo.retail.posterminal/js/model/businesspartner.js
---

- Issue History
Date Modified Username Field Change
2017-05-26 09:50 Asantos9 New Issue
2017-05-26 09:50 Asantos9 Assigned To => Retail
2017-05-26 09:50 Asantos9 OBNetwork customer => Yes
2017-05-26 09:50 Asantos9 Resolution time => 1496959200
2017-05-26 09:50 Asantos9 Triggers an Emergency Pack => No
2017-05-29 15:51 rqueralta Assigned To Retail => rqueralta
2017-05-29 15:51 rqueralta Status new => scheduled
2017-05-30 09:08 marvintm Steps to Reproduce Updated View Revisions
2017-05-30 09:08 marvintm Proposed Solution updated
2017-06-07 22:26 hgbot Checkin
2017-06-07 22:26 hgbot Note Added: 0097197
2017-06-07 22:26 hgbot Status scheduled => resolved
2017-06-07 22:26 hgbot Resolution open => fixed
2017-06-07 22:26 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/98e87f3b39b60df54dc7c55e01096439f926c925 [^]
2017-06-12 09:22 marvintm Review Assigned To => marvintm
2017-06-12 09:22 marvintm Status resolved => closed
2017-06-12 09:22 marvintm Fixed in Version => RR17Q3

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker