Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0036036
TypeCategorySeverityReproducibilityDate SubmittedLast Update
design defect[Retail Modules] StoreServerminorhave not tried2017-05-18 11:022017-06-23 11:14
ReportermtaalView Statuspublic 
Assigned Tomtaal 
PrioritynormalResolutionfixedFixed in VersionRR17Q3
StatusclosedFix in branchFixed in SCM revision08cd4d0acc2d
ProjectionnoneETAnoneTarget VersionRR17Q3
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned ToAugustoMauch
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0036036: When BP is created in the store then the store-Business-Partner relation is not created in central when Store goes to online

DescriptionWhen a store is offline a BP can be created in the store or can be used in an order. In both cases the BP-store relation has to be updated/created in the central server.

This currently does not happen for when the store is a secondary store.

See transcript of chat session (attached) for details.
Steps To ReproduceRun multi-server
Put central down, store goes offline
Create a BP in the store, set default store to Store1, flag as standard BP
Create a ticket for the BP in the store
Put central up again
Ticket and Bp get replicated but no BP-store relation is created
Proposed SolutionAdd a writerfilteradapter which listens to bpartner writes to central and creates the store-bp relations where needed.

Exclude the default store column from being replicated to store or central. Recompute the info all the time in central
TagsNo tags attached.
Attached Files? file icon chat session [^] (6,200 bytes) 2017-05-18 11:03 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0096704)
hgbot (developer)
2017-05-22 12:18

 Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization
Changeset: c11bd40e2aff45be5deb7ea7c794aa13aaeb592d
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon May 22 12:18:29 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/c11bd40e2aff45be5deb7ea7c794aa13aaeb592d [^]

Fixes issue 36036: When BP is created in the store then the store-Business-Partner relation is not created in central when Store goes to online
Create secondary synchronization relation in store server which gets replicated to the central server, on central server catch the
replication and create either primary or allow secondary relation if does not yet exist.
Added synchronized table to sync bp-store table from store to central.

---
M src-db/database/sourcedata/STRSYNC_SYNCHRONIZEDTABLE.xml
M src/org/openbravo/retail/storeserver/synchronization/VersionCacheResetWriterFilterAdapter.java
M src/org/openbravo/retail/storeserver/synchronization/utils/BusinessPartnerSegmentationUtils.java
A src/org/openbravo/retail/storeserver/synchronization/BPartnerStoreWriterFilterAdapter.java
---
(0096721)
AugustoMauch (manager)
2017-05-22 17:30

 Reopened because it is not possible to reproduce it with the steps given
(0097174)
hgbot (developer)
2017-06-06 23:06

 Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization
Changeset: d678475e4ce9e3af65f6328ea4636abad953e660
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Jun 06 23:06:06 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/d678475e4ce9e3af65f6328ea4636abad953e660 [^]

Fixes issue 36036: When BP is created in the store then the store-Business-Partner relation is not created in central when Store goes to online
Also compute the BP store relations in the store server

---
M src/org/openbravo/retail/storeserver/synchronization/eventhandler/OrderEventHandler.java
---
(0097175)
mtaal (manager)
2017-06-06 23:06
edited on: 2017-06-06 23:48

 Changed the approach. Is much simpler, if a bpartner is created/updated in a store server and then replicated to central then we must assume that the BPartner should be linked to that store also. So then create the needed BP-store relations on write in central.

Is simpler and does not require to sync the bpartner-store relation, only do some additional actions when syncing a bpartner to central (which does not happen often, only in offline mode).

Adapted the description of the issue.

Reverted part of previous commits.
(0097177)
mtaal (manager)
2017-06-07 00:24

 Test scenario:
- create BP in the store
- check that it gets replicated to central and that the default store is set
- then change the default store in central to something else (not-null)
- update the BP in the store by changing the tax id
- check that in central an additional store-BP relation is created
- then remove that relation in central and clear the default store in the BP in central
- update the BP in the store by changing the tax id
- check that in central the default store is set
(0097178)
hgbot (developer)
2017-06-07 00:28

 Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization
Changeset: 08cd4d0acc2de76be76b5ff106450bfbd640096c
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Jun 07 00:26:09 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/08cd4d0acc2de76be76b5ff106450bfbd640096c [^]

Fixes issue 36036: When BP is created in the store then the store-Business-Partner relation is not created in central when Store goes to online
Create the BP-store relation in central whenever a BP is created/changed/updated within the store

---
M src-db/database/sourcedata/STRSYNC_EXCLUDEDCOL.xml
M src-db/database/sourcedata/STRSYNC_SYNCHRONIZEDTABLE.xml
M src/org/openbravo/retail/storeserver/synchronization/BPartnerStoreWriterFilterAdapter.java
M src/org/openbravo/retail/storeserver/synchronization/eventhandler/OrderEventHandler.java
M src/org/openbravo/retail/storeserver/synchronization/utils/BusinessPartnerSegmentationUtils.java
---
(0097179)
hgbot (developer)
2017-06-07 00:28

 Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization
Changeset: 15dcded8c52b24193c66e5ac2469132bb49b86d2
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Jun 07 00:28:14 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/15dcded8c52b24193c66e5ac2469132bb49b86d2 [^]

Related to issue 36036: When BP is created in the store then the store-Business-Partner relation is not created in central when Store goes to online
Only exclude the default store from store to central

---
M src-db/database/sourcedata/STRSYNC_EXCLUDEDCOL.xml
---
(0097424)
hgbot (developer)
2017-06-15 18:30

 Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization
Changeset: bb7e2091aed300f29bbdd5b823aca014fbb68505
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Jun 15 18:29:15 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/bb7e2091aed300f29bbdd5b823aca014fbb68505 [^]

Related with issue 36036: If business partner does not exist, continue

If there is no business partner with the given ID, just continue. Without this change, a query would be done that would result in no business partner being updated. If we know that in advance, better not make the query.

---
M src/org/openbravo/retail/storeserver/synchronization/BPartnerStoreWriterFilterAdapter.java
---
(0097605)
AugustoMauch (manager)
2017-06-23 11:14

 Code reviewed and verified

- Issue History
Date Modified Username Field Change
2017-05-18 11:02 mtaal New Issue
2017-05-18 11:02 mtaal Assigned To => mtaal
2017-05-18 11:02 mtaal Triggers an Emergency Pack => No
2017-05-18 11:03 mtaal File Added: chat session
2017-05-22 12:18 hgbot Checkin
2017-05-22 12:18 hgbot Note Added: 0096704
2017-05-22 12:18 hgbot Status new => resolved
2017-05-22 12:18 hgbot Resolution open => fixed
2017-05-22 12:18 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/c11bd40e2aff45be5deb7ea7c794aa13aaeb592d [^]
2017-05-22 12:19 mtaal Review Assigned To => AugustoMauch
2017-05-22 17:30 AugustoMauch Note Added: 0096721
2017-05-22 17:30 AugustoMauch Status resolved => new
2017-05-22 17:30 AugustoMauch Resolution fixed => open
2017-06-06 23:05 mtaal Steps to Reproduce Updated View Revisions
2017-06-06 23:06 hgbot Checkin
2017-06-06 23:06 hgbot Note Added: 0097174
2017-06-06 23:06 hgbot Status new => resolved
2017-06-06 23:06 hgbot Resolution open => fixed
2017-06-06 23:06 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/c11bd40e2aff45be5deb7ea7c794aa13aaeb592d [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/d678475e4ce9e3af65f6328ea4636abad953e660 [^]
2017-06-06 23:06 mtaal Note Added: 0097175
2017-06-06 23:45 mtaal Note Edited: 0097175 View Revisions
2017-06-06 23:48 mtaal Steps to Reproduce Updated View Revisions
2017-06-06 23:48 mtaal Proposed Solution updated
2017-06-06 23:48 mtaal Note Edited: 0097175 View Revisions
2017-06-06 23:48 mtaal Status resolved => new
2017-06-06 23:48 mtaal Resolution fixed => open
2017-06-07 00:24 mtaal Note Added: 0097177
2017-06-07 00:28 hgbot Checkin
2017-06-07 00:28 hgbot Note Added: 0097178
2017-06-07 00:28 hgbot Status new => resolved
2017-06-07 00:28 hgbot Resolution open => fixed
2017-06-07 00:28 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/d678475e4ce9e3af65f6328ea4636abad953e660 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/08cd4d0acc2de76be76b5ff106450bfbd640096c [^]
2017-06-07 00:28 hgbot Checkin
2017-06-07 00:28 hgbot Note Added: 0097179
2017-06-15 18:30 hgbot Checkin
2017-06-15 18:30 hgbot Note Added: 0097424
2017-06-23 11:14 AugustoMauch Note Added: 0097605
2017-06-23 11:14 AugustoMauch Status resolved => closed
2017-06-23 11:14 AugustoMauch Fixed in Version => RR17Q3

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker