Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0036015 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] Z. Others | major | always | 2017-05-16 17:55 | 2017-05-30 20:59 | |||
| Reporter | maite | View Status | public | |||||
| Assigned To | collazoandy4 | |||||||
| Priority | urgent | Resolution | fixed | Fixed in Version | 3.0PR17Q3 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 816a40caaba9 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | aferraz | |||||||
| Web browser | ||||||||
| Modules | Advanced Payables and Receivables Mngmt | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0036015: Partial match confirmation shown when no difference between bankstatementline and sum of transactions exists | |||||||
| Description | Root cause of problem is due to number of decimals > 2 is calculated by javascript when working with elements having 2 decimals | |||||||
| Steps To Reproduce | 1. Access Financial Account "cuenta de banco" and register new transaction related with gl item and Deposit Amount=3369.45. Process 2. Register another transaction related with gl item and Deposit Amount=1288.02. Process 3. Register new Bank Statement. Add line with Amount IN=4657.47. Process bank statement 4. Run "Match Statement" process, press "CANCEL" to not run algorithm and press "Search" in bankstatementline 5. Select transaction of 1288.02 and then select transaction of 3369.45 and press Done 6. Realize that "Bank statement line amount [4657.47] and transaction amount [4657.47] does not match. Do you want to perform a partial match?" confirmation pop-up appears when it should not | |||||||
| Proposed Solution | Problem is in file "ob-aprm-findTransaction.js", when "totalTrxAmt = totalTrxAmt + trxAmt;" is executed as "1288.02 + 3369.45= 4657.469999999999" Possible solution could be to use "OB.DEC.add(a, b)" function which is used in retail code | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0096824) collazoandy4 (reporter) 2017-05-26 00:05 |
Test Plan Go to Financial Account window and select "Cuenta de banco" record. In Transaction tab create a new record: G/L Item: Capital social Deposit Amount: 3369.45 Process the transaction In Transaction tab create another record: G/L Item: Capital social Deposit Amount: 1288.02 Process the transaction In Imported Bank Statements tab create a new record Name: Issue In Bank Statements Lines tab create a new record Reference No.: Issue Amount IN: 4657.47 Process Clic on Match Statement button and press CANCEL to not run algorithm: In the record press "Search" Select transaction of 1288.02 and then select transaction of 3369.45 and press Done Realize that no error is shown |
|
(0097002) hgbot (developer) 2017-05-30 10:08 |
Repository: erp/devel/pi Changeset: 816a40caaba96844c4de384537155528791eacc1 Author: Armaignac <collazoandy4 <at> gmail.com> Date: Thu May 25 17:01:51 2017 -0400 URL: http://code.openbravo.com/erp/devel/pi/rev/816a40caaba96844c4de384537155528791eacc1 [^] Fixes issue 36015: Rounding issue when adding transactions in Match Statement A wrong compare was made betweent bank statement line and transactions amount because a rounding problem. BigDecimal will be used for totalTrxAmt, blineAmt, trxDepositAmt, trxPaymentAmt and trxAmt variables to avoid this rounding problem. --- M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-findTransaction.js --- |
|
(0097004) aferraz (manager) 2017-05-30 10:10 |
Code review + Testing OK |
|
(0097037) hudsonbot (developer) 2017-05-30 20:59 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b1bab5011974 [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2017-05-16 17:55 | maite | New Issue | |
| 2017-05-16 17:55 | maite | Assigned To | => Triage Finance |
| 2017-05-16 17:55 | maite | Modules | => Advanced Payables and Receivables Mngmt |
| 2017-05-16 17:55 | maite | Resolution time | => 1496700000 |
| 2017-05-16 17:55 | maite | Triggers an Emergency Pack | => No |
| 2017-05-16 17:55 | maite | Issue Monitored: networkb | |
| 2017-05-17 13:34 | aferraz | Assigned To | Triage Finance => collazoandy4 |
| 2017-05-23 22:40 | collazoandy4 | Status | new => scheduled |
| 2017-05-26 00:05 | collazoandy4 | Note Added: 0096824 | |
| 2017-05-30 10:08 | hgbot | Checkin | |
| 2017-05-30 10:08 | hgbot | Note Added: 0097002 | |
| 2017-05-30 10:08 | hgbot | Status | scheduled => resolved |
| 2017-05-30 10:08 | hgbot | Resolution | open => fixed |
| 2017-05-30 10:08 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/816a40caaba96844c4de384537155528791eacc1 [^] |
| 2017-05-30 10:10 | aferraz | Review Assigned To | => aferraz |
| 2017-05-30 10:10 | aferraz | Note Added: 0097004 | |
| 2017-05-30 10:10 | aferraz | Status | resolved => closed |
| 2017-05-30 10:10 | aferraz | Fixed in Version | => 3.0PR17Q3 |
| 2017-05-30 20:59 | hudsonbot | Checkin | |
| 2017-05-30 20:59 | hudsonbot | Note Added: 0097037 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |