Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0035901

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Cash up

major

always

2017-05-03 00:31

2017-05-15 09:29

Reporter

Osmany

View Status

public

Assigned To

mario_castello

Priority

high

Resolution

fixed

Fixed in Version

RR17Q3

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Review Assigned To

marvintm

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0035901: [SER-QA 2806] Not appears message with configuration special for Slave Terminal.

Description

Not appears message with configuration special for Slave Terminal.

Steps To Reproduce

Preconditions:

Open hardware manager.

Apply diff (compile) for reproduce issue. changeForReproduce.diff

Log in ERP

Navigate to POS Terminal window.

Search: VBS-1. Check Master.

Search: VBS1001. Add in Master Terminal: VBS POS Terminal

Steps to reproduce:

Log in Web POS. Opening slave terminal: VBS1001.

Menu. Cashup

Should be appears a message(POPUP) in this moment.

Tags

changeForReproduce.diff [^] (628 bytes) 2017-05-03 00:31 [Show Content] [Hide Content]

diff --git a/src/org/openbravo/retail/posterminal/ProcessCashCloseSlave.java b/src/org/openbravo/retail/posterminal/ProcessCashCloseSlave.java
--- a/src/org/openbravo/retail/posterminal/ProcessCashCloseSlave.java
+++ b/src/org/openbravo/retail/posterminal/ProcessCashCloseSlave.java
@@ -30,7 +30,7 @@
     JSONObject result = new JSONObject();
     JSONObject data = new JSONObject();
     boolean hasMaster = appCashup != null && appCashup.getObposParentCashup() != null;
-    data.put("hasMaster", hasMaster);
+    data.put("hasMaster", false);
     result.put("data", data);
     result.put("status", 0);
     return result;

ProposedSolution.diff [^] (1,005 bytes) 2017-05-03 00:32 [Show Content] [Hide Content]

diff --git a/web/org.openbravo.retail.posterminal/js/closecash/view/closecash.js b/web/org.openbravo.retail.posterminal/js/closecash/view/closecash.js
--- a/web/org.openbravo.retail.posterminal/js/closecash/view/closecash.js
+++ b/web/org.openbravo.retail.posterminal/js/closecash/view/closecash.js
@@ -436,8 +436,13 @@
             if (data.hasMaster) {
               me.moveStep(0);
             } else {
-              OB.UTIL.showConfirmation.display(OB.I18N.getLabel('OBPOS_CashUpWronglyHeader'), OB.I18N.getLabel('OBPOS_ErrCashupMasterNotOpen'));
-              OB.POS.navigate('retail.pointofsale');
+              OB.UTIL.showConfirmation.display(
+              OB.I18N.getLabel('OBPOS_CashUpWronglyHeader'), OB.I18N.getLabel('OBPOS_ErrCashupMasterNotOpen'), null, {
+                autoDismiss: false,
+                onHideFunction: function () {
+                  OB.POS.navigate('retail.pointofsale');
+                }
+              });
             }
           });
         } else {

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0096387) hgbot (developer) 2017-05-04 15:42	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: da5065cec8842dc4ecfa3875fb9c719c741a9a31 Author: Mario Castello <mario.castello <at> peoplewalking.com> Date: Wed May 03 08:18:10 2017 -0600 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/da5065cec8842dc4ecfa3875fb9c719c741a9a31 [^] Fixed issue 0035901: [SER-QA 2806] Not appears message with configuration special for Slave Terminal - Show the error message and navigate after the popup is closed --- M web/org.openbravo.retail.posterminal/js/closecash/view/closecash.js ---

(0096388) hgbot (developer) 2017-05-04 15:46	Repository: tools/automation/pi-mobile Changeset: 137eebe0486fb35aafbcf3f9791a817185baee37 Author: Mario Castello <mario.castello <at> peoplewalking.com> Date: Wed May 03 10:23:37 2017 -0600 URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/137eebe0486fb35aafbcf3f9791a817185baee37 [^] Verifies issue 35901: Added automated test 'I35901_SPMVerifyErrorPopupInSlave' --- A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sharedpaymentmethods/I35901_SPMVerifyErrorPopupInSlave.java ---

Issue History
Date Modified	Username	Field	Change
2017-05-03 00:31	Osmany	New Issue
2017-05-03 00:31	Osmany	Assigned To	=> mario_castello
2017-05-03 00:31	Osmany	File Added: changeForReproduce.diff
2017-05-03 00:31	Osmany	Resolution time	=> 1494799200
2017-05-03 00:31	Osmany	Triggers an Emergency Pack	=> No
2017-05-03 00:32	Osmany	Tag Attached: SER-QA
2017-05-03 00:32	Osmany	File Added: ProposedSolution.diff
2017-05-03 16:00	mario_castello	Status	new => acknowledged
2017-05-03 16:00	mario_castello	Status	acknowledged => scheduled
2017-05-04 15:42	hgbot	Checkin
2017-05-04 15:42	hgbot	Note Added: 0096387
2017-05-04 15:42	hgbot	Status	scheduled => resolved
2017-05-04 15:42	hgbot	Resolution	open => fixed
2017-05-04 15:42	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/da5065cec8842dc4ecfa3875fb9c719c741a9a31 [^]
2017-05-04 15:46	hgbot	Checkin
2017-05-04 15:46	hgbot	Note Added: 0096388
2017-05-15 09:29	marvintm	Review Assigned To	=> marvintm
2017-05-15 09:29	marvintm	Status	resolved => closed
2017-05-15 09:29	marvintm	Fixed in Version	=> RR17Q3

Copyright © 2000 - 2009 MantisBT Group