Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0035615 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [Retail Modules] Web POS | major | always | 2017-03-22 17:00 | 2017-04-20 10:22 | |||
| Reporter | malsasua | View Status | public | |||||
| Assigned To | guilleaer | |||||||
| Priority | immediate | Resolution | fixed | Fixed in Version | RR16Q4.3 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | e44647517176 | ||||
| Projection | none | ETA | none | Target Version | RR16Q4.3 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | jorge-garcia | |||||||
| Regression level | Production - Confirmed Stable | |||||||
| Regression date | 2016-07-15 | |||||||
| Regression introduced in release | RR16Q4 | |||||||
| Regression introduced by commit | https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8ee815642094 [^] | |||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0035615: It is not possible to process one receipt in Error While Importing, if the cashup has been completed | |||||||
| Description | If a receipt is stuck in error while importing (for example, error1), the cashup related to this receipt is completed in Terminal (it is stuck in Error While Importing). Then, the original problem with receipt is fixed (error1 is fixed) and you try to save again the receipt, then the next error is returned: "The cashup is processed, and it can not be set as unprocessed" | |||||||
| Steps To Reproduce | in backend: . close current period (in Open/Close period control window) in POS: . do a receipt: R1 in backend: . in Open/Close period control: open current period in terminal: . complete the cashup: C1 in backend: . in errors while importing there are two records: R1 error -> "The Period does not exist or it is not opened" C1 error -> "There are errors related to non-created customers..." save again R1-> error is returned: "The cashup is processed, and it can not be set as unprocessed" | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0096055) hgbot (developer) 2017-04-18 18:09 |
Repository: retail/backports/3.0RR16Q4.3/org.openbravo.retail.posterminal Changeset: e4464751717632432e9bce628e0c04653acd163d Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com> Date: Tue Apr 18 18:09:07 2017 +0200 URL: http://code.openbravo.com/retail/backports/3.0RR16Q4.3/org.openbravo.retail.posterminal/rev/e4464751717632432e9bce628e0c04653acd163d [^] Fixed issue 35615, backport of 35602. It's now possible to save again orders in the Errors window, if cashup was also sent. From 16Q4 onwards, the cashup is automatically updated every time an order, cash management, ... is sent to the backend, as part of the process which also updates the record. This makes sense in general , so that the cashup information is always updated, and even if the user clears the cache, it's possible to recover it again. However, when the cashup has already been sent to the backend, this update is not really needed, and it was causing trouble because at that point, the cashup is marked as processed, which triggered the check that ensures that a processed cashup is not changed back to being not processed. The solution we have decided is to ensure that lastCashupReportDate is updated when the cashup is sent to the backend, even it if fails. This in turn means that any record which was created previously will not update the cashup information whenever it is saved again, and therefore it will not trigger the check which fails whenever isProcessed is changed from Y to N. This is not a problem, because the cashup processing will update the cashup information with the final values. --- M src/org/openbravo/retail/posterminal/ProcessCashClose.java M src/org/openbravo/retail/posterminal/UpdateCashup.java --- |
|
(0096083) jorge-garcia (reporter) 2017-04-20 10:22 |
Code reviewed and tested |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2017-03-24 13:56 | marvintm | Type | defect => backport |
| 2017-03-24 13:56 | marvintm | Target Version | => RR16Q4.3 |
| 2017-03-24 14:57 | marvintm | Assigned To | mario_castello => marvintm |
| 2017-04-18 18:09 | hgbot | Checkin | |
| 2017-04-18 18:09 | hgbot | Note Added: 0096055 | |
| 2017-04-18 18:09 | hgbot | Status | scheduled => resolved |
| 2017-04-18 18:09 | hgbot | Resolution | open => fixed |
| 2017-04-18 18:09 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/retail/backports/3.0RR16Q4.3/org.openbravo.retail.posterminal/rev/e4464751717632432e9bce628e0c04653acd163d [^] |
| 2017-04-18 20:20 | guilleaer | Assigned To | marvintm => guilleaer |
| 2017-04-20 10:22 | jorge-garcia | Review Assigned To | => jorge-garcia |
| 2017-04-20 10:22 | jorge-garcia | Note Added: 0096083 | |
| 2017-04-20 10:22 | jorge-garcia | Status | resolved => closed |
| 2017-04-20 10:22 | jorge-garcia | Fixed in Version | => RR16Q4.3 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |