0035608: Manufacturing Plan suggestion not working with Quantity type Exact selected

(0095774)
collazoandy4 (reporter)
2017-03-31 18:28
edited on: 2017-04-28 13:01

Test Plan
   Go to Planner window and create a new record:
     Name: Product Planner

   Go to Planning Method and create a new record:
     Name: Product Planning Method
     In Lines tab create a new record:
       Transaction type: Material Requirement
       Weighting: 1
     In Lines tab create another record:
       Transaction type: Pending Purchase Order
       Weighting: 1
     In Lines tab create another record:
       Transaction type: Pending Sales Order
       Weighting: 1
     In Lines tab create another record:
       Transaction type: Pending Work Requirement
       Weighting: 1
     In Lines tab create another record:
       Transaction type: Sales Forecast
       Weighting: 1

   Go to Product window and create a new record:
     Search Key / Name: Product
     Production: Y
     Purchase: N
     In Price tab create a new record:
       Price list Version: Tarifa de ventas
       Unit Price / List Price: 8
     In Price tab create another record:
       Price list Version: Tarifa Bebidas alegres
       Unit Price / List Price: 7
     In Manufacturing tab create a new record:
       Storage bin: RN-1-0-0
       Planning method: Product Planning Method
       Planner: Product Planner
       Capacity: 300
       Min Quantity: 100
       Quantity Type: Exact
       Standar Quantity: 260
       Minimum Lead Time: 1
       Safety Stock: 0
   Go to Activity window and create a new record:
     Search Key / Name: Product Activity

   Go to Process Plan window and create a new record:
     Search Key / Name: Build Product
     In Version tab create a new record:
       Starting Date: 01-01-2016
       Ending Date: 01-01-2018
     In Operation tab create a new record:
       Search Key / Name: Product Operation
       Activity: Product Activity
       Multiplier: 1
     In I/O Product tab create a new record:
       Product: Product
       Production Type: Product Production (P+)
       Quantity: 1

   Go to MRP Forecast window and create a new record:
     Document date: today
     Business Partner: Alimentos y Supermercados, S.A
     In Lines tab create a new record :
       Planned Date: next week
       Product: Product
       Quantity: 530
   Go to Manufacturing Plan and create a new record:
     Name: Test1
     Time Horizon: 20
     Safety Lead Time: 2
     Product: Product
     Process the Manufacturing Plan and check
       One line of Suggested Work Requirement was created with quantity = 260, required quantity = 530 and total movement quantity = 260
       One line of Suggested Work Requirement was created with quantity = 260, required quantity = 530 and total movement quantity = 520
       One line of Suggested Work Requirement was created with quantity = 260, required quantity = 530 and total movement quantity = 780
       One line of Sales Forecast was created with quantity/required quantity = -530 and total movement quantity = 250
       Stock and Minimun Stock lines was created with quantity/required quantity/total movement quantity = 0

   Go to MRP Forecast window and edit the previous line created with quantity = 200
   Go to Manufacturing Plan and create a new record:
     Name: Test2
     Time Horizon: 20
     Safety Lead Time: 2
     Product: Product
     Process the Manufacturing Plan and check
       One line of Suggested Work Requirement was created with quantity = 260, required quantity = 200 and total movement quantity = 260
       One line of Sales Forecast was created with quantity/required quantity = -200 and total movement quantity = 0
       Stock and Minimun Stock lines was created with quantity/required quantity/total movement quantity = 0

   Go to MRP Forecast window and edit the previous line created with quantity = 50
   Go to Manufacturing Plan and create a new record:
     Name: Test3
     Time Horizon: 20
     Safety Lead Time: 2
     Product: Product
     Process the Manufacturing Plan and check
       One line of Suggested Work Requirement was created with quantity = 260, required quantity = 50 and total movement quantity = 260
       One line of Sales Forecast was created with quantity/required quantity = -50 and total movement quantity = 210
       Stock and Minimun Stock lines was created with quantity/required quantity/total movement quantity = 0

   Go to the previous product created and edit the manufacturing plan created:
     Standard Quantity: 3
   Go to MRP Forecast window and edit the previous line created with quantity = 100
   Go to Manufacturing Plan and create a new record:
     Name: Test4
     Time Horizon: 20
     Safety Lead Time: 2
     Product: Product
     Process the Manufacturing Plan and check
       34 lines of Suggested Work Requirement was created with quantity = 3, required quantity = 100 and the last one with total movement quantity = 102
       One line of Sales Forecast was created with quantity/required quantity = -100 and total movement quantity = 2
       Stock and Minimun Stock lines was created with quantity/required quantity/total movement quantity = 0

   Go to the previous product created and edit the manufacturing plan created:
     Standard Quantity: 20
   Go to MRP Forecast window and edit the previous line created with quantity = 85
   Go to Manufacturing Plan and create a new record:
     Name: Test5
     Time Horizon: 20
     Safety Lead Time: 2
     Product: Product
     Process the Manufacturing Plan and check
       5 lines of Suggested Work Requirement was created with quantity = 20, required quantity = 85 and the last one with total movement quantity = 100
       One line of Sales Forecast was created with quantity/required quantity = -85 and total movement quantity = 15
       Stock and Minimun Stock lines was created with quantity/required quantity/total movement quantity = 0

   Go to the previous product created and edit the manufacturing plan created:
     Standard Quantity: 3
   Go to MRP Forecast window and edit the previous line created with quantity = 50
   Go to Manufacturing Plan and create a new record:
     Name: Test6
     Time Horizon: 20
     Safety Lead Time: 2
     Product: Product
     Process the Manufacturing Plan and check
       34 lines of Suggested Work Requirement was created with quantity = 3, required quantity = 50 and the last one with total movement quantity = 102
       One line of Sales Forecast was created with quantity/required quantity = -50 and total movement quantity = 52
       Stock and Minimun Stock lines was created with quantity/required quantity/total movement quantity = 0

   Go to the previous product created and edit the manufacturing plan created:
     Empty Quantity Type
     Standard Quantity: 260
   Go to MRP Forecast window and edit the previous line created with quantity = 260
   Go to Manufacturing Plan and create a new record:
     Name: Test7
     Time Horizon: 20
     Safety Lead Time: 2
     Product: Product
     Process the Manufacturing Plan and check
       One line of Suggested Work Requirement was created with quantity/required quantity/total movement quantity = 260
       One line of Sales Forecast was created with quantity/required quantity = -260 and total movement quantity = 0
       Stock and Minimun Stock lines was created with quantity/required quantity/total movement quantity = 0

(0095775)
collazoandy4 (reporter)
2017-03-31 18:42

The steps to reproduce needs to be improve, No new lines created in the Manufacturing Plan process

(0095827)
lmonreal (developer)
2017-04-04 18:35

In Product in the Manufacturing tab, can you please leave the field Planner blank and try again?
I have seen that later in the Manufacturing Plan window planner has not been selected so this can be the reason why lines are not being created.
In both cases (manufacturing tab and manufacturing plan window) Planner should be the same (blank or Product Planner as you have configured it).

(0096258)
hgbot (developer)
2017-04-28 12:56

Repository: erp/devel/pi
Changeset: 16c0d76f62ba93c75c9fd4b13db2eaf13dfc0ddd
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Tue Apr 11 19:56:12 2017 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/16c0d76f62ba93c75c9fd4b13db2eaf13dfc0ddd [^]

Fixes issue 35608: Manufacturing Plan suggestion not working with qtytype Exact

The manufacturing plan suggestion lines doesn't take into account the quantity type
exact when the Standard Quantity is not null and not exact quantity lines are created

The mrp_run_expode function was modified in order to create many as required
manufacturing plan suggestions lines according to the needed qty

The mrp_processplan_plan function was modified to process those lines with a non
equal qty and neededqty. Also correct the line quantities according to the production
quantity

---
M src-db/database/model/functions/MRP_PROCESSPLAN_PLAN.xml
M src-db/database/model/functions/MRP_RUN_EXPLODE.xml
---

(0096260)
aferraz (manager)
2017-04-28 13:05
edited on: 2017-04-28 13:06

Alternative test plan:

https://docs.google.com/a/openbravo.com/spreadsheets/d/1hMIRW2KpKS8ambPPXzYCeEWyw-YWa5kleS9z6mcJ9Kk/edit?usp=sharing [^]

(0096261)
aferraz (manager)
2017-04-28 13:06

Code review + Testing OK

(0096916)
hudsonbot (developer)
2017-05-29 17:43

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1ee70113bdc4 [^]
Maturity status: Test

Issue History
Date Modified	Username	Field	Change
2017-03-23 13:48	lmonreal	New Issue
2017-03-23 13:48	lmonreal	Assigned To	=> Triage Finance
2017-03-23 13:48	lmonreal	File Added: Captura.PNG
2017-03-23 13:48	lmonreal	Modules	=> Core
2017-03-23 13:48	lmonreal	Resolution time	=> 1492898400
2017-03-23 13:48	lmonreal	Triggers an Emergency Pack	=> No
2017-03-23 13:48	lmonreal	File Added: 1.PNG
2017-03-23 13:48	lmonreal	File Added: 2.PNG
2017-03-24 16:01	markmm82	Assigned To	Triage Finance => collazoandy4
2017-03-31 18:28	collazoandy4	Note Added: 0095774
2017-03-31 18:40	collazoandy4	Assigned To	collazoandy4 => lmonreal
2017-03-31 18:42	collazoandy4	Note Added: 0095775
2017-03-31 18:42	collazoandy4	Status	new => feedback
2017-04-04 18:35	lmonreal	Note Added: 0095827
2017-04-05 18:37	collazoandy4	Status	feedback => scheduled
2017-04-06 10:23	aferraz	Assigned To	lmonreal => collazoandy4
2017-04-12 16:46	collazoandy4	Note Edited: 0095774	View Revisions
2017-04-26 10:18	aferraz	Note Edited: 0095774	View Revisions
2017-04-26 17:56	collazoandy4	Note Edited: 0095774	View Revisions
2017-04-26 21:07	collazoandy4	Note Edited: 0095774	View Revisions
2017-04-27 19:25	collazoandy4	Note Edited: 0095774	View Revisions
2017-04-28 12:56	hgbot	Checkin
2017-04-28 12:56	hgbot	Note Added: 0096258
2017-04-28 12:56	hgbot	Status	scheduled => resolved
2017-04-28 12:56	hgbot	Resolution	open => fixed
2017-04-28 12:56	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/16c0d76f62ba93c75c9fd4b13db2eaf13dfc0ddd [^]
2017-04-28 13:01	aferraz	Note Edited: 0095774	View Revisions
2017-04-28 13:05	aferraz	Note Added: 0096260
2017-04-28 13:05	aferraz	Note Edited: 0096260	View Revisions
2017-04-28 13:06	aferraz	Note Edited: 0096260	View Revisions
2017-04-28 13:06	aferraz	Review Assigned To	=> aferraz
2017-04-28 13:06	aferraz	Note Added: 0096261
2017-04-28 13:06	aferraz	Status	resolved => closed
2017-04-28 13:06	aferraz	Fixed in Version	=> 3.0PR17Q3
2017-05-29 17:43	hudsonbot	Checkin
2017-05-29 17:43	hudsonbot	Note Added: 0096916
2017-08-16 09:07	aferraz	Relationship added	related to 0036647

Notes
(0095774) collazoandy4 (reporter) 2017-03-31 18:28 edited on: 2017-04-28 13:01	Test Plan Go to Planner window and create a new record: Name: Product Planner Go to Planning Method and create a new record: Name: Product Planning Method In Lines tab create a new record: Transaction type: Material Requirement Weighting: 1 In Lines tab create another record: Transaction type: Pending Purchase Order Weighting: 1 In Lines tab create another record: Transaction type: Pending Sales Order Weighting: 1 In Lines tab create another record: Transaction type: Pending Work Requirement Weighting: 1 In Lines tab create another record: Transaction type: Sales Forecast Weighting: 1 Go to Product window and create a new record: Search Key / Name: Product Production: Y Purchase: N In Price tab create a new record: Price list Version: Tarifa de ventas Unit Price / List Price: 8 In Price tab create another record: Price list Version: Tarifa Bebidas alegres Unit Price / List Price: 7 In Manufacturing tab create a new record: Storage bin: RN-1-0-0 Planning method: Product Planning Method Planner: Product Planner Capacity: 300 Min Quantity: 100 Quantity Type: Exact Standar Quantity: 260 Minimum Lead Time: 1 Safety Stock: 0 Go to Activity window and create a new record: Search Key / Name: Product Activity Go to Process Plan window and create a new record: Search Key / Name: Build Product In Version tab create a new record: Starting Date: 01-01-2016 Ending Date: 01-01-2018 In Operation tab create a new record: Search Key / Name: Product Operation Activity: Product Activity Multiplier: 1 In I/O Product tab create a new record: Product: Product Production Type: Product Production (P+) Quantity: 1 Go to MRP Forecast window and create a new record: Document date: today Business Partner: Alimentos y Supermercados, S.A In Lines tab create a new record : Planned Date: next week Product: Product Quantity: 530 Go to Manufacturing Plan and create a new record: Name: Test1 Time Horizon: 20 Safety Lead Time: 2 Product: Product Process the Manufacturing Plan and check One line of Suggested Work Requirement was created with quantity = 260, required quantity = 530 and total movement quantity = 260 One line of Suggested Work Requirement was created with quantity = 260, required quantity = 530 and total movement quantity = 520 One line of Suggested Work Requirement was created with quantity = 260, required quantity = 530 and total movement quantity = 780 One line of Sales Forecast was created with quantity/required quantity = -530 and total movement quantity = 250 Stock and Minimun Stock lines was created with quantity/required quantity/total movement quantity = 0 Go to MRP Forecast window and edit the previous line created with quantity = 200 Go to Manufacturing Plan and create a new record: Name: Test2 Time Horizon: 20 Safety Lead Time: 2 Product: Product Process the Manufacturing Plan and check One line of Suggested Work Requirement was created with quantity = 260, required quantity = 200 and total movement quantity = 260 One line of Sales Forecast was created with quantity/required quantity = -200 and total movement quantity = 0 Stock and Minimun Stock lines was created with quantity/required quantity/total movement quantity = 0 Go to MRP Forecast window and edit the previous line created with quantity = 50 Go to Manufacturing Plan and create a new record: Name: Test3 Time Horizon: 20 Safety Lead Time: 2 Product: Product Process the Manufacturing Plan and check One line of Suggested Work Requirement was created with quantity = 260, required quantity = 50 and total movement quantity = 260 One line of Sales Forecast was created with quantity/required quantity = -50 and total movement quantity = 210 Stock and Minimun Stock lines was created with quantity/required quantity/total movement quantity = 0 Go to the previous product created and edit the manufacturing plan created: Standard Quantity: 3 Go to MRP Forecast window and edit the previous line created with quantity = 100 Go to Manufacturing Plan and create a new record: Name: Test4 Time Horizon: 20 Safety Lead Time: 2 Product: Product Process the Manufacturing Plan and check 34 lines of Suggested Work Requirement was created with quantity = 3, required quantity = 100 and the last one with total movement quantity = 102 One line of Sales Forecast was created with quantity/required quantity = -100 and total movement quantity = 2 Stock and Minimun Stock lines was created with quantity/required quantity/total movement quantity = 0 Go to the previous product created and edit the manufacturing plan created: Standard Quantity: 20 Go to MRP Forecast window and edit the previous line created with quantity = 85 Go to Manufacturing Plan and create a new record: Name: Test5 Time Horizon: 20 Safety Lead Time: 2 Product: Product Process the Manufacturing Plan and check 5 lines of Suggested Work Requirement was created with quantity = 20, required quantity = 85 and the last one with total movement quantity = 100 One line of Sales Forecast was created with quantity/required quantity = -85 and total movement quantity = 15 Stock and Minimun Stock lines was created with quantity/required quantity/total movement quantity = 0 Go to the previous product created and edit the manufacturing plan created: Standard Quantity: 3 Go to MRP Forecast window and edit the previous line created with quantity = 50 Go to Manufacturing Plan and create a new record: Name: Test6 Time Horizon: 20 Safety Lead Time: 2 Product: Product Process the Manufacturing Plan and check 34 lines of Suggested Work Requirement was created with quantity = 3, required quantity = 50 and the last one with total movement quantity = 102 One line of Sales Forecast was created with quantity/required quantity = -50 and total movement quantity = 52 Stock and Minimun Stock lines was created with quantity/required quantity/total movement quantity = 0 Go to the previous product created and edit the manufacturing plan created: Empty Quantity Type Standard Quantity: 260 Go to MRP Forecast window and edit the previous line created with quantity = 260 Go to Manufacturing Plan and create a new record: Name: Test7 Time Horizon: 20 Safety Lead Time: 2 Product: Product Process the Manufacturing Plan and check One line of Suggested Work Requirement was created with quantity/required quantity/total movement quantity = 260 One line of Sales Forecast was created with quantity/required quantity = -260 and total movement quantity = 0 Stock and Minimun Stock lines was created with quantity/required quantity/total movement quantity = 0

(0095775) collazoandy4 (reporter) 2017-03-31 18:42	The steps to reproduce needs to be improve, No new lines created in the Manufacturing Plan process

(0095827) lmonreal (developer) 2017-04-04 18:35	In Product in the Manufacturing tab, can you please leave the field Planner blank and try again? I have seen that later in the Manufacturing Plan window planner has not been selected so this can be the reason why lines are not being created. In both cases (manufacturing tab and manufacturing plan window) Planner should be the same (blank or Product Planner as you have configured it).

(0096258) hgbot (developer) 2017-04-28 12:56	Repository: erp/devel/pi Changeset: 16c0d76f62ba93c75c9fd4b13db2eaf13dfc0ddd Author: Armaignac <collazoandy4 <at> gmail.com> Date: Tue Apr 11 19:56:12 2017 -0400 URL: http://code.openbravo.com/erp/devel/pi/rev/16c0d76f62ba93c75c9fd4b13db2eaf13dfc0ddd [^] Fixes issue 35608: Manufacturing Plan suggestion not working with qtytype Exact The manufacturing plan suggestion lines doesn't take into account the quantity type exact when the Standard Quantity is not null and not exact quantity lines are created The mrp_run_expode function was modified in order to create many as required manufacturing plan suggestions lines according to the needed qty The mrp_processplan_plan function was modified to process those lines with a non equal qty and neededqty. Also correct the line quantities according to the production quantity --- M src-db/database/model/functions/MRP_PROCESSPLAN_PLAN.xml M src-db/database/model/functions/MRP_RUN_EXPLODE.xml ---

(0096260) aferraz (manager) 2017-04-28 13:05 edited on: 2017-04-28 13:06	Alternative test plan: https://docs.google.com/a/openbravo.com/spreadsheets/d/1hMIRW2KpKS8ambPPXzYCeEWyw-YWa5kleS9z6mcJ9Kk/edit?usp=sharing [^]

(0096261) aferraz (manager) 2017-04-28 13:06	Code review + Testing OK

(0096916) hudsonbot (developer) 2017-05-29 17:43	A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1ee70113bdc4 [^] Maturity status: Test