0035551: [SERQA 2628] BeforeCustomerSave and BeforeCustomerAddrSave does not allow to access the window component.

Description

To allow make modifications or validations in the hooks before mandatory fields for the window has been checked it is necessary to add the window as an argument in the hook.

preCustomerSave and preCustomerAddressSave hooks, have the window as argument, but those hooks are executed before mandatory fields validation.

Steps To Reproduce

N/A

Proposed Solution

Attached patch

Tags

No tags attached.

Attached Files

customerSharedComponents.diff [^] (1,724 bytes) 2017-03-17 09:30 [Show Content] [Hide Content]

diff --git a/web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customeraddress/components/sharedcomponents.js b/web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customeraddress/components/sharedcomponents.js
--- a/web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customeraddress/components/sharedcomponents.js
+++ b/web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customeraddress/components/sharedcomponents.js
@@ -179,7 +179,8 @@
       if (validateForm(this)) {
         OB.UTIL.HookManager.executeHooks('OBPOS_BeforeCustomerAddrSave', {
           customerAddr: this.model.get('customerAddr'),
-          isNew: true
+          isNew: true,
+          windowComponent: me
         }, function (args) {
           if (args && args.cancellation && args.cancellation === true) {
             return true;
diff --git a/web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customers/components/sharedcomponents.js b/web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customers/components/sharedcomponents.js
--- a/web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customers/components/sharedcomponents.js
+++ b/web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customers/components/sharedcomponents.js
@@ -444,7 +444,8 @@
       OB.UTIL.HookManager.executeHooks('OBPOS_BeforeCustomerSave', {
         customer: customer,
         isNew: isNew,
-        validations: inEvent.validations
+        validations: inEvent.validations,
+        windowComponent: me
       }, function (args) {
         if (args && args.cancellation && args.cancellation === true) {
           return true;

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0095409) hgbot (developer) 2017-03-20 06:23	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: a0cec048d9c527b26b13d6dd731189c58062e368 Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Mon Mar 20 10:53:20 2017 +0530 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a0cec048d9c527b26b13d6dd731189c58062e368 [^] Fixes issue 35551 : Added Context as argument to Customer Save Hook for validations --- M web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customeraddress/components/sharedcomponents.js M web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customers/components/sharedcomponents.js ---

Issue History
Date Modified	Username	Field	Change
2017-03-17 09:30	kchoperena	New Issue
2017-03-17 09:30	kchoperena	Assigned To	=> Retail
2017-03-17 09:30	kchoperena	File Added: customerSharedComponents.diff
2017-03-17 09:30	kchoperena	Resolution time	=> 1490911200
2017-03-17 09:30	kchoperena	Triggers an Emergency Pack	=> No
2017-03-17 12:15	ranjith_qualiantech_com	Assigned To	Retail => ranjith_qualiantech_com
2017-03-17 12:15	ranjith_qualiantech_com	Status	new => scheduled
2017-03-20 06:23	hgbot	Checkin
2017-03-20 06:23	hgbot	Note Added: 0095409
2017-03-20 06:23	hgbot	Status	scheduled => resolved
2017-03-20 06:23	hgbot	Resolution	open => fixed
2017-03-20 06:23	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a0cec048d9c527b26b13d6dd731189c58062e368 [^]
2017-03-24 13:05	marvintm	Review Assigned To	=> marvintm
2017-03-24 13:05	marvintm	Status	resolved => closed
2017-03-24 13:05	marvintm	Fixed in Version	=> RR17Q2