0035515: It is not possible to add twice the same discount on the same line

Description

It is not possible to add twice the same discount on the same line for manual or manual by total.

This is preventing to add manual ones and it should not be needed or it should have more logic

      for (i = 0; i < promotions.length; i++) {
        if (promotions[i].ruleId === rule.id) {
          debugger;
          if (promotions[i].hidden !== true) {
            promotions[i] = disc;
            replaced = true;
            break;
          }
        }
      }

Regarding the Manual by Total it should be needed to review the discount engine and applyPromotions.

Steps To Reproduce

- Login on WebPOS
- Add a product
- Add a variable discount of 5€
- Add the same variable discount but now of 8€

There is only one of them

Proposed Solution

Allow to add them by default or by config

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

related to

feature request

0035391

new

guillermogil

The whole rule model should be inside the discount to apply

Notes
There are no notes attached to this issue.

Issue History
Date Modified	Username	Field	Change
2017-03-14 17:33	guillermogil	New Issue
2017-03-14 17:33	guillermogil	Assigned To	=> Retail
2017-03-14 17:33	guillermogil	Resolution time	=> 1459720800
2017-03-14 17:33	guillermogil	Triggers an Emergency Pack	=> No
2017-03-15 18:24	marvintm	Resolution time	1459720800 => 1491256800
2017-03-15 18:24	marvintm	Type	defect => design defect
2017-03-27 08:00	guillermogil	Assigned To	Retail => jorge-garcia
2017-03-27 08:00	guillermogil	Status	new => scheduled
2017-03-29 08:13	guillermogil	Relationship added	related to 0035391
2017-05-08 12:23	marvintm	Resolution time	1491256800 =>