0035515: It is not possible to add twice the same discount on the same line

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0035515

Retail Modules

Web POS

public

2017-03-14 17:33

2017-05-08 12:23

Reporter

guillermogil

Assigned To

jorge-garcia

Priority

urgent

Severity

major

Reproducibility

always

Status

scheduled

Resolution

open

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

OBPS

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0035515: It is not possible to add twice the same discount on the same line

Description

It is not possible to add twice the same discount on the same line for manual or manual by total.

This is preventing to add manual ones and it should not be needed or it should have more logic

      for (i = 0; i < promotions.length; i++) {
        if (promotions[i].ruleId === rule.id) {
          debugger;
          if (promotions[i].hidden !== true) {
            promotions[i] = disc;
            replaced = true;
            break;
          }
        }
      }

Regarding the Manual by Total it should be needed to review the discount engine and applyPromotions.

Steps To Reproduce

- Login on WebPOS
- Add a product
- Add a variable discount of 5€
- Add the same variable discount but now of 8€

There is only one of them

Proposed Solution

Allow to add them by default or by config

Additional Information