Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0035446
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] Z. Otherstrivialalways2017-03-07 13:312017-03-07 17:21
ReportervmromanosView Statuspublic 
Assigned Tovmromanos 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision7532ffc7df7e
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tovmromanos
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0035446: Clean up eclipse warnings in Finance modules

DescriptionClean up the eclipse warnings found in finance modules.
Right now this is the list of warnings:

eclipse-warnings:
     [echo] Compiling...
     [java] ----------
     [java] 1. WARNING in /srv/ci/workspace/mod-simple-ci23.140/modules/org.openbravo.module.finactvalidator.es/src/org/openbravo/module/finactvalidator/es/erpCommon/ad_callout/FNACTV_BPBankAccountValidation.java (at line 167)
     [java] i = i / 10;
     [java] ^
     [java] The parameter i should not be assigned
     [java] ----------
     [java] ----------
     [java] 2. WARNING in /srv/ci/workspace/mod-simple-ci23.140/modules/org.openbravo.module.finactvalidator.es/src/org/openbravo/module/finactvalidator/es/erpCommon/ad_callout/FNACTV_BankAccountValidation.java (at line 171)
     [java] i = i / 10;
     [java] ^
     [java] The parameter i should not be assigned
     [java] ----------
     [java] ----------
     [java] 3. WARNING in /srv/ci/workspace/mod-simple-ci23.140/modules/org.openbravo.module.idljava/src/org/openbravo/module/idljava/proc/IdlServiceJava.java (at line 32)
     [java] CSVReader reader = new CSVReader(new InputStreamReader(new FileInputStream(filename), "UTF-8"),
     [java] ^^^^^^
     [java] Resource leak: 'reader' is never closed
     [java] ----------
     [java] ----------
     [java] 4. WARNING in /srv/ci/workspace/mod-simple-ci23.140/modules/org.openbravo.report.improved.balancesheet/src/org/openbravo/report/improved/balancesheet/ad_reports/GeneralAccountingReports.java (at line 151)
     [java] strElementValue = strElementValue.substring(1, strElementValue.length());
     [java] ^^^^^^^^^^^^^^^
     [java] The parameter strElementValue should not be assigned
     [java] ----------
     [java] 5. WARNING in /srv/ci/workspace/mod-simple-ci23.140/modules/org.openbravo.report.improved.balancesheet/src/org/openbravo/report/improved/balancesheet/ad_reports/GeneralAccountingReports.java (at line 203)
     [java] strDateTo = strAsDateTo;
     [java] ^^^^^^^^^
     [java] The parameter strDateTo should not be assigned
     [java] ----------
     [java] 6. WARNING in /srv/ci/workspace/mod-simple-ci23.140/modules/org.openbravo.report.improved.balancesheet/src/org/openbravo/report/improved/balancesheet/ad_reports/GeneralAccountingReports.java (at line 204)
     [java] strDateToRef = strAsDateToRef;
     [java] ^^^^^^^^^^^^
     [java] The parameter strDateToRef should not be assigned
     [java] ----------
     [java] 7. WARNING in /srv/ci/workspace/mod-simple-ci23.140/modules/org.openbravo.report.improved.balancesheet/src/org/openbravo/report/improved/balancesheet/ad_reports/GeneralAccountingReports.java (at line 205)
     [java] strDateFrom = "";
     [java] ^^^^^^^^^^^
     [java] The parameter strDateFrom should not be assigned
     [java] ----------
     [java] 8. WARNING in /srv/ci/workspace/mod-simple-ci23.140/modules/org.openbravo.report.improved.balancesheet/src/org/openbravo/report/improved/balancesheet/ad_reports/GeneralAccountingReports.java (at line 206)
     [java] strDateFromRef = "";
     [java] ^^^^^^^^^^^^^^
     [java] The parameter strDateFromRef should not be assigned
     [java] ----------
     [java] 9. WARNING in /srv/ci/workspace/mod-simple-ci23.140/modules/org.openbravo.report.improved.balancesheet/src/org/openbravo/report/improved/balancesheet/ad_reports/GeneralAccountingReports.java (at line 295)
     [java] strDateFrom = OBDateUtils.formatDate(startingEndingDate.get("startingDate"));
     [java] ^^^^^^^^^^^
     [java] The parameter strDateFrom should not be assigned
     [java] ----------
     [java] 10. WARNING in /srv/ci/workspace/mod-simple-ci23.140/modules/org.openbravo.report.improved.balancesheet/src/org/openbravo/report/improved/balancesheet/ad_reports/GeneralAccountingReports.java (at line 297)
     [java] strDateTo = OBDateUtils.formatDate(startingEndingDate.get("endingDate"));
     [java] ^^^^^^^^^
     [java] The parameter strDateTo should not be assigned
     [java] ----------
     [java] 11. WARNING in /srv/ci/workspace/mod-simple-ci23.140/modules/org.openbravo.report.improved.balancesheet/src/org/openbravo/report/improved/balancesheet/ad_reports/GeneralAccountingReports.java (at line 301)
     [java] strDateFromRef = OBDateUtils.formatDate(startingEndingDateRef.get("startingDate"));
     [java] ^^^^^^^^^^^^^^
     [java] The parameter strDateFromRef should not be assigned
     [java] ----------
     [java] 12. WARNING in /srv/ci/workspace/mod-simple-ci23.140/modules/org.openbravo.report.improved.balancesheet/src/org/openbravo/report/improved/balancesheet/ad_reports/GeneralAccountingReports.java (at line 303)
     [java] strDateToRef = OBDateUtils.formatDate(startingEndingDateRef.get("endingDate"));
     [java] ^^^^^^^^^^^^
     [java] The parameter strDateToRef should not be assigned
     [java] ----------
     [java] ----------
     [java] 13. WARNING in /srv/ci/workspace/mod-simple-ci23.140/modules/org.openbravo.report.improved.balancesheet/src/org/openbravo/report/improved/balancesheet/ad_reports/AccountTree.java (at line 247)
     [java] rootElement = "0";
     [java] ^^^^^^^^^^^
     [java] The parameter rootElement should not be assigned
     [java] ----------
     [java] 14. WARNING in /srv/ci/workspace/mod-simple-ci23.140/modules/org.openbravo.report.improved.balancesheet/src/org/openbravo/report/improved/balancesheet/ad_reports/AccountTree.java (at line 316)
     [java] vecTotal = new Vector<Object>();
     [java] ^^^^^^^^
     [java] The parameter vecTotal should not be assigned
     [java] ----------
     [java] 15. WARNING in /srv/ci/workspace/mod-simple-ci23.140/modules/org.openbravo.report.improved.balancesheet/src/org/openbravo/report/improved/balancesheet/ad_reports/AccountTree.java (at line 458)
     [java] reportNode = new String[1];
     [java] ^^^^^^^^^^
     [java] The parameter reportNode should not be assigned
     [java] ----------
     [java] 16. WARNING in /srv/ci/workspace/mod-simple-ci23.140/modules/org.openbravo.report.improved.balancesheet/src/org/openbravo/report/improved/balancesheet/ad_reports/AccountTree.java (at line 466)
     [java] totalAmounts = new Vector<Object>();
     [java] ^^^^^^^^^^^^
     [java] The parameter totalAmounts should not be assigned
     [java] ----------
     [java] 17. WARNING in /srv/ci/workspace/mod-simple-ci23.140/modules/org.openbravo.report.improved.balancesheet/src/org/openbravo/report/improved/balancesheet/ad_reports/AccountTree.java (at line 596)
     [java] indice = new String[1];
     [java] ^^^^^^
     [java] The parameter indice should not be assigned
     [java] ----------
     [java] 17 problems (17 warnings)
Steps To ReproduceRun mod-functional-basic, mod-simple.
Go to artifacts section and verify eclipse_warning.log is not empty
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to feature request 0031477 newshuehner Tracking issue to reduce the huge number of eclipse warnings in pi 

-  Notes
(0094789)
hgbot (developer)
2017-03-07 13:46

 Repository: erp/mods/org.openbravo.report.improved.balancesheet
Changeset: 25e2a704d4d5d5295e45e32f09d7b704d2e02215
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue Mar 07 13:35:33 2017 +0100
URL: http://code.openbravo.com/erp/mods/org.openbravo.report.improved.balancesheet/rev/25e2a704d4d5d5295e45e32f09d7b704d2e02215 [^]

Related to issue 35446: Clean up eclipse warnings

---
M src/org/openbravo/report/improved/balancesheet/ad_reports/GeneralAccountingReports.java
---
(0094790)
hgbot (developer)
2017-03-07 13:52

 Repository: erp/mods/org.openbravo.module.finactvalidator.es
Changeset: f1b7435627dc3583ca9a040cd11fb3701c444de8
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue Mar 07 13:53:54 2017 +0100
URL: http://code.openbravo.com/erp/mods/org.openbravo.module.finactvalidator.es/rev/f1b7435627dc3583ca9a040cd11fb3701c444de8 [^]

Related to issue 35446: Clean up eclipse warnings

---
M src/org/openbravo/module/finactvalidator/es/erpCommon/ad_callout/FNACTV_BPBankAccountValidation.java
---
(0094791)
hgbot (developer)
2017-03-07 13:54

 Repository: erp/mods/org.openbravo.module.finactvalidator.es
Changeset: 3220ac21fcdf06b9625d0a99b5c287d1a9e89c9c
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue Mar 07 13:56:15 2017 +0100
URL: http://code.openbravo.com/erp/mods/org.openbravo.module.finactvalidator.es/rev/3220ac21fcdf06b9625d0a99b5c287d1a9e89c9c [^]

Related to issue 35446: Clean up eclipse warnings

---
M src/org/openbravo/module/finactvalidator/es/erpCommon/ad_callout/FNACTV_BankAccountValidation.java
---
(0094792)
hgbot (developer)
2017-03-07 13:57

 Repository: erp/pmods/org.openbravo.module.idljava
Changeset: 7532ffc7df7e82fb3075413788bfb64d683b8fdd
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue Mar 07 13:58:19 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.idljava/rev/7532ffc7df7e82fb3075413788bfb64d683b8fdd [^]

Fixed issue 35446: Clean up eclipse warnings

---
M src/org/openbravo/module/idljava/proc/IdlServiceJava.java
---
(0094796)
hgbot (developer)
2017-03-07 15:28

 Repository: erp/mods/org.openbravo.report.improved.balancesheet
Changeset: 14d34e0e8ee74e6dde70e0f223c235b0b49d9dfd
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue Mar 07 15:29:53 2017 +0100
URL: http://code.openbravo.com/erp/mods/org.openbravo.report.improved.balancesheet/rev/14d34e0e8ee74e6dde70e0f223c235b0b49d9dfd [^]

Related to issue 35446: Clean up eclipse warnings

---
M src/org/openbravo/report/improved/balancesheet/ad_reports/AccountTree.java
---
(0094798)
hgbot (developer)
2017-03-07 15:31

 Repository: erp/pmods/org.openbravo.module.idljava
Changeset: d9533c1eeda6e85dadfeec1474b6afc2d068f5aa
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue Mar 07 15:33:37 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.idljava/rev/d9533c1eeda6e85dadfeec1474b6afc2d068f5aa [^]

Related to issue 35446: Clean up eclipse warnings

---
M src/org/openbravo/module/idljava/proc/IdlServiceJava.java
---
(0094806)
vmromanos (manager)
2017-03-07 17:21

 Jenkins job passed succesfully:

http://ci.openbravo.com/view/modules/job/mod-simple/11061/artifact/eclipse_warning.log [^]

- Issue History
Date Modified Username Field Change
2017-03-07 13:31 vmromanos New Issue
2017-03-07 13:31 vmromanos Assigned To => Triage Finance
2017-03-07 13:31 vmromanos Modules => Core
2017-03-07 13:31 vmromanos Triggers an Emergency Pack => No
2017-03-07 13:31 vmromanos Relationship added related to 0031477
2017-03-07 13:32 vmromanos Status new => scheduled
2017-03-07 13:32 vmromanos Assigned To Triage Finance => vmromanos
2017-03-07 13:46 hgbot Checkin
2017-03-07 13:46 hgbot Note Added: 0094789
2017-03-07 13:52 hgbot Checkin
2017-03-07 13:52 hgbot Note Added: 0094790
2017-03-07 13:54 hgbot Checkin
2017-03-07 13:54 hgbot Note Added: 0094791
2017-03-07 13:57 hgbot Checkin
2017-03-07 13:57 hgbot Note Added: 0094792
2017-03-07 13:57 hgbot Status scheduled => resolved
2017-03-07 13:57 hgbot Resolution open => fixed
2017-03-07 13:57 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.module.idljava/rev/7532ffc7df7e82fb3075413788bfb64d683b8fdd [^]
2017-03-07 15:28 hgbot Checkin
2017-03-07 15:28 hgbot Note Added: 0094796
2017-03-07 15:31 hgbot Checkin
2017-03-07 15:31 hgbot Note Added: 0094798
2017-03-07 17:21 vmromanos Review Assigned To => vmromanos
2017-03-07 17:21 vmromanos Note Added: 0094806
2017-03-07 17:21 vmromanos Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker