Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0035301

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Web POS

major

always

2017-02-17 14:03

2017-02-27 09:27

Reporter

aaroncalero

View Status

public

Assigned To

mario_castello

Priority

high

Resolution

fixed

Fixed in Version

RR17Q2

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

OBPS

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0035301: Calculate Receipt remains locked if the server fails to process a ticket transaction

Description

When the WebPOS Synchronized Mode is enabled, if the transaction that processes a receipt fails, the webpos remains in an inconsistent state and the receipt totals can no longer be calculated, because the isCalculateReceiptLocked attribute of the receipt remains set to 'true'.

Steps To Reproduce

Configuration:
(1) Log in in backend, go to the preference window and enable the preference 'WebPOS Synchronized Mode' with value 'Y'
(2) Go to the Warehouse and storage bins window, create a new warehouse for the organization Vall Blanca Store, and add a DISABLED storage bin for that warehouse.
(3) Go to the Organization window, find the Vall Blanca Store record, and on the Warehouse tab add a new record with the warehouse created on step (2), with priority 0 (highest priority).

Web POS:
Login in web pos on the terminal VBS-1
Add 1 Multi-tool.
Click on the total amount button and pay the receipt.
The Processing Transaction popup will appear, and after a few seconds the Transaction Failed popup will be shown, specifying the error: The warehouse does not have any storage bins.
Click on Ok, and then try changing the qty of the receipt. The qty will be changed, but the total amount of the receipt won't be updated, and the browser console will show the following error:
calculateReceipt execution is forbidden right now

Proposed Solution

When the runSyncProcess error callback executed, the callback of the receipt's close event is executed[1], passing the isCancelled flag as 'true'.
On the code of that callback, the isCalculateReceiptLocked is only reset if the isCancelled flag was 'false'.
This flag, along with setIsCalculateGrossLockState, should be reset in any case, regardless of the output of runSyncProcess

[1] https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/b1993add07d7/web/org.openbravo.retail.posterminal/js/data/dataordersave.js#l236 [^]

Tags

No tags attached.

35301possibleFix.diff [^] (690 bytes) 2017-02-17 14:55 [Show Content] [Hide Content]

diff --git a/web/org.openbravo.retail.posterminal/js/data/dataordersave.js b/web/org.openbravo.retail.posterminal/js/data/dataordersave.js
--- a/web/org.openbravo.retail.posterminal/js/data/dataordersave.js
+++ b/web/org.openbravo.retail.posterminal/js/data/dataordersave.js
@@ -237,6 +237,8 @@
                           frozenReceipt: frozenReceipt,
                           isCancelled: true
                         });
+                        receipt.setIsCalculateReceiptLockState(false);
+                        receipt.setIsCalculateGrossLockState(false);
                         receipt.trigger('paymentCancel');
                       }
                     }, null, false);

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0094521) hgbot (developer) 2017-02-21 16:14	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: cef081b9da0b534bea6b896f44305491abcb1916 Author: Mario Castello <mario.castello <at> peoplewalking.com> Date: Fri Feb 17 10:16:52 2017 -0600 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/cef081b9da0b534bea6b896f44305491abcb1916 [^] Fixed issue 0035301: Calculate Receipt remains locked if the server fails to process a ticket transaction - Set the receipt properties to false when the transactions fails. --- M web/org.openbravo.retail.posterminal/js/data/dataordersave.js ---

Issue History
Date Modified	Username	Field	Change
2017-02-17 14:03	aaroncalero	New Issue
2017-02-17 14:03	aaroncalero	Assigned To	=> Retail
2017-02-17 14:03	aaroncalero	OBNetwork customer	=> Yes
2017-02-17 14:03	aaroncalero	Resolution time	=> 1488495600
2017-02-17 14:03	aaroncalero	Triggers an Emergency Pack	=> No
2017-02-17 14:09	aaroncalero	Proposed Solution updated
2017-02-17 14:55	jorge-garcia	File Added: 35301possibleFix.diff
2017-02-17 15:46	mario_castello	Assigned To	Retail => mario_castello
2017-02-17 15:46	mario_castello	Status	new => acknowledged
2017-02-17 15:46	mario_castello	Status	acknowledged => scheduled
2017-02-21 16:14	hgbot	Checkin
2017-02-21 16:14	hgbot	Note Added: 0094521
2017-02-21 16:14	hgbot	Status	scheduled => resolved
2017-02-21 16:14	hgbot	Resolution	open => fixed
2017-02-21 16:14	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/cef081b9da0b534bea6b896f44305491abcb1916 [^]
2017-02-27 09:27	marvintm	Review Assigned To	=> marvintm
2017-02-27 09:27	marvintm	Status	resolved => closed
2017-02-27 09:27	marvintm	Fixed in Version	=> RR17Q2

Copyright © 2000 - 2009 MantisBT Group