Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0035260 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | minor | have not tried | 2017-02-14 13:57 | 2017-03-15 20:19 | |||
| Reporter | alostale | View Status | public | |||||
| Assigned To | alostale | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0PR17Q2 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | ba3c7b06f4cb | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | caristu | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0035260: unneeded flushes in window settings action handler | |||||||
| Description | WindowSettingsActionHandler is invoked whenever a window is opened in order to determine per role specific window settings. It is performing unneeded flush which cause performance degradation. | |||||||
| Steps To Reproduce | 1. Execute in JMeter attached jmx. It calls windows settings for Sales Order, Sales Invoice, BP and Product window 100 times each. 2. Check Aggregate report for the sum of the 4 requests: avg: 222 ms 90% percentile: 251 ms When profiling it can be seen 34% of total time is spent in flushing | |||||||
| Proposed Solution | Remove flushes. After applying fix the time is ~2x faster: avg: 100 ms 90% percentile: 113 ms | |||||||
| Tags | Performance | |||||||
| Attached Files |  window-settings.jmx [^] (68,241 bytes) 2017-02-14 13:58 Selection_156.png [^] (27,617 bytes) 2017-02-14 14:05
| |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0094318) hgbot (developer) 2017-02-14 14:21 |
Repository: erp/devel/pi Changeset: ba3c7b06f4cbcbddec3ee341219dca0be8644cf1 Author: Asier Lostalé <asier.lostale <at> openbravo.com> Date: Tue Feb 14 14:20:26 2017 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/ba3c7b06f4cbcbddec3ee341219dca0be8644cf1 [^] fixed bug 35260: unneeded flushes in window settings action handler * No need to flush before querying with sqlc. * This is a readonly process, so we can safelly clear session at the end so that flush done when finalizing the thread don't require to check any object for dirtiness --- M modules/org.openbravo.client.application/src/org/openbravo/client/application/WindowSettingsActionHandler.java --- |
|
(0094450) caristu (developer) 2017-02-20 08:49 |
Code reviewed |
|
(0095183) hudsonbot (developer) 2017-03-15 20:19 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2017-02-14 13:57 | alostale | New Issue | |
| 2017-02-14 13:57 | alostale | Assigned To | => alostale |
| 2017-02-14 13:57 | alostale | Modules | => Core |
| 2017-02-14 13:57 | alostale | Triggers an Emergency Pack | => No |
| 2017-02-14 13:58 | alostale | Tag Attached: Performance | |
| 2017-02-14 13:58 | alostale | Review Assigned To | => caristu |
| 2017-02-14 13:58 | alostale | File Added: window-settings.jmx | |
| 2017-02-14 14:05 | alostale | File Added: Selection_156.png | |
| 2017-02-14 14:06 | alostale | Steps to Reproduce Updated | View Revisions |
| 2017-02-14 14:07 | alostale | Steps to Reproduce Updated | View Revisions |
| 2017-02-14 14:13 | alostale | Proposed Solution updated | |
| 2017-02-14 14:21 | hgbot | Checkin | |
| 2017-02-14 14:21 | hgbot | Note Added: 0094318 | |
| 2017-02-14 14:21 | hgbot | Status | new => resolved |
| 2017-02-14 14:21 | hgbot | Resolution | open => fixed |
| 2017-02-14 14:21 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/ba3c7b06f4cbcbddec3ee341219dca0be8644cf1 [^] |
| 2017-02-20 08:49 | caristu | Note Added: 0094450 | |
| 2017-02-20 08:49 | caristu | Status | resolved => closed |
| 2017-02-20 08:49 | caristu | Fixed in Version | => 3.0PR17Q2 |
| 2017-03-15 20:19 | hudsonbot | Checkin | |
| 2017-03-15 20:19 | hudsonbot | Note Added: 0095183 | |
| 2017-06-02 14:29 | alostale | Relationship added | related to 0036172 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |