Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035260Openbravo ERPA. Platformpublic2017-02-14 13:572017-03-15 20:19
Reporteralostale 
Assigned Toalostale 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q2 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035260: unneeded flushes in window settings action handler
DescriptionWindowSettingsActionHandler is invoked whenever a window is opened in order to determine per role specific window settings.

It is performing unneeded flush which cause performance degradation.
Steps To Reproduce1. Execute in JMeter attached jmx. It calls windows settings for Sales Order, Sales Invoice, BP and Product window 100 times each.
2. Check Aggregate report for the sum of the 4 requests:
  avg: 222 ms
  90% percentile: 251 ms
  When profiling it can be seen 34% of total time is spent in flushing
Proposed SolutionRemove flushes. After applying fix the time is ~2x faster:

avg: 100 ms
90% percentile: 113 ms
Additional Information
TagsPerformance
Relationships
related to defect 0036172 closed alostale WindowSettingsActionHandler underperformance 
Attached Files? window-settings.jmx (68,241) 2017-02-14 13:58
https://issues.openbravo.com/file_download.php?file_id=10444&type=bug
png Selection_156.png (27,617) 2017-02-14 14:05
https://issues.openbravo.com/file_download.php?file_id=10445&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2017-02-14 13:57alostaleNew Issue
2017-02-14 13:57alostaleAssigned To => alostale
2017-02-14 13:57alostaleOBNetwork customer => No
2017-02-14 13:57alostaleModules => Core
2017-02-14 13:57alostaleTriggers an Emergency Pack => No
2017-02-14 13:58alostaleTag Attached: Performance
2017-02-14 13:58alostaleReview Assigned To => caristu
2017-02-14 13:58alostaleFile Added: window-settings.jmx
2017-02-14 14:05alostaleFile Added: Selection_156.png
2017-02-14 14:06alostaleSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=14584#r14584
2017-02-14 14:07alostaleSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=14585#r14585
2017-02-14 14:13alostaleProposed Solution updated
2017-02-14 14:21hgbotCheckin
2017-02-14 14:21hgbotNote Added: 0094318
2017-02-14 14:21hgbotStatusnew => resolved
2017-02-14 14:21hgbotResolutionopen => fixed
2017-02-14 14:21hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ba3c7b06f4cbcbddec3ee341219dca0be8644cf1 [^]
2017-02-20 08:49caristuNote Added: 0094450
2017-02-20 08:49caristuStatusresolved => closed
2017-02-20 08:49caristuFixed in Version => 3.0PR17Q2
2017-03-15 20:19hudsonbotCheckin
2017-03-15 20:19hudsonbotNote Added: 0095183
2017-06-02 14:29alostaleRelationship addedrelated to 0036172

Notes
(0094318)
hgbot   
2017-02-14 14:21   
Repository: erp/devel/pi
Changeset: ba3c7b06f4cbcbddec3ee341219dca0be8644cf1
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Feb 14 14:20:26 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/ba3c7b06f4cbcbddec3ee341219dca0be8644cf1 [^]

fixed bug 35260: unneeded flushes in window settings action handler

  * No need to flush before querying with sqlc.
  * This is a readonly process, so we can safelly clear session at the end so
    that flush done when finalizing the thread don't require to check any object
    for dirtiness

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/WindowSettingsActionHandler.java
---
(0094450)
caristu   
2017-02-20 08:49   
Code reviewed
(0095183)
hudsonbot   
2017-03-15 20:19   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test