Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0035232 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
feature request | [Retail Modules] StoreServer | minor | have not tried | 2017-02-12 22:54 | 2017-02-20 09:02 | |||
Reporter | mtaal | View Status | public | |||||
Assigned To | mtaal | |||||||
Priority | normal | Resolution | fixed | Fixed in Version | ||||
Status | closed | Fix in branch | Fixed in SCM revision | 553709fd2483 | ||||
Projection | none | ETA | none | Target Version | RR17Q2 | |||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Review Assigned To | AugustoMauch | |||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0035232: Prevent NPE in store data validator when row does not exist | |||||||
Description | If the database is not correct and a referenced row does not exist then the store validation ends up in a NPE [1]. This should be prevented and a clearer message should be shown. [1] [SynchronizationStoreDataValidationTask] 117/117 tables validated, 1 errors so far [SynchronizationStoreDataValidationTask] 1 errors found: BUILD FAILED /home/mtaal/mydata/dev/openbravo/projects/ioritz/openbravo/modules/org.openbravo.replication.symmetricds/build.xml:62: java.lang.NullPointerException at org.openbravo.replication.symmetricds.validation.DataValidationError.logMissingId(DataValidationError.java:91) at org.openbravo.replication.symmetricds.validation.DataValidationError.expandErrorAndLog(DataValidationError.java:84) at org.openbravo.replication.symmetricds.validation.SynchronizationStoreDataValidator.logErrors(SynchronizationStoreDataValidator.java:227) at org.openbravo.replication.symmetricds.validation.SynchronizationStoreDataValidator.validateData(SynchronizationStoreDataValidator.java:136) at org.openbravo.replication.symmetricds.task.StoreDataValidatorTask.doExecute(StoreDataValidatorTask.java:35) at org.openbravo.dal.core.DalInitializingTask.execute(DalInitializingTask.java:120) at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:291) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) | |||||||
Steps To Reproduce | Difficult to reproduce as the data should not exist. | |||||||
Proposed Solution | Show message | |||||||
Tags | No tags attached. | |||||||
Attached Files | ||||||||
Relationships [ Relation Graph ] [ Dependency Graph ] | |
Notes | |
(0094229) hgbot (developer) 2017-02-12 23:51 |
Repository: erp/pmods/org.openbravo.replication.symmetricds Changeset: 553709fd248317120a057e466995b1ec21c57474 Author: Martin Taal <martin.taal <at> openbravo.com> Date: Sun Feb 12 23:51:12 2017 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/rev/553709fd248317120a057e466995b1ec21c57474 [^] Fixes issue 35232: Prevent NPE in store data validator when row does not exist Log message instead of NPE --- M src/org/openbravo/replication/symmetricds/validation/DataValidationError.java --- |
(0094451) AugustoMauch (manager) 2017-02-20 09:02 |
Code reviewed and verified |
Issue History | |||
Date Modified | Username | Field | Change |
2017-02-12 22:54 | mtaal | New Issue | |
2017-02-12 22:54 | mtaal | Assigned To | => mtaal |
2017-02-12 22:54 | mtaal | Triggers an Emergency Pack | => No |
2017-02-12 22:55 | mtaal | Review Assigned To | => AugustoMauch |
2017-02-12 23:51 | hgbot | Checkin | |
2017-02-12 23:51 | hgbot | Note Added: 0094229 | |
2017-02-12 23:51 | hgbot | Status | new => resolved |
2017-02-12 23:51 | hgbot | Resolution | open => fixed |
2017-02-12 23:51 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/rev/553709fd248317120a057e466995b1ec21c57474 [^] |
2017-02-20 09:02 | AugustoMauch | Note Added: 0094451 | |
2017-02-20 09:02 | AugustoMauch | Status | resolved => closed |
Copyright © 2000 - 2009 MantisBT Group |