Openbravo Issue Tracking System - Retail Modules
View Issue Details
0035232Retail ModulesStoreServerpublic2017-02-12 22:542017-02-20 09:02
mtaal 
mtaal 
normalminorhave not tried
closedfixed 
5
 
RR17Q2 
AugustoMauch
No
0035232: Prevent NPE in store data validator when row does not exist
If the database is not correct and a referenced row does not exist then the store validation ends up in a NPE [1]. This should be prevented and a clearer message should be shown.

[1]
[SynchronizationStoreDataValidationTask] 117/117 tables validated, 1 errors so far
[SynchronizationStoreDataValidationTask] 1 errors found:

BUILD FAILED
/home/mtaal/mydata/dev/openbravo/projects/ioritz/openbravo/modules/org.openbravo.replication.symmetricds/build.xml:62: java.lang.NullPointerException
    at org.openbravo.replication.symmetricds.validation.DataValidationError.logMissingId(DataValidationError.java:91)
    at org.openbravo.replication.symmetricds.validation.DataValidationError.expandErrorAndLog(DataValidationError.java:84)
    at org.openbravo.replication.symmetricds.validation.SynchronizationStoreDataValidator.logErrors(SynchronizationStoreDataValidator.java:227)
    at org.openbravo.replication.symmetricds.validation.SynchronizationStoreDataValidator.validateData(SynchronizationStoreDataValidator.java:136)
    at org.openbravo.replication.symmetricds.task.StoreDataValidatorTask.doExecute(StoreDataValidatorTask.java:35)
    at org.openbravo.dal.core.DalInitializingTask.execute(DalInitializingTask.java:120)
    at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:291)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
Difficult to reproduce as the data should not exist.
Show message
No tags attached.
Issue History
2017-02-12 22:54mtaalNew Issue
2017-02-12 22:54mtaalAssigned To => mtaal
2017-02-12 22:54mtaalTriggers an Emergency Pack => No
2017-02-12 22:55mtaalReview Assigned To => AugustoMauch
2017-02-12 23:51hgbotCheckin
2017-02-12 23:51hgbotNote Added: 0094229
2017-02-12 23:51hgbotStatusnew => resolved
2017-02-12 23:51hgbotResolutionopen => fixed
2017-02-12 23:51hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/rev/553709fd248317120a057e466995b1ec21c57474 [^]
2017-02-20 09:02AugustoMauchNote Added: 0094451
2017-02-20 09:02AugustoMauchStatusresolved => closed

Notes
(0094229)
hgbot   
2017-02-12 23:51   
Repository: erp/pmods/org.openbravo.replication.symmetricds
Changeset: 553709fd248317120a057e466995b1ec21c57474
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sun Feb 12 23:51:12 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/rev/553709fd248317120a057e466995b1ec21c57474 [^]

Fixes issue 35232: Prevent NPE in store data validator when row does not exist
Log message instead of NPE

---
M src/org/openbravo/replication/symmetricds/validation/DataValidationError.java
---
(0094451)
AugustoMauch   
2017-02-20 09:02   
Code reviewed and verified