Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0035189
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2017-02-07 16:472017-03-08 14:05
ReporterjonibcView Statuspublic 
Assigned Tomigueldejuana 
PriorityhighResolutionfixedFixed in VersionRR17Q2
StatusclosedFix in branchFixed in SCM revision72e01ef0efbc
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0035189: [SERQA 2420] Business Partner name validation, error message hardcoded

DescriptionIn customer creation window, if we set a first name with 60 characters, and last name with one character, it is not possible to create a customer, because length for field name is 60 characters.

Using synchronized mode, error messages are shown to the user in a Popup. The error message shown is harcoded, so consequently is not translated.
Steps To ReproduceIn backend:
1- Create the preference Synchronized Mode = Y

In WebPOS:
1- Login to WebPOS.
2- Click on customer button, click on new customer.
3- Insert a FirstName with 60 characters (limit of the field), insert one character in LastName field, complete the rest of mandatory fields.
Proposed Solution- Limit the characters of the fields like: FirstName(30), LastName(29). Or modify the Name field length.
- Create an ad_message to avoid hardcoded message and support translations.
TagsNo tags attached.
Attached Files? file icon issue35189PiMobile_1.commit [^] (5,467 bytes) 2017-02-24 10:28
? file icon issue35189PiMobile_2.commit [^] (3,360 bytes) 2017-02-24 10:28
? file icon issue35189Posterminal.commit [^] (2,828 bytes) 2017-02-24 10:30

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0094355)
hgbot (developer)
2017-02-15 11:48

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 61e04c7290c964cc5972bbf71c5b36db4cc82b7d
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Feb 09 12:18:39 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/61e04c7290c964cc5972bbf71c5b36db4cc82b7d [^]

Fixed issue 0035189: [SERQA 2420] Business Partner name validation, error message hardcoded

- Substring the generated text to fit with the length of the column (60)

---
M web/org.openbravo.retail.posterminal/js/model/businesspartner.js
---
(0094358)
hgbot (developer)
2017-02-15 11:56

 Repository: tools/automation/pi-mobile
Changeset: 53c88c37cb27fac27f51d4fe4e88d919f56e7ca9
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Fri Feb 10 09:36:23 2017 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/53c88c37cb27fac27f51d4fe4e88d919f56e7ca9 [^]

Related to issue 0035189: [SERQA 2420] Business Partner name validation, error message hardcoded

- Add a test to ensure that the substring is done

---
M src-test/org/openbravo/test/mobile/core/utils/AllowedErrorsHelper.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/customercreation/CustomerCreationHelper.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/customercreation/NewCustomerLongName.java
---
(0094459)
marvintm (viewer)
2017-02-20 11:47

 Instead of truncating, we should validate that the length is correct, and then inform the user with a clear message in case the length is too long.
(0094824)
hgbot (developer)
2017-03-08 12:36

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 72e01ef0efbc7813b94e48efad99af7a1170c39d
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Mon Feb 20 17:15:17 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/72e01ef0efbc7813b94e48efad99af7a1170c39d [^]

Fixed issue 0035189: [SERQA 2420] Business Partner name validation, error message hardcoded

- Add a validation in the client side instead of cutting customer info

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customers/components/sharedcomponents.js
---
(0094828)
hgbot (developer)
2017-03-08 12:38

 Repository: tools/automation/pi-mobile
Changeset: 46b4481c7dfd9b8ff714b5f5c709517c37bbe946
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Wed Feb 22 08:30:06 2017 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/46b4481c7dfd9b8ff714b5f5c709517c37bbe946 [^]

elated to issue 0035189: [SERQA 2420] Business Partner name validation, error message hardcoded

- Backout new test. We will do a clientside validation

---
M src-test/org/openbravo/test/mobile/core/utils/AllowedErrorsHelper.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/customercreation/CustomerCreationHelper.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/customercreation/NewCustomerLongName.java
---
(0094829)
hgbot (developer)
2017-03-08 12:39

 Repository: tools/automation/pi-mobile
Changeset: 4962b37614c0a4fd1b394a15fdbeea06aa2c61c6
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Wed Feb 22 09:40:58 2017 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/4962b37614c0a4fd1b394a15fdbeea06aa2c61c6 [^]

Related to issue 0035189: [SERQA 2420] Business Partner name validation, error message hardcoded

- Wait until selectors of new customer are filled

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/TestIdPack.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I34168_verifyCustomerNameLength.java
---

- Issue History
Date Modified Username Field Change
2017-02-07 16:47 jonibc New Issue
2017-02-07 16:47 jonibc Assigned To => Retail
2017-02-07 16:47 jonibc OBNetwork customer => Yes
2017-02-07 16:47 jonibc Resolution time => 1487631600
2017-02-07 16:47 jonibc Triggers an Emergency Pack => No
2017-02-09 09:21 migueldejuana Assigned To Retail => migueldejuana
2017-02-09 09:22 migueldejuana Status new => scheduled
2017-02-15 11:48 hgbot Checkin
2017-02-15 11:48 hgbot Note Added: 0094355
2017-02-15 11:48 hgbot Status scheduled => resolved
2017-02-15 11:48 hgbot Resolution open => fixed
2017-02-15 11:48 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/61e04c7290c964cc5972bbf71c5b36db4cc82b7d [^]
2017-02-15 11:56 hgbot Checkin
2017-02-15 11:56 hgbot Note Added: 0094358
2017-02-20 11:47 marvintm Note Added: 0094459
2017-02-20 11:47 marvintm Status resolved => new
2017-02-20 11:47 marvintm Resolution fixed => open
2017-02-24 10:26 migueldejuana Status new => scheduled
2017-02-24 10:28 migueldejuana File Added: issue35189PiMobile_1.commit
2017-02-24 10:28 migueldejuana File Added: issue35189PiMobile_2.commit
2017-02-24 10:30 migueldejuana File Added: issue35189Posterminal.commit
2017-03-08 12:36 hgbot Checkin
2017-03-08 12:36 hgbot Note Added: 0094824
2017-03-08 12:36 hgbot Status scheduled => resolved
2017-03-08 12:36 hgbot Resolution open => fixed
2017-03-08 12:36 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/61e04c7290c964cc5972bbf71c5b36db4cc82b7d [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/72e01ef0efbc7813b94e48efad99af7a1170c39d [^]
2017-03-08 12:38 hgbot Checkin
2017-03-08 12:38 hgbot Note Added: 0094828
2017-03-08 12:39 hgbot Checkin
2017-03-08 12:39 hgbot Note Added: 0094829
2017-03-08 14:05 marvintm Review Assigned To => marvintm
2017-03-08 14:05 marvintm Status resolved => closed
2017-03-08 14:05 marvintm Fixed in Version => RR17Q2

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker