0035178: Callout's pool should be initialized before executing them

Description

Callout's pool should be initialized before executing them, in other case if the inherited myPool variable is used inside the execute method a NullPointerException will be thrown.

Steps To Reproduce

1) Apply the attached "calloutMyPool.diff" which adds a line which makes use of the myPool variable to show a message from the SE_InOut_Warehouse callout.

2) Compile and restart tomcat

3) Open the [Goods Shipment] window and notice that the NullPointerException is thrown in the log.

Proposed Solution

Initialize myPool in the init method of DelegateConnectionProvider.

Tags

No tags attached.

Attached Files

calloutMyPool.diff [^] (807 bytes) 2017-02-07 09:50 [Show Content] [Hide Content]

diff --git a/src/org/openbravo/erpCommon/ad_callouts/SE_InOut_Warehouse.java b/src/org/openbravo/erpCommon/ad_callouts/SE_InOut_Warehouse.java
--- a/src/org/openbravo/erpCommon/ad_callouts/SE_InOut_Warehouse.java
+++ b/src/org/openbravo/erpCommon/ad_callouts/SE_InOut_Warehouse.java
@@ -23,6 +23,7 @@
 import org.openbravo.base.filter.IsIDFilter;
 import org.openbravo.dal.core.OBContext;
 import org.openbravo.dal.service.OBDal;
+import org.openbravo.erpCommon.utility.Utility;
 import org.openbravo.model.common.enterprise.Warehouse;
 
 public class SE_InOut_Warehouse extends SimpleCallout {
@@ -45,5 +46,7 @@
         OBContext.restorePreviousMode();
       }
     }
+    String message = Utility.messageBD(myPool, "ProcessOK", info.vars.getLanguage());
+    info.addResult("WARNING", message);
   }
 }

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0035176

closed

caristu

Callout's pool should be initialized before executing them

Notes
(0094112) hgbot (developer) 2017-02-07 09:57	Repository: erp/backports/3.0PR16Q4.3 Changeset: 1b9ee78082ee692d0d71f39e0b641eb9ce4ecdf7 Author: Carlos Aristu <carlos.aristu <at> openbravo.com> Date: Tue Feb 07 09:57:04 2017 +0100 URL: http://code.openbravo.com/erp/backports/3.0PR16Q4.3/rev/1b9ee78082ee692d0d71f39e0b641eb9ce4ecdf7 [^] fixes issue 35178: Initialize callout's connection pool on init --- M src/org/openbravo/erpCommon/ad_callouts/DelegateConnectionProvider.java ---

(0094197) alostale (manager) 2017-02-10 07:35	code reviewed + tested

Issue History
Date Modified	Username	Field	Change
2017-02-07 09:00	caristu	Type	defect => backport
2017-02-07 09:00	caristu	Target Version	=> 3.0PR16Q4.3
2017-02-07 09:50	caristu	File Added: calloutMyPool.diff
2017-02-07 09:57	hgbot	Checkin
2017-02-07 09:57	hgbot	Note Added: 0094112
2017-02-07 09:57	hgbot	Status	scheduled => resolved
2017-02-07 09:57	hgbot	Resolution	open => fixed
2017-02-07 09:57	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/backports/3.0PR16Q4.3/rev/1b9ee78082ee692d0d71f39e0b641eb9ce4ecdf7 [^]
2017-02-07 10:04	caristu	Review Assigned To	=> alostale
2017-02-07 10:08	caristu	Steps to Reproduce Updated	View Revisions
2017-02-10 07:35	alostale	Note Added: 0094197
2017-02-10 07:35	alostale	Status	resolved => closed
2017-02-10 07:35	alostale	Fixed in Version	=> 3.0PR16Q4.3