Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0035166
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Openbravo ERP] A. Platformminorhave not tried2017-02-06 11:412017-03-15 20:19
ReportershuehnerView Statuspublic 
Assigned Toalostale 
PrioritynormalResolutionfixedFixed in Version3.0PR17Q2
StatusclosedFix in branchFixed in SCM revision87f935ef1dde
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0035166: Allow junit testclasses and test-method to be selectively skipped (when running tests against i.e. addon modules)

DescriptionMany junit tests in pi directly or indirectly depend on either unmodified AD data from pi or data in i.e. F&B sample data.

This makes those test fail when running i.e. ant run.all.tests against a set of addon modules (i.e. in a customer project).

It would be useful to be able to blacklist those selectively on granularity:
a.) Whole testclass
b.) Test method

For example the datasourceWithNoManualWhereParameter test here shows both problem in combination.
It's last assert in the 'has implicit filter' codepath needs both
- F&B sampledata ad_user row present
- Not have hqlfilterclause (definition of implicit filter) removed.

As it tests that a specific row is not visible with the implicit filter applied, but visible with it applied.
Steps To Reproducehttps://ci.openbravo.com/job/mod-simple/10094/testReport/junit/org.openbravo.test.datasource/DataSourceWhereParameter/datasourceWithNoManualWhereParameter_User_datasource_/ [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0035117 closedalostale unstable DataSourceWhereParameter tests 
related to feature request 0048499 closedablasco allow to disable junit tests by package 

-  Notes
(0094075)
hgbot (developer)
2017-02-06 12:36

 Repository: erp/devel/pi
Changeset: 87f935ef1ddeb00025c69b0796c32efd891b1027
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Mon Feb 06 12:35:12 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/87f935ef1ddeb00025c69b0796c32efd891b1027 [^]

fixed issue 35166: test cases can be disabled by configuration

  Now it's possible to define a list of test cases to be skipped. This is done
  by creating a file named disabled-test in config directory, this file can contain
  a list of either fully qualified class names to be completelly skipped and/or
  fully qualified class names followed by "." method name to skip individual test
  cases.

---
M src-test/src/org/openbravo/test/base/OBBaseTest.java
---
(0094076)
alostale (viewer)
2017-02-06 12:38

 Doc: http://wiki.openbravo.com/wiki/How_to_create_JUnit_testcases#Skipping_test_cases [^]
(0094082)
hgbot (developer)
2017-02-06 13:27

 Repository: erp/devel/pi
Changeset: 3e45f4c8e290bbf52b764e558ea0461e34cd237b
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Mon Feb 06 13:25:36 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/3e45f4c8e290bbf52b764e558ea0461e34cd237b [^]

related to issue 35166: don't use JDK8 api

---
M src-test/src/org/openbravo/test/base/OBBaseTest.java
---
(0094215)
caristu (viewer)
2017-02-10 11:03
edited on: 2017-02-10 11:04

 Code reviewed + tested OK:

- It is possible to skip all the tests of a class which extends OBBaseTest
- It is possible to skip a particular test of a class which extends OBBaseTest
(0095160)
hudsonbot (viewer)
2017-03-15 20:19

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test
(0095162)
hudsonbot (viewer)
2017-03-15 20:19

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2017-02-06 11:41 shuehner New Issue
2017-02-06 11:41 shuehner Assigned To => platform
2017-02-06 11:41 shuehner OBNetwork customer => No
2017-02-06 11:41 shuehner Modules => Core
2017-02-06 11:41 shuehner Triggers an Emergency Pack => No
2017-02-06 11:41 shuehner Relationship added related to 0035117
2017-02-06 12:35 alostale Assigned To platform => alostale
2017-02-06 12:36 alostale Review Assigned To => caristu
2017-02-06 12:36 hgbot Checkin
2017-02-06 12:36 hgbot Note Added: 0094075
2017-02-06 12:36 hgbot Status new => resolved
2017-02-06 12:36 hgbot Resolution open => fixed
2017-02-06 12:36 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/87f935ef1ddeb00025c69b0796c32efd891b1027 [^]
2017-02-06 12:38 alostale Note Added: 0094076
2017-02-06 13:27 hgbot Checkin
2017-02-06 13:27 hgbot Note Added: 0094082
2017-02-10 11:03 caristu Note Added: 0094215
2017-02-10 11:03 caristu Status resolved => closed
2017-02-10 11:03 caristu Fixed in Version => 3.0PR17Q2
2017-02-10 11:04 caristu Note Edited: 0094215 View Revisions
2017-03-15 20:19 hudsonbot Checkin
2017-03-15 20:19 hudsonbot Note Added: 0095160
2017-03-15 20:19 hudsonbot Checkin
2017-03-15 20:19 hudsonbot Note Added: 0095162
2022-01-28 07:27 alostale Relationship added related to 0048499

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker