Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0035057
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajorhave not tried2017-01-26 11:582017-03-15 20:18
ReporteralostaleView Statuspublic 
Assigned Tocaristu 
PriorityimmediateResolutionfixedFixed in Version3.0PR17Q2
StatusclosedFix in branchFixed in SCM revision8d8ea0ed22b6
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toalostale
Web browser
ModulesCore
Regression levelPre packaging ( pi )
Regression date2017-01-23
Regression introduced in releasepi
Regression introduced by commithttp://code.openbravo.com/erp/devel/pi/rev/84e7958bae798b41046be8e1ed65ab7af1705587 [^]
Triggers an Emergency PackNo
Summary

0035057: potential NPE on trx rollback

DescriptionSessionHandler rollbacks transaction and closes connection if not closed, it's also trying to close it in case it's null which will throw NPE.
Steps To Reproducecheck https://code.openbravo.com/erp/devel/pi/file/09fe534692aa/src/org/openbravo/dal/core/SessionHandler.java#l684 [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
caused by feature request 0034816 closedcaristu Support a second database for reporting 

-  Notes
(0093837)
hgbot (developer)
2017-01-26 12:04

 Repository: erp/devel/pi
Changeset: 8d8ea0ed22b64673d8a56c7ac03a301159c6e311
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Jan 26 12:03:58 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/8d8ea0ed22b64673d8a56c7ac03a301159c6e311 [^]

fixed bug 35057: potential NPE on trx rollback

---
M src/org/openbravo/dal/core/SessionHandler.java
---
(0093838)
hgbot (developer)
2017-01-26 12:13

 Repository: erp/devel/pi
Changeset: e7a491adc463ac711e6978c8d1b6fada08731d72
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Jan 26 12:13:07 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/e7a491adc463ac711e6978c8d1b6fada08731d72 [^]

related to bug 35057: check also if trx is null

---
M src/org/openbravo/dal/core/SessionHandler.java
---
(0093880)
hgbot (developer)
2017-01-27 12:27

 Repository: erp/devel/pi
Changeset: 7bd93800da74ece8a75ab41c025256ed1b5ba4a5
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Fri Jan 27 12:20:33 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/7bd93800da74ece8a75ab41c025256ed1b5ba4a5 [^]

related to bug 35057: keep check invariant in rollback

After the changes introduced on issue 0034816, SessionHandler.getInstance() does not begin a session when the handler was not already initilized. This causes that the checkInvariant throws an exception when calling rollback() after commitAndClose(), because the session is null when calling rollback().

The problem here was that OBBaseTest was doing that,i.e., invoking rollback inside a catch block when commitAndClose() fails. This is not needed, because when commitAndClose() fails the rollback of the transaction is done in that very same method.

For this reason, we are keeping the checkInvariant invocation in the rollback method, and we are deleting the usage of rollback() in the catch block in OBBaseTest.

---
M src-test/src/org/openbravo/test/base/OBBaseTest.java
M src/org/openbravo/dal/core/SessionHandler.java
---
(0094026)
alostale (manager)
2017-02-03 08:42

 code reviewed
(0095120)
hudsonbot (developer)
2017-03-15 20:18

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test
(0095121)
hudsonbot (developer)
2017-03-15 20:18

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test
(0095124)
hudsonbot (developer)
2017-03-15 20:18

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2017-01-26 11:58 alostale New Issue
2017-01-26 11:58 alostale Assigned To => platform
2017-01-26 11:58 alostale Modules => Core
2017-01-26 11:58 alostale Triggers an Emergency Pack => No
2017-01-26 12:00 alostale Relationship added caused by 0034816
2017-01-26 12:00 alostale Review Assigned To => caristu
2017-01-26 12:00 alostale Regression level => Pre packaging ( pi )
2017-01-26 12:00 alostale Regression date => 2017-01-23
2017-01-26 12:00 alostale Regression introduced in release => pi
2017-01-26 12:02 alostale Regression introduced by commit => http://code.openbravo.com/erp/devel/pi/rev/84e7958bae798b41046be8e1ed65ab7af1705587 [^]
2017-01-26 12:02 alostale Assigned To platform => alostale
2017-01-26 12:04 hgbot Checkin
2017-01-26 12:04 hgbot Note Added: 0093837
2017-01-26 12:04 hgbot Status new => resolved
2017-01-26 12:04 hgbot Resolution open => fixed
2017-01-26 12:04 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/8d8ea0ed22b64673d8a56c7ac03a301159c6e311 [^]
2017-01-26 12:13 hgbot Checkin
2017-01-26 12:13 hgbot Note Added: 0093838
2017-01-27 12:26 caristu Assigned To alostale => caristu
2017-01-27 12:27 hgbot Checkin
2017-01-27 12:27 hgbot Note Added: 0093880
2017-01-27 12:28 caristu Review Assigned To caristu => alostale
2017-02-03 08:42 alostale Note Added: 0094026
2017-02-03 08:42 alostale Status resolved => closed
2017-02-03 08:42 alostale Fixed in Version => 3.0PR17Q2
2017-03-15 20:18 hudsonbot Checkin
2017-03-15 20:18 hudsonbot Note Added: 0095120
2017-03-15 20:18 hudsonbot Checkin
2017-03-15 20:18 hudsonbot Note Added: 0095121
2017-03-15 20:18 hudsonbot Checkin
2017-03-15 20:18 hudsonbot Note Added: 0095124

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker