Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0034886 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Web POS | major | always | 2017-01-10 12:05 | 2017-01-13 12:36 | |||
| Reporter | Asantos9 | View Status | public | |||||
| Assigned To | ranjith_qualiantech_com | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | RR17Q2 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 0341cbbaf0aa | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | marvintm | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0034886: [SERQA 2284] setParameterValues is not checking properly when it has to be set a parameter | |||||||
| Description | SetParameterValues in ProcessHQLQuery is not checking correctly when the parameter has to be set. if (!ArrayUtils.contains(query.getNamedParameters(), paramName)) { continue; } This statement fails when the parameter name is not put in the hql query correctly because the query could have a substring with the same paramName value. | |||||||
| Steps To Reproduce | - Install order preparation module - Log into Web POS - Click on menu - Select order preparation - Filter by customer - Select a customer - Click on search button Note that an exception is thrown with the next information: org.openbravo.base.exception.OBException: Error when converting value 4D55D6DC1B35895E3DB24C57E1D6F8A0 | |||||||
| Proposed Solution | Now, it is checking if the query as string contains the parameter, but it has to check if the name parameters array of the query has the parameter. if (!ArrayUtils.contains(query.getNamedParameters(), paramName)) { continue; } | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0093475) hgbot (developer) 2017-01-13 10:45 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: 0341cbbaf0aa2548648c90c4d49696f60bdcd051 Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Fri Jan 13 15:15:27 2017 +0530 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/0341cbbaf0aa2548648c90c4d49696f60bdcd051 [^] Fixes issue 34886 : Changes in Parameter validation * parameterValues should be checked with query named parameters instead of query --- M src/org/openbravo/mobile/core/process/ProcessHQLQuery.java --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2017-01-10 12:05 | Asantos9 | New Issue | |
| 2017-01-10 12:05 | Asantos9 | Assigned To | => Retail |
| 2017-01-10 12:05 | Asantos9 | Triggers an Emergency Pack | => No |
| 2017-01-10 12:45 | xabiermerino | Resolution time | => 1485212400 |
| 2017-01-10 12:45 | xabiermerino | Summary | setParameterValues is not checking properly when it has to be set a parameter => [SERQA 2284] setParameterValues is not checking properly when it has to be set a parameter |
| 2017-01-12 13:52 | marvintm | Severity | minor => major |
| 2017-01-12 13:55 | ranjith_qualiantech_com | Assigned To | Retail => ranjith_qualiantech_com |
| 2017-01-12 13:55 | ranjith_qualiantech_com | Status | new => scheduled |
| 2017-01-13 10:45 | hgbot | Checkin | |
| 2017-01-13 10:45 | hgbot | Note Added: 0093475 | |
| 2017-01-13 10:45 | hgbot | Status | scheduled => resolved |
| 2017-01-13 10:45 | hgbot | Resolution | open => fixed |
| 2017-01-13 10:45 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/0341cbbaf0aa2548648c90c4d49696f60bdcd051 [^] |
| 2017-01-13 12:36 | marvintm | Review Assigned To | => marvintm |
| 2017-01-13 12:36 | marvintm | Status | resolved => closed |
| 2017-01-13 12:36 | marvintm | Fixed in Version | => RR17Q2 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |