Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0034880
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2017-01-10 09:032017-03-15 20:18
ReporteralostaleView Statuspublic 
Assigned Toalostale 
PrioritynormalResolutionfixedFixed in Version3.0PR17Q2
StatusclosedFix in branchFixed in SCM revisionf66c40dce8ca
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0034880: unneeded query execution when editing alert rules

DescriptionWhen editing an alert rule, the SQL query defining it is validated to ensure required fields are included. To do this validation the query is executed to get its metadata.

This metadata can be directly obtained without the need of executing the query.
Steps To Reproduce1. Create a new Alert Rule
2. Check the query gets executed whenever SQL definition changes
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0093289)
hgbot (developer)
2017-01-10 09:21

 Repository: erp/devel/pi
Changeset: f66c40dce8cae13d4a73037d31b75a77b71beec6
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Jan 10 09:04:34 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/f66c40dce8cae13d4a73037d31b75a77b71beec6 [^]

fixed bug 34880: unneeded query execution when editing alert rules

  There is no need to execute the query defining the alert to check its metadata,
  it can be directly obtained from the statement without executing it.

---
M src/org/openbravo/erpCommon/ad_callouts/SL_AlertRule_SQL.java
---
(0093290)
hgbot (developer)
2017-01-10 09:21

 Repository: erp/devel/pi
Changeset: 30095891fd558998036b2ac3396c72dd13faa67f
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Jan 10 09:21:04 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/30095891fd558998036b2ac3396c72dd13faa67f [^]

related to bug 34880: some clean up

  - replaced printStackTrace with proper log
  - added class java doc

---
M src/org/openbravo/erpCommon/ad_callouts/SL_AlertRule_SQL.java
---
(0093291)
hgbot (developer)
2017-01-10 09:34

 Repository: erp/devel/pi
Changeset: 2a03b4d16b5d767c114eb4273d3ce1874ebbe184
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Jan 10 09:33:32 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/2a03b4d16b5d767c114eb4273d3ce1874ebbe184 [^]

related to bug 34880: added query string to error log

---
M src/org/openbravo/erpCommon/ad_callouts/SL_AlertRule_SQL.java
---
(0093550)
hgbot (developer)
2017-01-13 15:19

 Repository: erp/devel/pi
Changeset: fdb4752766d1a62d116f558732a9f3331d1eb988
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Fri Jan 13 15:18:33 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/fdb4752766d1a62d116f558732a9f3331d1eb988 [^]

related to issue 34880: trivial message improvement, space after two points

---
M src/org/openbravo/erpCommon/ad_callouts/SL_AlertRule_SQL.java
---
(0093551)
hgbot (developer)
2017-01-13 15:32

 Repository: erp/devel/pi
Changeset: ef8c02d2794d1da3366b0e93629b3d7934bc0885
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Fri Jan 13 15:32:06 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/ef8c02d2794d1da3366b0e93629b3d7934bc0885 [^]

related to issue 34880: changed DB message text

Changed DB message text instead of adding the space in the callout. Otherwise the info message bar was shown when it should not.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/erpCommon/ad_callouts/SL_AlertRule_SQL.java
---
(0093552)
caristu (viewer)
2017-01-13 15:41

 Code reviewed + tested OK in pi@ef8c02d2794d

Working fine by retrieving the meta-data from the PreparedStatement.
(0095076)
hudsonbot (viewer)
2017-03-15 20:18

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test
(0095077)
hudsonbot (viewer)
2017-03-15 20:18

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test
(0095078)
hudsonbot (viewer)
2017-03-15 20:18

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test
(0095095)
hudsonbot (viewer)
2017-03-15 20:18

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test
(0095096)
hudsonbot (viewer)
2017-03-15 20:18

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2017-01-10 09:03 alostale New Issue
2017-01-10 09:03 alostale Assigned To => alostale
2017-01-10 09:03 alostale OBNetwork customer => No
2017-01-10 09:03 alostale Modules => Core
2017-01-10 09:03 alostale Triggers an Emergency Pack => No
2017-01-10 09:21 hgbot Checkin
2017-01-10 09:21 hgbot Note Added: 0093289
2017-01-10 09:21 hgbot Status new => resolved
2017-01-10 09:21 hgbot Resolution open => fixed
2017-01-10 09:21 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/f66c40dce8cae13d4a73037d31b75a77b71beec6 [^]
2017-01-10 09:21 hgbot Checkin
2017-01-10 09:21 hgbot Note Added: 0093290
2017-01-10 09:32 alostale Review Assigned To => caristu
2017-01-10 09:34 hgbot Checkin
2017-01-10 09:34 hgbot Note Added: 0093291
2017-01-13 15:19 hgbot Checkin
2017-01-13 15:19 hgbot Note Added: 0093550
2017-01-13 15:32 hgbot Checkin
2017-01-13 15:32 hgbot Note Added: 0093551
2017-01-13 15:41 caristu Note Added: 0093552
2017-01-13 15:41 caristu Status resolved => closed
2017-01-13 15:41 caristu Fixed in Version => 3.0PR17Q2
2017-03-15 20:18 hudsonbot Checkin
2017-03-15 20:18 hudsonbot Note Added: 0095076
2017-03-15 20:18 hudsonbot Checkin
2017-03-15 20:18 hudsonbot Note Added: 0095077
2017-03-15 20:18 hudsonbot Checkin
2017-03-15 20:18 hudsonbot Note Added: 0095078
2017-03-15 20:18 hudsonbot Checkin
2017-03-15 20:18 hudsonbot Note Added: 0095095
2017-03-15 20:18 hudsonbot Checkin
2017-03-15 20:18 hudsonbot Note Added: 0095096

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker