Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0034849

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Web POS

major

have not tried

2017-01-04 12:24

2017-01-13 14:19

Reporter

ebecerra

View Status

public

Assigned To

ranjith_qualiantech_com

Priority

normal

Resolution

fixed

Fixed in Version

RR17Q2

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

No

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0034849: BP Selector: Used "this" when saved a customer and customer address

Description

In the files:
js/data/datacusotmeraddrsave.js and js/data/datacusotmersave.js in the methods: OB.DATA.executeCustomerAddressSave and OB.DATA.CustomerSave respectively are used a reference to "this" and are not correct.

Steps To Reproduce

N/A

Tags

No tags attached.

posterminal_address.diff [^] (709 bytes) 2017-01-04 12:24 [Show Content] [Hide Content]

diff --git a/web/org.openbravo.retail.posterminal/js/data/datacustomeraddrsave.js b/web/org.openbravo.retail.posterminal/js/data/datacustomeraddrsave.js
--- a/web/org.openbravo.retail.posterminal/js/data/datacustomeraddrsave.js
+++ b/web/org.openbravo.retail.posterminal/js/data/datacustomeraddrsave.js
@@ -25,7 +25,7 @@
     }, this);
 
     OB.DATA.executeCustomerAddressSave = function (customerAddr, callback) {
-      var customerAddrList, customerAddrId = this.customerAddr.get('id'),
+      var customerAddrList, customerAddrId = customerAddr.get('id'),
           isNew = false,
           bpLocToSave = new OB.Model.ChangedBPlocation(),
           customerAddrListToChange, updateLocally, me = this;

posterminal_customer.diff [^] (1,143 bytes) 2017-01-04 12:24 [Show Content] [Hide Content]

diff --git a/web/org.openbravo.retail.posterminal/js/data/datacustomersave.js b/web/org.openbravo.retail.posterminal/js/data/datacustomersave.js
--- a/web/org.openbravo.retail.posterminal/js/data/datacustomersave.js
+++ b/web/org.openbravo.retail.posterminal/js/data/datacustomersave.js
@@ -23,7 +23,7 @@
     }, this);
 
     OB.DATA.executeCustomerSave = function (customer, callback) {
-      var customersList, customerId = this.customer.get('id'),
+      var customersList, customerId = customer.get('id'),
           isNew = false,
           bpToSave = new OB.Model.ChangedBusinessPartners(),
           bpLocation, bpLocToSave = new OB.Model.BPLocation(),
@@ -72,8 +72,8 @@
         } else {
           customer.set('loaded', OB.I18N.normalizeDate(new Date(customer.get('loaded'))));
         }
-        bpToSave.set('json', JSON.stringify(this.customer.serializeEditedToJSON()));
-        bpToSave.set('c_bpartner_id', this.customer.get('id'));
+        bpToSave.set('json', JSON.stringify(customer.serializeEditedToJSON()));
+        bpToSave.set('c_bpartner_id', customer.get('id'));
       } else {
         isNew = true;
       }

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0093214) hgbot (developer) 2017-01-05 10:24	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: e5ea21d219bad274a6b4b0961bff51a840b7d440 Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Thu Jan 05 14:54:05 2017 +0530 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e5ea21d219bad274a6b4b0961bff51a840b7d440 [^] Fixed issue 34849 : Removed incorrect "this" reference in Customer Save Action * Incorrect "this" reference are removed from Customer & Customer Address Save Action --- M web/org.openbravo.retail.posterminal/js/data/datacustomeraddrsave.js M web/org.openbravo.retail.posterminal/js/data/datacustomersave.js ---

Issue History
Date Modified	Username	Field	Change
2017-01-04 12:24	ebecerra	New Issue
2017-01-04 12:24	ebecerra	Assigned To	=> Retail
2017-01-04 12:24	ebecerra	File Added: posterminal_address.diff
2017-01-04 12:24	ebecerra	OBNetwork customer	=> No
2017-01-04 12:24	ebecerra	Triggers an Emergency Pack	=> No
2017-01-04 12:24	ebecerra	File Added: posterminal_customer.diff
2017-01-05 06:48	ranjith_qualiantech_com	Assigned To	Retail => ranjith_qualiantech_com
2017-01-05 06:48	ranjith_qualiantech_com	Status	new => scheduled
2017-01-05 10:24	hgbot	Checkin
2017-01-05 10:24	hgbot	Note Added: 0093214
2017-01-05 10:24	hgbot	Status	scheduled => resolved
2017-01-05 10:24	hgbot	Resolution	open => fixed
2017-01-05 10:24	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e5ea21d219bad274a6b4b0961bff51a840b7d440 [^]
2017-01-13 14:19	marvintm	Review Assigned To	=> marvintm
2017-01-13 14:19	marvintm	Status	resolved => closed
2017-01-13 14:19	marvintm	Fixed in Version	=> RR17Q2

Copyright © 2000 - 2009 MantisBT Group