Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0034764
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] StoreServerminorhave not tried2016-12-17 18:372016-12-28 09:54
ReportermtaalView Statuspublic 
Assigned Tomtaal 
PrioritynormalResolutionfixedFixed in VersionRR17Q1
StatusclosedFix in branchFixed in SCM revisionaf1f73ae2a77
ProjectionnoneETAnoneTarget VersionRR17Q1
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0034764: StoreServer support hasPermission also for stateless mobile services

DescriptionWhen a mobile service has the annotation
@AuthenticationManager.Stateless

then the mobile service needs to override the hasPermission method as this method creates a session. If the method is not overridden then a warning is logged [1]. A better solution is to prevent the http session creation in the method [2].

[1]
1867120 [http-bio-9080-exec-3] WARN org.openbravo.mobile.core.process.SecuredJSONProcess - Allowing permission by default for a stateless request, override the hasPermission method to prevent this warning
1927118 [http-bio-9080-exec-4] WARN org.openbravo.mobile.core.process.SecuredJSONProcess - Allowing permission by default for a stateless request, override the hasPermission method to prevent this warning
1987107 [http-bio-9080-exec-8] WARN org.openbravo.mobile.core.process.SecuredJSONProcess - Allowing permission by default for a stateless request, override the hasPermission method to prevent this warning

[2]
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/b08a151d8926/src/org/openbravo/mobile/core/process/SecuredJSONProcess.java#l102 [^]
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/b08a151d8926/src/org/openbravo/mobile/core/process/SecuredJSONProcess.java#l111 [^]
Steps To ReproduceRun multi-server with the server state background process every minute

Then the above log message is created every few minutes.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0092732)
hgbot (developer)
2016-12-17 23:33

 Repository: erp/pmods/org.openbravo.retail.postest
Changeset: dcd481d8a2bad54d457b7a28f7bc5164aa72e89d
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sat Dec 17 23:33:11 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.postest/rev/dcd481d8a2bad54d457b7a28f7bc5164aa72e89d [^]

Related to issue 34764: StoreServer support hasPermission also for stateless mobile services
Change testcase to do hasPermission

---
M src/org/openbravo/retail/postest/POSTestStatelessMobileService.java
---
(0092733)
hgbot (developer)
2016-12-18 09:33

 Repository: erp/pmods/org.openbravo.retail.postest
Changeset: 2b474790d55553ec8b0d477d7f7fd6a1cef2706e
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sun Dec 18 09:32:40 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.postest/rev/2b474790d55553ec8b0d477d7f7fd6a1cef2706e [^]

Related to issue 34764: StoreServer support hasPermission also for stateless mobile services
Override the checkpermission to not let the test be blocked by lack of permission
in test sample data, but still call super.checkPermission to do the check

---
M src/org/openbravo/retail/postest/POSTestStatelessMobileService.java
---
(0092736)
hgbot (developer)
2016-12-18 21:58

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: af1f73ae2a771fb319d84dc145ea71d10330cebb
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sun Dec 18 21:58:26 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/af1f73ae2a771fb319d84dc145ea71d10330cebb [^]

Fixes issue 34764: StoreServer support hasPermission also for stateless mobile services
Make sure that hasPermission does not create a session

---
M src/org/openbravo/mobile/core/process/SecuredJSONProcess.java
---
(0093035)
Sandrahuguet (viewer)
2016-12-28 09:54

 reviewed and tested

- Issue History
Date Modified Username Field Change
2016-12-17 18:37 mtaal New Issue
2016-12-17 18:37 mtaal Assigned To => mtaal
2016-12-17 18:37 mtaal OBNetwork customer => No
2016-12-17 18:37 mtaal Triggers an Emergency Pack => No
2016-12-17 23:33 hgbot Checkin
2016-12-17 23:33 hgbot Note Added: 0092732
2016-12-18 09:33 hgbot Checkin
2016-12-18 09:33 hgbot Note Added: 0092733
2016-12-18 21:58 hgbot Checkin
2016-12-18 21:58 hgbot Note Added: 0092736
2016-12-18 21:58 hgbot Status new => resolved
2016-12-18 21:58 hgbot Resolution open => fixed
2016-12-18 21:58 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/af1f73ae2a771fb319d84dc145ea71d10330cebb [^]
2016-12-23 13:22 mtaal Review Assigned To => Sandrahuguet
2016-12-28 09:54 Sandrahuguet Note Added: 0093035
2016-12-28 09:54 Sandrahuguet Status resolved => closed
2016-12-28 09:54 Sandrahuguet Fixed in Version => RR17Q1

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker