Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0034740
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Offline Modemajoralways2016-12-15 09:242016-12-21 18:06
ReporterchristiangoniView Statuspublic 
Assigned Tochristiangoni 
PrioritynormalResolutionfixedFixed in VersionRR17Q1
StatusclosedFix in branchFixed in SCM revision18f65164219e
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2016-10-21
Regression introduced in release
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/200143bab315e7aaebaa74233d6ab6bfb4959789 [^]
Triggers an Emergency PackNo
Summary

0034740: Error after creating a new Business Partner, new BPLocation and complete a ticket while being offline

DescriptionBeing offline, create a new Business Partner and new BP Location. Complete a ticket.
When connection is restored, the POS is unable to insert the data in the database because the BP has no creation date and POS can not order the insertion.
Steps To ReproduceLog in
Go offline
Create a BP
Create a new Location for this BP
Complete a sale
Restore connection
Oracle raises an error while synchronizing the data.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 0034741RR16Q4.1 closedmarvintm Error after creating a new Business Partner, new BPLocation and complete a ticket while being offline 
depends on backport 0034742RR16Q3.5 closedmarvintm Error after creating a new Business Partner, new BPLocation and complete a ticket while being offline 
caused by defect 0034254 closedmigueldejuana Import entries need to be executed in time order (by terminal) 

-  Notes
(0092751)
hgbot (developer)
2016-12-19 09:28
edited on: 2016-12-21 18:00

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 18f65164219ea2a798da09bc17d46134e7290969
Author: Christian Goni <christian.goni <at> openbravo.com>
Date: Thu Dec 15 13:02:59 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/18f65164219ea2a798da09bc17d46134e7290969 [^]

fixed issue 34740: Error after creating a new Business Partner, new BPLocation and complete a ticket while being offline


Due to issue 34254, countEntries was moved to the correct class to allow the terminal execute the import entries in time order and so, CustomerAddrImportEntryProcessor should not implement it.

---
M src/org/openbravo/retail/posterminal/importprocess/CustomerAddrImportEntryProcessor.java
M src/org/openbravo/retail/posterminal/importprocess/CustomerImportEntryProcessor.java
---
(0092752)
hgbot (developer)
2016-12-19 09:28

 Repository: tools/automation/pi-mobile
Changeset: d75a84baac1c2fa7c917313ef509ca384a7abfb4
Author: Christian Goni <christian.goni <at> openbravo.com>
Date: Fri Dec 16 11:23:35 2016 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/d75a84baac1c2fa7c917313ef509ca384a7abfb4 [^]

verify issue 34740:Error after creating a new Business Partner, new BPLocation and complete a ticket while being offline

---
M src-test/org/openbravo/test/mobile/retail/pack/database/WebPOSDatabaseHelper.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/offline/WebPOSOfflineCustomTerminalHelper.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/offline/CreateBPandBPLocation_saleOffline.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/offline/CreateBPandBPLocation_saleOnline.java
---
(0092916)
hgbot (developer)
2016-12-21 18:04

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e2d9f6154d2b7f257a8988790ab3a3fc3f61b1b3
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Wed Dec 21 18:04:00 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e2d9f6154d2b7f257a8988790ab3a3fc3f61b1b3 [^]

Related to issue 34740. Applied correct formatting.

---
M src/org/openbravo/retail/posterminal/importprocess/CustomerAddrImportEntryProcessor.java
M src/org/openbravo/retail/posterminal/importprocess/CustomerImportEntryProcessor.java
---
(0092917)
marvintm (viewer)
2016-12-21 18:06

 Commit message is not clear enough. Basically, the main idea is to make the Customer and Customer Address import processors use the SerializedByTermImportEntryProcessorRunnable, with the main purpose of ensuring that all messages coming from the same terminal are processed in the order in which they were generated.

This, in turn, ensures that when several messages are generated while the terminal is offline, they are processed correctly once the terminal comes back to online.

- Issue History
Date Modified Username Field Change
2016-12-15 09:24 christiangoni New Issue
2016-12-15 09:24 christiangoni Assigned To => Retail
2016-12-15 09:24 christiangoni OBNetwork customer => No
2016-12-15 09:24 christiangoni Triggers an Emergency Pack => No
2016-12-15 13:17 christiangoni Regression date => 2016-10-21
2016-12-15 13:17 christiangoni Regression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/200143bab315e7aaebaa74233d6ab6bfb4959789 [^]
2016-12-15 13:18 christiangoni Relationship added caused by 0034254
2016-12-15 13:19 christiangoni Status new => scheduled
2016-12-15 13:27 christiangoni Regression level => Production - Confirmed Stable
2016-12-19 09:28 hgbot Checkin
2016-12-19 09:28 hgbot Note Added: 0092751
2016-12-19 09:28 hgbot Status scheduled => resolved
2016-12-19 09:28 hgbot Resolution open => fixed
2016-12-19 09:28 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/18f65164219ea2a798da09bc17d46134e7290969 [^]
2016-12-19 09:28 hgbot Checkin
2016-12-19 09:28 hgbot Note Added: 0092752
2016-12-19 11:25 marvintm Assigned To Retail => christiangoni
2016-12-21 18:00 christiangoni Note Edited: 0092751 View Revisions
2016-12-21 18:04 hgbot Checkin
2016-12-21 18:04 hgbot Note Added: 0092916
2016-12-21 18:06 marvintm Note Added: 0092917
2016-12-21 18:06 marvintm Review Assigned To => marvintm
2016-12-21 18:06 marvintm Status resolved => closed
2016-12-21 18:06 marvintm Fixed in Version => RR17Q1

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker