Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0034731
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 09. Financial managementmajoralways2016-12-14 16:232016-12-16 18:39
Reporteralekosmp86View Statuspublic 
Assigned Toalekosmp86 
PrioritynormalResolutionfixedFixed in Version3.0PR17Q1
StatusclosedFix in branchFixed in SCM revision58fbcff62ff8
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toaferraz
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0034731: Wrong amount value when adding payment to a transaction

DescriptionWhen creating a withdrawal transaction in Financial Account screen, if you add a payment, the field Actual Payment is showing 0.00 instead of the defined amount of the transaction.
Steps To Reproduce- Create a Transaction in "Cuenta de Banco" Financial Account.
  Transaction Type: BP Withdrawal
  Withdrawal Amount: 2000
- Click on Add Payment
  Realize Actual Payment is not set to 2000
Proposed SolutionOverwrite line 265 and 272 in TransactionAddPaymentDefaultValues.java with the following code:

return new BigDecimal(convertToSafeDecimalString(context.getString("depositamt"))).subtract(new BigDecimal(convertToSafeDecimalString(context.getString("withdrawalamt")))).toString();
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0092364)
alekosmp86 (reporter)
2016-12-14 16:27

Test plan

Log in as F&B International GroupAdmin

   Go to Financial Account screen
      Select "Cuenta de Banco" financial account
      
      Go to Transaction tab
         Create a new record
            Transaction Type: BP Withdrawal
            Withdrawal amount: 2000
            Payment: Click the + button to add a payment. A new window appears; notice that Actual Payment field is set to 2000, which is the correct amount (defined in the previous step).
(0092368)
hgbot (developer)
2016-12-14 16:36

Repository: erp/devel/pi
Changeset: 58fbcff62ff8f331ad4ae0497627db19cf6df1f8
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Wed Dec 14 10:27:46 2016 -0500
URL: http://code.openbravo.com/erp/devel/pi/rev/58fbcff62ff8f331ad4ae0497627db19cf6df1f8 [^]

Fixes issue 34731: Wrong amount value when adding payment to a transaction

When creating a withdrawal transaction in Financial Account screen, if you add a
payment, the field Actual Payment was showing 0.00 instead of the correct amount
of the transaction. This issue is solved by calling the method convertToSafeDecimalString,
which returns a well formed string, so the correct amount can be displayed.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/TransactionAddPaymentDefaultValues.java
---
(0092369)
aferraz (manager)
2016-12-14 16:37

Code review + Testing OK
(0092712)
hudsonbot (developer)
2016-12-16 18:39

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2016-12-14 16:23 alekosmp86 New Issue
2016-12-14 16:23 alekosmp86 Assigned To => alekosmp86
2016-12-14 16:23 alekosmp86 Modules => Core
2016-12-14 16:23 alekosmp86 Triggers an Emergency Pack => No
2016-12-14 16:27 alekosmp86 Note Added: 0092364
2016-12-14 16:36 hgbot Checkin
2016-12-14 16:36 hgbot Note Added: 0092368
2016-12-14 16:36 hgbot Status new => resolved
2016-12-14 16:36 hgbot Resolution open => fixed
2016-12-14 16:36 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/58fbcff62ff8f331ad4ae0497627db19cf6df1f8 [^]
2016-12-14 16:37 aferraz Review Assigned To => aferraz
2016-12-14 16:37 aferraz Note Added: 0092369
2016-12-14 16:37 aferraz Status resolved => closed
2016-12-14 16:37 aferraz Fixed in Version => 3.0PR17Q1
2016-12-16 18:39 hudsonbot Checkin
2016-12-16 18:39 hudsonbot Note Added: 0092712


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker