Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0034708 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| design defect | [Retail Modules] StoreServer | minor | have not tried | 2016-12-08 08:34 | 2016-12-14 17:35 | |||
| Reporter | mtaal | View Status | public | |||||
| Assigned To | mtaal | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | 8d9e9bf223ae | ||||
| Projection | none | ETA | none | Target Version | RR17Q1 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | AugustoMauch | |||||||
| OBNetwork customer | No | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0034708: Server State Background: prevent update of server state if it hasn't changed | |||||||
| Description | The server state background process updates the state of a server [1]. It always calls the save method [2] eventhough the state might not have changed. [1] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/4b9f3131a589/src/org/openbravo/mobile/core/servercontroller/ServerStateBackground.java [^] [2] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/4b9f3131a589/src/org/openbravo/mobile/core/servercontroller/ServerStateBackground.java#l140 [^] | |||||||
| Steps To Reproduce | See description | |||||||
| Proposed Solution | Only set the state and save if it is different from the current state | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0092209) hgbot (developer) 2016-12-08 08:36 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: d6bb0c452dd557fda12c9aa874e2be1fea7cce31 Author: Martin Taal <martin.taal <at> openbravo.com> Date: Thu Dec 08 08:35:22 2016 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/d6bb0c452dd557fda12c9aa874e2be1fea7cce31 [^] Fixes issue 34708: Server State Background: prevent update of server state if it hasn't changed Set the state and save only if the server status has changed --- M src/org/openbravo/mobile/core/servercontroller/ServerStateBackground.java --- |
|
(0092265) AugustoMauch (administrator) 2016-12-10 18:59 |
In this line [1], the status of the server is being compared with MobileServerState.OFFLINE to check if the server is offline, using the srv.getStatus() method. This used to be done after updating the status, but now the status has not been updated yet. [1] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/d6bb0c452dd5/src/org/openbravo/mobile/core/servercontroller/ServerStateBackground.java#l141 [^] |
|
(0092268) hgbot (developer) 2016-12-11 08:23 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: 8d9e9bf223ae1ab9becf210db886960e04958f32 Author: Martin Taal <martin.taal <at> openbravo.com> Date: Sun Dec 11 08:23:13 2016 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/8d9e9bf223ae1ab9becf210db886960e04958f32 [^] Fixes issue 34708: Server State Background: prevent update of server state if it hasn't changed Check the newStatus instead of value in mobile server definition record. --- M src/org/openbravo/mobile/core/servercontroller/ServerStateBackground.java --- |
|
(0092373) AugustoMauch (administrator) 2016-12-14 17:35 |
Code reviewed and verified |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2016-12-08 08:34 | mtaal | New Issue | |
| 2016-12-08 08:34 | mtaal | Assigned To | => mtaal |
| 2016-12-08 08:34 | mtaal | OBNetwork customer | => No |
| 2016-12-08 08:34 | mtaal | Triggers an Emergency Pack | => No |
| 2016-12-08 08:34 | mtaal | Review Assigned To | => AugustoMauch |
| 2016-12-08 08:36 | hgbot | Checkin | |
| 2016-12-08 08:36 | hgbot | Note Added: 0092209 | |
| 2016-12-08 08:36 | hgbot | Status | new => resolved |
| 2016-12-08 08:36 | hgbot | Resolution | open => fixed |
| 2016-12-08 08:36 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/d6bb0c452dd557fda12c9aa874e2be1fea7cce31 [^] |
| 2016-12-10 18:59 | AugustoMauch | Note Added: 0092265 | |
| 2016-12-10 18:59 | AugustoMauch | Status | resolved => new |
| 2016-12-10 18:59 | AugustoMauch | Resolution | fixed => open |
| 2016-12-11 08:23 | hgbot | Checkin | |
| 2016-12-11 08:23 | hgbot | Note Added: 0092268 | |
| 2016-12-11 08:23 | hgbot | Status | new => resolved |
| 2016-12-11 08:23 | hgbot | Resolution | open => fixed |
| 2016-12-11 08:23 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/d6bb0c452dd557fda12c9aa874e2be1fea7cce31 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/8d9e9bf223ae1ab9becf210db886960e04958f32 [^] |
| 2016-12-14 17:35 | AugustoMauch | Note Added: 0092373 | |
| 2016-12-14 17:35 | AugustoMauch | Status | resolved => closed |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |