Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0034699
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 04. Warehouse managementmajoralways2016-12-07 12:192016-12-16 18:39
ReportermaiteView Statuspublic 
Assigned Toalekosmp86 
PriorityurgentResolutionfixedFixed in Version3.0PR17Q1
StatusclosedFix in branchFixed in SCM revision39054650a297
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toaferraz
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0034699: Warehouse combo only shows values once Valued Stock Report has been executed

DescriptionBefore report is launched for first time, warehouse combo should also shown proper values
Steps To Reproduce1. Access Valued Stock Report window and select "España Region Norte" organization
2. Realize that Warehouse combo is empty
3. Run HTML report
4. Realize that after that proper value is shown in Warehouse combo
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to feature request 0034221 closedSanjota Merge Valued Stock Report Enhanced with Valued Stock Report in Core 

-  Notes
(0092226)
alekosmp86 (reporter)
2016-12-08 20:14
edited on: 2016-12-12 15:54

 Test Plan

Log in as GroupAdmin
   Go to Valued Stock Report screen
      Select Organization: España Región Norte (do not run the report or refresh the window)
      Deploy Warehouse combo and notice that it is filled with the proper values.

      Select Organization: España Región Sur
      Deploy Warehouse combo and notice that it is refreshed and is showing the proper value.

      Select Organization: F&B España S.A
      Deploy Warehouse combo and notice that it is refreshed and is showing the warehouses from both España Región Norte and España Región Sur.

   Check that this behaviour is the same for F&B US Inc.
(0092317)
hgbot (developer)
2016-12-13 13:48

 Repository: erp/devel/pi
Changeset: 727f8fe076d2bb3c7511079e62ecf16cf7ce6350
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Mon Dec 12 09:24:31 2016 -0500
URL: http://code.openbravo.com/erp/devel/pi/rev/727f8fe076d2bb3c7511079e62ecf16cf7ce6350 [^]

Fixes issue 34699: Warehouse combo shows no values in Valued Stock Report

Before report was launched for first time, warehouse combo was not showning proper
values, it was empty. It was caused because this combo didn't get updated in the
onChange event of the Organization's combo, but it was updated when reloading the
report or running it with an organization already selected. Also, when selecting an
organization with no warehouses, but with children organizations that has a warehouses
asociated, the combo was not showing those warehouses. This has been fixed so when
selecting the organization with no warehouses, it now searches in its children in
order to show the warehouses if they exists.

---
M src/org/openbravo/erpCommon/ad_reports/ReportValuationStock.html
M src/org/openbravo/erpCommon/ad_reports/ReportValuationStock.java
M src/org/openbravo/erpCommon/ad_reports/ReportValuationStock_data.xsql
---
(0092318)
hgbot (developer)
2016-12-13 13:48

 Repository: erp/devel/pi
Changeset: 53970ce14a73315f5f310891310fe94f7b270c4e
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Tue Dec 13 12:48:49 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/53970ce14a73315f5f310891310fe94f7b270c4e [^]

Related to issue 34699: Code review improvements

Use ad_isorgincluded instead of ad_org_isinnaturaltree.

---
M src/org/openbravo/erpCommon/ad_reports/ReportValuationStock.java
M src/org/openbravo/erpCommon/ad_reports/ReportValuationStock_data.xsql
---
(0092319)
aferraz (manager)
2016-12-13 13:53

 Code review + Testing OK
(0092334)
hgbot (developer)
2016-12-14 10:19

 Repository: erp/devel/pi
Changeset: 01d5ce09bb609f61e54e2a6c79d0541b02441059
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Wed Dec 14 10:16:03 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/01d5ce09bb609f61e54e2a6c79d0541b02441059 [^]

Related to issue 34699: Fix ReportValuationStock2.html too

---
M src/org/openbravo/erpCommon/ad_reports/ReportValuationStock2.html
---
(0092339)
hgbot (developer)
2016-12-14 11:33

 Repository: erp/pmods/org.openbravo.warehouse.reportvaluedstockenhanced
Changeset: 39054650a297a3c5e2b4526c5085151a3e2eee5b
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Wed Dec 14 10:26:43 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.reportvaluedstockenhanced/rev/39054650a297a3c5e2b4526c5085151a3e2eee5b [^]

Fixes issue 34699: Warehouse combo shows no values in Valued Stock Report

Before report was launched for first time, warehouse combo was not showning proper
values, it was empty. It was caused because this combo didn't get updated in the
onChange event of the Organization's combo, but it was updated when reloading the
report or running it with an organization already selected. Also, when selecting an
organization with no warehouses, but with children organizations that has a warehouses
asociated, the combo was not showing those warehouses. This has been fixed so when
selecting the organization with no warehouses, it now searches in its children in
order to show the warehouses if they exists.

---
M src/org/openbravo/warehouse/reportvaluedstockenhanced/ReportValuedStockEnhanced.html
M src/org/openbravo/warehouse/reportvaluedstockenhanced/ReportValuedStockEnhanced2.html
M src/org/openbravo/warehouse/reportvaluedstockenhanced/ReportValuedStockEnhanced_data.xsql
---
(0092340)
hgbot (developer)
2016-12-14 11:33

 Repository: erp/pmods/org.openbravo.warehouse.reportvaluedstockenhanced
Changeset: 66d2d95e90a6ff5121674aabdbe8e7ba6e75731a
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Wed Dec 14 10:45:16 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.reportvaluedstockenhanced/rev/66d2d95e90a6ff5121674aabdbe8e7ba6e75731a [^]

Related to issue 34699: Update module version

---
M src-db/database/sourcedata/AD_MODULE.xml
---
(0092341)
aferraz (manager)
2016-12-14 11:35

 Code review + Testing OK
(0092703)
hudsonbot (developer)
2016-12-16 18:39

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test
(0092704)
hudsonbot (developer)
2016-12-16 18:39

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test
(0092706)
hudsonbot (developer)
2016-12-16 18:39

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2016-12-07 12:19 maite New Issue
2016-12-07 12:19 maite Assigned To => Triage Finance
2016-12-07 12:19 maite Modules => Core
2016-12-07 12:19 maite Resolution time => 1482879600
2016-12-07 12:19 maite Triggers an Emergency Pack => No
2016-12-07 12:20 maite Issue Monitored: networkb
2016-12-07 12:20 maite Relationship added related to 0034221
2016-12-07 17:09 alekosmp86 Assigned To Triage Finance => alekosmp86
2016-12-07 17:09 alekosmp86 Status new => scheduled
2016-12-08 20:14 alekosmp86 Note Added: 0092226
2016-12-12 15:54 alekosmp86 Note Edited: 0092226 View Revisions
2016-12-13 13:48 hgbot Checkin
2016-12-13 13:48 hgbot Note Added: 0092317
2016-12-13 13:48 hgbot Status scheduled => resolved
2016-12-13 13:48 hgbot Resolution open => fixed
2016-12-13 13:48 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/727f8fe076d2bb3c7511079e62ecf16cf7ce6350 [^]
2016-12-13 13:48 hgbot Checkin
2016-12-13 13:48 hgbot Note Added: 0092318
2016-12-13 13:53 aferraz Review Assigned To => aferraz
2016-12-13 13:53 aferraz Note Added: 0092319
2016-12-13 13:53 aferraz Status resolved => closed
2016-12-13 13:53 aferraz Fixed in Version => 3.0PR17Q1
2016-12-14 10:19 hgbot Checkin
2016-12-14 10:19 hgbot Note Added: 0092334
2016-12-14 11:33 hgbot Checkin
2016-12-14 11:33 hgbot Note Added: 0092339
2016-12-14 11:33 hgbot Status closed => resolved
2016-12-14 11:33 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/727f8fe076d2bb3c7511079e62ecf16cf7ce6350 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.reportvaluedstockenhanced/rev/39054650a297a3c5e2b4526c5085151a3e2eee5b [^]
2016-12-14 11:33 hgbot Checkin
2016-12-14 11:33 hgbot Note Added: 0092340
2016-12-14 11:35 aferraz Note Added: 0092341
2016-12-14 11:35 aferraz Status resolved => closed
2016-12-16 18:39 hudsonbot Checkin
2016-12-16 18:39 hudsonbot Note Added: 0092703
2016-12-16 18:39 hudsonbot Checkin
2016-12-16 18:39 hudsonbot Note Added: 0092704
2016-12-16 18:39 hudsonbot Checkin
2016-12-16 18:39 hudsonbot Note Added: 0092706

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker