Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0034666
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] StoreServerminorhave not tried2016-12-01 14:202016-12-27 10:53
ReportermtaalView Statuspublic 
Assigned Tomtaal 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision05f67e25ac5a
ProjectionnoneETAnoneTarget VersionRR17Q1
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0034666: Transition to online: infinite loop through offline-->transition-->offline when error during synchronization

DescriptionWhen a failure occurs during transition to online or when there are synchronization or other errors then the system will continuously try to go online, fail, goto offline and then again try to go online etc. During transition to online the terminals can't work.


Steps To ReproduceInstall multi-server
Create a synchronization error from central to store
Stop central
let the store go offline
Start central
store will go into infinite loop through offline-transitiontoonline states

Proposed SolutionProposal:
- add a preference: 'Transition-to-online fail retry time'. This preference controls how much time to wait to retry transition to online after a failure
- The new preference is used when transition to online fails for whatever reason. In this case existing 'timing' preferences/configuration to ping central server and try to transition to online will not be used.
- The default value of the new preference will be one hour (if the preference is not set).
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0092071)
hgbot (developer)
2016-12-03 12:42

Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 7b207d1082e0fff66fcde590e997a4c02d3f5b10
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sat Dec 03 12:40:34 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/7b207d1082e0fff66fcde590e997a4c02d3f5b10 [^]

Related to issue 34666: Transition to online: infinite loop through offline-->transition-->offline
Add new preference property to define 'failed transition to offline' wait time. Add new button
to mobile server window to tell server to transition to online

---
M src-db/database/model/tables/OBMOBC_SERVER_DEFINITION.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
A src-db/database/sourcedata/OBUIAPP_PROCESS.xml
---
(0092072)
hgbot (developer)
2016-12-03 12:42

Repository: erp/pmods/org.openbravo.mobile.core
Changeset: a1cb6b5c214390706b289e389927f355f11199ad
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sat Dec 03 12:41:47 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/a1cb6b5c214390706b289e389927f355f11199ad [^]

Fixes issue 34666: Transition to online: infinite loop through offline-->transition-->offline
Use new preference to wait with transition to online after failure, implement webservice to
allow an administrator to tell the server to go online.

- MobileServerSendTransitionToOnline: caller/process to call other server to transition to online
- ForceTransitionToOnline: webservice which can be called to force transition to online
- MobileServerController: add wait if transition to online fails, add methods to force transition to online

---
M src/org/openbravo/mobile/core/servercontroller/MobileServerController.java
A src/org/openbravo/mobile/core/servercontroller/ForceTransitionToOnline.java
A src/org/openbravo/mobile/core/servercontroller/MobileServerSendTransitionToOnline.java
---
(0092077)
mtaal (viewer)
2016-12-04 22:12

Documented here:
http://wiki.openbravo.com/wiki/Store_Server_Online_and_Offline_Concepts#Transitioning_Triggers_-_Send_Transition_to_Online [^]

See preference described here:
http://wiki.openbravo.com/wiki/Store_and_Multi_Server_Preferences#Behavioral_Preferences [^]
(0092202)
AugustoMauch (administrator)
2016-12-07 18:00

This method does not have an access modifier [1]. This [2] does not seem the best way to call a method, could just 'this' be used instead?

[1] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/a1cb6b5c214390706b289e389927f355f11199ad#l2.45 [^]
[2] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/a1cb6b5c214390706b289e389927f355f11199ad#l2.56 [^]
(0092207)
hgbot (developer)
2016-12-08 08:35

Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 05f67e25ac5a85a4af82febac6704e38a294a4f8
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Thu Dec 08 08:31:40 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/05f67e25ac5a85a4af82febac6704e38a294a4f8 [^]

Fixes issue 34666: Transition to online: infinite loop through offline-->transition-->offline when error during synchronization
Solves code review comments

---
M src/org/openbravo/mobile/core/servercontroller/MobileServerController.java
---
(0093012)
hgbot (developer)
2016-12-27 10:52

Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 61f2952b9254ed56a968315af87c87be7612b0a7
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Dec 27 10:52:19 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/61f2952b9254ed56a968315af87c87be7612b0a7 [^]

Related with issue 34666: Removes small duplication and fixes format

---
M src/org/openbravo/mobile/core/servercontroller/MobileServerController.java
---
(0093013)
AugustoMauch (administrator)
2016-12-27 10:53

Code reviewed and verified

- Issue History
Date Modified Username Field Change
2016-12-01 14:20 mtaal New Issue
2016-12-01 14:20 mtaal Assigned To => mtaal
2016-12-01 14:20 mtaal OBNetwork customer => No
2016-12-01 14:20 mtaal Triggers an Emergency Pack => No
2016-12-03 12:42 hgbot Checkin
2016-12-03 12:42 hgbot Note Added: 0092071
2016-12-03 12:42 hgbot Checkin
2016-12-03 12:42 hgbot Note Added: 0092072
2016-12-03 12:42 hgbot Status new => resolved
2016-12-03 12:42 hgbot Resolution open => fixed
2016-12-03 12:42 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/a1cb6b5c214390706b289e389927f355f11199ad [^]
2016-12-04 22:12 mtaal Note Added: 0092077
2016-12-04 22:12 mtaal Review Assigned To => AugustoMauch
2016-12-07 18:00 AugustoMauch Note Added: 0092202
2016-12-07 18:00 AugustoMauch Status resolved => new
2016-12-07 18:00 AugustoMauch Resolution fixed => open
2016-12-08 08:35 hgbot Checkin
2016-12-08 08:35 hgbot Note Added: 0092207
2016-12-08 08:35 hgbot Status new => resolved
2016-12-08 08:35 hgbot Resolution open => fixed
2016-12-08 08:35 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/a1cb6b5c214390706b289e389927f355f11199ad [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/05f67e25ac5a85a4af82febac6704e38a294a4f8 [^]
2016-12-27 10:52 hgbot Checkin
2016-12-27 10:52 hgbot Note Added: 0093012
2016-12-27 10:53 AugustoMauch Note Added: 0093013
2016-12-27 10:53 AugustoMauch Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker