Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0034661
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 09. Financial managementmajoralways2016-11-30 22:182016-12-16 18:39
ReporterrbianchiniView Statuspublic 
Assigned Toalekosmp86 
PrioritynormalResolutionfixedFixed in Version3.0PR17Q1
StatusclosedFix in branchFixed in SCM revisiond008b46f932c
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product Version3.0PR16Q3.3SCM revision 
Review Assigned Todmiguelez
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0034661: You can set 2 conversion rate in the same period

DescriptionIn conversion rates window, it is possible to define different conversion rates to the same currency in the same period. It is also reproducible in pi
Steps To Reproduce1 - Go to Conversion Rates window
2 - Create a new record:
A - Currency: EUR
B - To Currency: ARS
C - Valid from: 30/11/2016
D - Valid to: 30/11/2016
E - set the rates and save
3 - Create a new record:
A - Currency: EUR
B - To Currency: ARS
C - Valid from: 28/11/2016
D - Valid to: 28/11/2201
E - set the rates and save
4 - Realize that no error is shown, and for 31/11/2016 are 2 conversion rates defined.
Proposed SolutionCheck overlapping conversion rates with an event handler.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to feature request 0006914 acknowledgededuardo_Argal Conversion rates - multiple issues 
related to defect 0030423 scheduledSanjota It would be fine if Currency Conversion Rates could be defined to be valid from and to an specific hour and not only date 

-  Notes
(0092094)
alekosmp86 (reporter)
2016-12-05 16:09

 Test Plans for this issue

Log in as F&B International GroupAdmin

Test plan 1 (when the range of dates of the new conversion rate fully overlaps an existing conversion rate)
   Go to Conversion Rates screen
      Create a new document
         Currency: EUR
         To Currency: ARS
         Valid From Date: 2016-12-05
         Valid To Date: 2016-12-07
      Save the document
      
      Create a new document
         Currency: EUR
         To Currency: ARS
         Valid From Date: 2016-12-01
         Valid To Date: 2016-12-10
      Try save the document
Notice there's an error showing that there are two conversion rates for the same currency
in the same period of time.

Test plan 2 (when the range of dates of the new conversion rate overlaps an existing conversion rate by being defined inside its range of dates)
   Go to Conversion Rates screen
      Create a new document
         Currency: EUR
         To Currency: ARS
         Valid From Date: 2016-12-05
         Valid To Date: 2016-12-07
      Save the document
      
      Create a new document
         Currency: EUR
         To Currency: ARS
         Valid From Date: 2016-12-06
         Valid To Date: 2016-12-06
      Try save the document
Notice there's an error showing that there are two conversion rates for the same currency
in the same period of time.

Test plan 3 (when the range of dates of the new conversion rate partially overlaps an existing conversion rate)
   Go to Conversion Rates screen
      Create a new document
         Currency: EUR
         To Currency: ARS
         Valid From Date: 2016-12-05
         Valid To Date: 2016-12-07
      Save the document
      
      Create a new document
         Currency: EUR
         To Currency: ARS
         Valid From Date: 2016-12-01
         Valid To Date: 2016-12-06
      Try save the document
Notice there's an error showing that there are two conversion rates for the same currency
in the same period of time.

Test plan 4 (when the range of dates of the new conversion rate does not overlap an existing conversion rate)
   Go to Conversion Rates screen
      Create a new document
         Currency: EUR
         To Currency: ARS
         Valid From Date: 2016-12-05
         Valid To Date: 2016-12-07
      Save the document
      
      Create a new document
         Currency: EUR
         To Currency: ARS
         Valid From Date: 2016-12-08
         Valid To Date: 2016-12-10
      Try save the document
Notice there's no error and the record has been successfully saved.
(0092239)
hgbot (developer)
2016-12-09 10:49

 Repository: erp/devel/pi
Changeset: d008b46f932c1f562b9d24aa2ede7adbfd8f0ce6
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Mon Dec 05 09:13:06 2016 -0500
URL: http://code.openbravo.com/erp/devel/pi/rev/d008b46f932c1f562b9d24aa2ede7adbfd8f0ce6 [^]

Fixes issue 34661: You can set 2 conversion rate in the same period

In conversion rates window, it was possible to define different conversion rates
to the same currency in the same period. When inserting or updating a conversion
rate, the date was validated so no overlaping ocurred, but it was only validating
the cases when dateFrom or dateTo were between the newly created dates, not when
those dates were outside the range of dates, i.e, were overlaping the entire range
of dates already in the system for the given date.

---
M src/org/openbravo/event/ConversionRateEventHandler.java
---
(0092240)
dmiguelez (developer)
2016-12-09 10:49

 Code Review + Testing ok
(0092694)
hudsonbot (developer)
2016-12-16 18:39

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2016-11-30 22:18 rbianchini New Issue
2016-11-30 22:18 rbianchini Assigned To => Triage Finance
2016-11-30 22:18 rbianchini Modules => Core
2016-11-30 22:18 rbianchini Resolution time => 1482289200
2016-11-30 22:18 rbianchini Triggers an Emergency Pack => No
2016-11-30 23:27 aferraz Relationship added related to 0006914
2016-11-30 23:27 aferraz Relationship added related to 0030423
2016-11-30 23:37 aferraz Resolution time 1482289200 => 1482274800
2016-11-30 23:37 aferraz Severity critical => major
2016-11-30 23:38 aferraz Proposed Solution updated
2016-11-30 23:38 aferraz Assigned To Triage Finance => collazoandy4
2016-12-02 16:46 alekosmp86 Assigned To collazoandy4 => alekosmp86
2016-12-02 16:47 alekosmp86 Status new => scheduled
2016-12-05 16:09 alekosmp86 Note Added: 0092094
2016-12-09 10:49 hgbot Checkin
2016-12-09 10:49 hgbot Note Added: 0092239
2016-12-09 10:49 hgbot Status scheduled => resolved
2016-12-09 10:49 hgbot Resolution open => fixed
2016-12-09 10:49 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/d008b46f932c1f562b9d24aa2ede7adbfd8f0ce6 [^]
2016-12-09 10:49 dmiguelez Review Assigned To => dmiguelez
2016-12-09 10:49 dmiguelez Note Added: 0092240
2016-12-09 10:49 dmiguelez Status resolved => closed
2016-12-12 18:04 aferraz Fixed in Version => 3.0PR17Q1
2016-12-16 18:39 hudsonbot Checkin
2016-12-16 18:39 hudsonbot Note Added: 0092694

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker