Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0034639
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] StoreServermajorhave not tried2016-11-26 14:132016-12-07 22:36
ReporterAugustoMauchView Statuspublic 
Assigned ToAugustoMauch 
PrioritynormalResolutionfixedFixed in VersionRR17Q1
StatusclosedFix in branchFixed in SCM revision7349959f9c43
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tomtaal
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0034639: ExportStoreData class has to be updated after the latest changes done in ExportsampleData

DescriptionNow the ability to export sample data using the PostgreSQL's copy format is part of dbsourcemanager, see [1]. This means the src/org/openbravo/retail/storeserver/synchronization/task/StreamingDatabaseDataIO.java class can be removed from the module.

Also the getDatabaseDataIO method has been removed from the ExportsampleData class, now the databaseDataIO class to use is determined by the exportFormat parameter. This means the overwritten getDatabaseDataIO in ExportStoreData can be removed too.

[1] https://issues.openbravo.com/view.php?id=33875 [^]
Steps To ReproduceGet the latest changes from pi, and try to compile. The following error will appear in the log:
...
    [javac] /srv/ci/workspace/mod-simple-ci23.141/modules/org.openbravo.retail.storeserver.synchronization/src/org/openbravo/retail/storeserver/synchronization/task/ExportStoreData.java:155: error: method does not override or implement a method from a supertype
    [javac] @Override
    [javac] ^
    [javac] 1 error
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to feature request 0033875 closedAugustoMauch Openbravo ERP Importing/Exporting sample data using PostgreSQL's COPY instead of current XML 

-  Notes
(0091868)
hgbot (developer)
2016-11-26 14:16

 Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization
Changeset: 7349959f9c433fb377cd895c951b71a10b71dbc4
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Sat Nov 26 14:16:02 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/7349959f9c433fb377cd895c951b71a10b71dbc4 [^]

Fixes issue 34639: ExportStoreData class is adapted to latest dbsm changes

There is no longer need to specify the databaseDataIO class to use for the classes extending ExportsampleData. This is now determined by the exportFormat used when exporting the sample data.

---
M src/org/openbravo/retail/storeserver/synchronization/task/ExportStoreData.java
R src/org/openbravo/retail/storeserver/synchronization/task/StreamingDatabaseDataIO.java
---
(0091923)
hgbot (developer)
2016-11-30 10:09

 Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization
Changeset: 4e62f54c05d27a2da44e2018afdf85b83f76002e
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Nov 30 10:09:24 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/4e62f54c05d27a2da44e2018afdf85b83f76002e [^]

Related with issue 34639: ExportStoreData implements latests dbsm changes

- The logic to create the SQL queries to fetch the data of a dataset table has been extracted to the new StoreDataSetTableQueryGenerator class
- The methods getQueryGenerator and overwriteDataSetTableWhereClauseWithClientFilter have been overwritten

---
M build.xml
M src/org/openbravo/retail/storeserver/synchronization/task/ExportStoreData.java
A src/org/openbravo/retail/storeserver/synchronization/StoreDataSetTableQueryGenerator.java
---
(0091940)
hgbot (developer)
2016-11-30 17:26

 Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization
Changeset: 41223545d913cb239208cf17db1f12613e22b916
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Nov 30 17:25:49 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/41223545d913cb239208cf17db1f12613e22b916 [^]

Related with issue 34639: Removes duplicated class

The StoreDataSetTableQueryGenerator class does not belong in this module, it is implemented in the org.openbravo.replication.symmetricds module.

---
M src/org/openbravo/retail/storeserver/synchronization/task/ExportStoreData.java
R src/org/openbravo/retail/storeserver/synchronization/StoreDataSetTableQueryGenerator.java
---
(0091945)
hgbot (developer)
2016-12-01 09:04

 Repository: erp/pmods/org.openbravo.replication.symmetricds
Changeset: bdd31dd0263a7265358ab34c15b86be4149b6143
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Nov 03 17:13:33 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/rev/bdd31dd0263a7265358ab34c15b86be4149b6143 [^]

Related with issue 34639: Adds a custom DataSetTableQueryGenerator

The custom DataSetTableQueryGenerator:
- Replaces the placeholders supported in the where clauses of the Store Server Creation Dataset.
- Adds a client filter

---
M src/org/openbravo/replication/symmetricds/validation/DataValidationError.java
M src/org/openbravo/replication/symmetricds/validation/ExportedTableCache.java
M src/org/openbravo/replication/symmetricds/validation/SynchronizationStoreDataValidator.java
A src/org/openbravo/replication/symmetricds/export/StoreDataSetTableQueryGenerator.java
---
(0092062)
mtaal (viewer)
2016-12-03 01:38

 Reviewed, one tiny comment:
javadoc/comment here [1] seems out of date.

Is the javadoc in the top of the class still up-to-date to?

[1]
https://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/file/tip/src/org/openbravo/replication/symmetricds/validation/DataValidationError.java#l141 [^]
(0092147)
hgbot (developer)
2016-12-06 20:20

 Repository: erp/pmods/org.openbravo.replication.symmetricds
Changeset: c1b8dcea7daad5884496f012d1bc4ab0e24f0d21
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Dec 06 20:20:32 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/rev/c1b8dcea7daad5884496f012d1bc4ab0e24f0d21 [^]

Related with issue 34639: Fixes method documentation

---
M src/org/openbravo/replication/symmetricds/validation/DataValidationError.java
---
(0092204)
mtaal (viewer)
2016-12-07 22:36

 Reviewed

- Issue History
Date Modified Username Field Change
2016-11-26 14:13 AugustoMauch New Issue
2016-11-26 14:13 AugustoMauch Assigned To => AugustoMauch
2016-11-26 14:13 AugustoMauch OBNetwork customer => No
2016-11-26 14:13 AugustoMauch Triggers an Emergency Pack => No
2016-11-26 14:13 AugustoMauch Relationship added related to 0033875
2016-11-26 14:14 AugustoMauch Review Assigned To => mtaal
2016-11-26 14:16 hgbot Checkin
2016-11-26 14:16 hgbot Note Added: 0091868
2016-11-26 14:16 hgbot Status new => resolved
2016-11-26 14:16 hgbot Resolution open => fixed
2016-11-26 14:16 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/7349959f9c433fb377cd895c951b71a10b71dbc4 [^]
2016-11-30 10:09 hgbot Checkin
2016-11-30 10:09 hgbot Note Added: 0091923
2016-11-30 17:26 hgbot Checkin
2016-11-30 17:26 hgbot Note Added: 0091940
2016-12-01 09:04 hgbot Checkin
2016-12-01 09:04 hgbot Note Added: 0091945
2016-12-03 01:38 mtaal Note Added: 0092062
2016-12-03 01:38 mtaal Status resolved => new
2016-12-03 01:38 mtaal Resolution fixed => open
2016-12-06 20:20 hgbot Checkin
2016-12-06 20:20 hgbot Note Added: 0092147
2016-12-06 20:23 AugustoMauch Status new => scheduled
2016-12-06 20:23 AugustoMauch Status scheduled => resolved
2016-12-06 20:23 AugustoMauch Resolution open => fixed
2016-12-07 22:36 mtaal Note Added: 0092204
2016-12-07 22:36 mtaal Status resolved => closed
2016-12-07 22:36 mtaal Fixed in Version => RR17Q1

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker