Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0034555
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2016-11-17 12:182016-11-30 17:24
ReportergorkaionView Statuspublic 
Assigned Toranjith_qualiantech_com 
PriorityhighResolutionfixedFixed in VersionRR17Q1
StatusclosedFix in branchFixed in SCM revision387ed12b4721
ProjectionnoneETAnoneTarget Versionpi
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0034555: [SERQA 2086] transformMessage() of ExternalOrderLoader executed several times on each request

DescriptionThe transformMessage() method is the one in charge of parsing the incoming JSON to be transformed to the OrderLoader format. This method is called in 3 different methods of the ExternalOrderLoader so the method can be executed up to 3 different times.

This behavior has a performance impact as it is processing 3 times the same information and can cause errors in the ExternalOrderLoader. For example if it is set a warehouse in the order line the second execution of the tranformMessage fails.
Steps To ReproducePut debug log and check how the transformMessage is called several times.

Add the warehouse property to a order line and check that the process fails.
Proposed SolutionCall the transformMessage() method only once in the code by removing the calls in the exec() methods. Attached a diff.
TagsNo tags attached.
Attached Filesdiff file icon externalOrderLoader.diff [^] (816 bytes) 2016-11-17 12:18 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0091825)
hgbot (developer)
2016-11-25 11:05

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 387ed12b4721ead00467e58ecd686ae29f8550f4
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Nov 25 15:34:43 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/387ed12b4721ead00467e58ecd686ae29f8550f4 [^]

Fixes issue 34555 : Removing unuseful transformMessage call in ExternalOrderLoader

* transformMessage fn previously called in OrderLoader. By Calling again in ExternalOrderLoader, its throwing Exceptions

---
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
---

- Issue History
Date Modified Username Field Change
2016-11-17 12:18 gorkaion New Issue
2016-11-17 12:18 gorkaion Assigned To => Retail
2016-11-17 12:18 gorkaion File Added: externalOrderLoader.diff
2016-11-17 12:18 gorkaion Triggers an Emergency Pack => No
2016-11-21 13:11 gorkaion Resolution time => 1480546800
2016-11-21 13:11 gorkaion Summary transformMessage() of ExternalOrderLoader executed several times on each request => [SERQA 2086] transformMessage() of ExternalOrderLoader executed several times on each request
2016-11-23 13:55 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2016-11-23 13:55 ranjith_qualiantech_com Status new => scheduled
2016-11-25 11:05 hgbot Checkin
2016-11-25 11:05 hgbot Note Added: 0091825
2016-11-25 11:05 hgbot Status scheduled => resolved
2016-11-25 11:05 hgbot Resolution open => fixed
2016-11-25 11:05 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/387ed12b4721ead00467e58ecd686ae29f8550f4 [^]
2016-11-30 17:24 marvintm Review Assigned To => marvintm
2016-11-30 17:24 marvintm Status resolved => closed
2016-11-30 17:24 marvintm Fixed in Version => RR17Q1

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker