Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0034520
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Retail Modules] Web POSmajoralways2016-11-15 10:162016-12-16 08:40
Reporterjorge-garciaView Statuspublic 
Assigned Tojorge-garcia 
PrioritynormalResolutionfixedFixed in VersionRR16Q4
StatusclosedFix in branchFixed in SCM revision0c14b7540dfa
ProjectionnoneETAnoneTarget VersionRR16Q4
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression levelProduction - Confirmed Stable
Regression date2015-09-12
Regression introduced in releaseRR15Q4
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1ba7e9aa75f69ac696431167c9fbb26cb0e55dbf [^]
Triggers an Emergency PackNo
Summary

0034520: [Performance] Discounts calculation is slower when the user increase the number of lines of the receipt

DescriptionDiscounts calculation is more slower when the user increase the number of lines of the receipt
Steps To Reproduce1) Login in the WebPOS
2) Start adding products in the ticket
3) Check the calculation of the receipt became more slower
4) Notice, after the tenth line in the receipt, the calculation takes several seconds.
5) From the twentieth line, the calculation could take twenty or thirty seconds.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks defect 0034517 closedjorge-garcia [Performance] Discounts calculation is slower when the user increase the number of lines of the receipt 

-  Notes
(0092028)
hgbot (developer)
2016-12-02 12:53

 Repository: retail/backports/3.0RR16Q4/pi-mobile
Changeset: 9d5184fe57206f0ccc07b07681a273ea3b0db3c8
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Fri Dec 02 12:52:32 2016 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR16Q4/pi-mobile/rev/9d5184fe57206f0ccc07b07681a273ea3b0db3c8 [^]

Related to issue 34520: [Performance] Discounts calculation is slower when the
user increase the number of lines of the receipt

Delete test I32585_ReturnLineAndApplyDiscretionaryPromo.java because is
testing something that it’s not ok.

---
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I32585_ReturnLineAndApplyDiscretionaryPromo.java
---
(0092029)
hgbot (developer)
2016-12-02 12:53

 Repository: retail/backports/3.0RR16Q4/org.openbravo.retail.posterminal
Changeset: 0c14b7540dfa2c0ad8c2a8b784669cf1c8e0233f
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Fri Dec 02 12:51:07 2016 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR16Q4/org.openbravo.retail.posterminal/rev/0c14b7540dfa2c0ad8c2a8b784669cf1c8e0233f [^]

Fixed issue 34520: [Performance] Discounts calculation is slower when the
user increase the number of lines of the receipt

The problem with this issue is that the functionality of findUsingCache was
never use, because the parameter to stablish the initial date to take a
promotion was always changing with the value of the actual date witch was
a datetime value.

In the backend, it’s not possible to define a promotion neither the starting
date nor ending date fields with a date including hours, minutes and seconds.

The solution is to parse the date to sue only dates without time for the query
criteria.

---
M web/org.openbravo.retail.posterminal/js/model/executor.js
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0092193)
hgbot (developer)
2016-12-07 14:08

 Repository: retail/backports/3.0RR16Q4/org.openbravo.retail.posterminal
Changeset: c3a8612c0366e9322d8d22147910437248baa748
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Wed Dec 07 14:08:38 2016 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR16Q4/org.openbravo.retail.posterminal/rev/c3a8612c0366e9322d8d22147910437248baa748 [^]

Related to issue 34520. Date will always be correct, before it would sometimes return a wrong date due to the toISOString call returning the date in UTC timezone.

---
M web/org.openbravo.retail.posterminal/js/model/executor.js
---
(0092442)
hgbot (developer)
2016-12-16 08:40

 Repository: tools/automation/pi-mobile
Changeset: 9d5184fe57206f0ccc07b07681a273ea3b0db3c8
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Fri Dec 02 12:52:32 2016 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/9d5184fe57206f0ccc07b07681a273ea3b0db3c8 [^]

Related to issue 34520: [Performance] Discounts calculation is slower when the
user increase the number of lines of the receipt

Delete test I32585_ReturnLineAndApplyDiscretionaryPromo.java because is
testing something that it’s not ok.

---
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I32585_ReturnLineAndApplyDiscretionaryPromo.java
---

- Issue History
Date Modified Username Field Change
2016-11-15 10:26 jorge-garcia Type defect => backport
2016-11-15 10:26 jorge-garcia Target Version => RR16Q4
2016-12-02 12:53 hgbot Checkin
2016-12-02 12:53 hgbot Note Added: 0092028
2016-12-02 12:53 hgbot Checkin
2016-12-02 12:53 hgbot Note Added: 0092029
2016-12-02 12:53 hgbot Status scheduled => resolved
2016-12-02 12:53 hgbot Resolution open => fixed
2016-12-02 12:53 hgbot Fixed in SCM revision => http://code.openbravo.com/retail/backports/3.0RR16Q4/org.openbravo.retail.posterminal/rev/0c14b7540dfa2c0ad8c2a8b784669cf1c8e0233f [^]
2016-12-07 14:08 hgbot Checkin
2016-12-07 14:08 hgbot Note Added: 0092193
2016-12-09 13:56 marvintm Review Assigned To => marvintm
2016-12-09 13:56 marvintm Status resolved => closed
2016-12-09 13:56 marvintm Fixed in Version => RR16Q4
2016-12-16 08:40 hgbot Checkin
2016-12-16 08:40 hgbot Note Added: 0092442

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker