Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0034494
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajorhave not tried2016-11-14 14:102017-02-09 12:02
ReporteradrianromeroView Statuspublic 
Assigned Toadrianromero 
PriorityurgentResolutionfixedFixed in VersionRR17Q1
StatusclosedFix in branchFixed in SCM revision25320cf9f9b9
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0034494: Category Tree performance issue

DescriptionThe Category tree in Web POS is very slow when expanding a parent category in a tree that has a high number of categories to display.

The technical problem is that the list component used when expanding a parent category, each insertion in the tree of each son category fires a full rebuild of the tree.
Steps To Reproduce* Create a category tree with a high number of parent categories and son categories.
* Login in to webPOS and go to the search tab
* Open the category tree dialog
* Tap on a category with a high number of son categories and that is not the last category listed. Observe it takes minutes to expand the tree.
Proposed SolutionSee attached patch
TagsNo tags attached.
Attached Filespatch file icon CategoryTreePerformanceIssue.patch [^] (1,430 bytes) 2016-11-15 09:20 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
has duplicate defect 0034337 closedranjith_qualiantech_com Performance issue in Category Tree dialog trying to show subcategories, more than 100. 

-  Notes
(0091529)
adrianromero (manager)
2016-11-15 09:24

The proposed patch modifies how to insert into the tree list the set of son categories. this way instead of using the "add" method that internally fires one rebuild of the whole tree for each element added it just rebuilds the tree one time for all elements added.

It has been explored also to modify internally the behaviour of the tree in order to not to rebuild the whole tree when adding one element in the middle of the tree but we have not found the way to do it properly in Enyo. Enyo only allows to create components at the end of a parent.
(0091531)
adrianromero (manager)
2016-11-15 09:26

Attached patch successfully passes try: http://ci.openbravo.com/view/try-retail/job/try-ret-init/6273/ [^]
(0091620)
hgbot (developer)
2016-11-17 10:04

Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 8fccd642dda61d9a4af31b6e1666f6de7d0efa76
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Mon Nov 14 14:48:50 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/8fccd642dda61d9a4af31b6e1666f6de7d0efa76 [^]

Fixes issue 0034494: Category Tree performance issue
* Insert component in createComponent() enyo function

---
M web/org.openbravo.mobile.core/source/component/ob-scrollabletable.js
---
(0091631)
hgbot (developer)
2016-11-17 13:27

Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 25320cf9f9b9503f3fff4ed10fe2cd2693206145
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Thu Nov 17 13:26:52 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/25320cf9f9b9503f3fff4ed10fe2cd2693206145 [^]

Fixes issue 0034494: Category Tree performance issue
* Inserts all components at a time inside the list instead of one by one

---
M web/org.openbravo.mobile.core/source/retail/component/ob-retail-product-browser.js
---
(0091632)
adrianromero (manager)
2016-11-17 13:28

first changeset backed out: https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/a676b64319c1 [^]
(0094172)
hgbot (developer)
2017-02-09 12:02

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: a7c1c0191cd36a2ae230d1f6375b9e4c4b26b189
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Thu Feb 09 12:01:07 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a7c1c0191cd36a2ae230d1f6375b9e4c4b26b189 [^]

Related to issue 0034494: Category Tree performance issue
This function allows automated tests do check whether a node is expanded or not

---
M web/org.openbravo.retail.posterminal/js/components/rendercategory.js
---

- Issue History
Date Modified Username Field Change
2016-11-14 14:10 adrianromero New Issue
2016-11-14 14:10 adrianromero Assigned To => Retail
2016-11-14 14:10 adrianromero Triggers an Emergency Pack => No
2016-11-15 09:20 adrianromero File Added: CategoryTreePerformanceIssue.patch
2016-11-15 09:24 adrianromero Note Added: 0091529
2016-11-15 09:26 adrianromero Note Added: 0091531
2016-11-15 09:27 adrianromero Review Assigned To => marvintm
2016-11-17 10:04 hgbot Checkin
2016-11-17 10:04 hgbot Note Added: 0091620
2016-11-17 10:04 hgbot Status new => resolved
2016-11-17 10:04 hgbot Resolution open => fixed
2016-11-17 10:04 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/8fccd642dda61d9a4af31b6e1666f6de7d0efa76 [^]
2016-11-17 13:27 hgbot Checkin
2016-11-17 13:27 hgbot Note Added: 0091631
2016-11-17 13:27 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/8fccd642dda61d9a4af31b6e1666f6de7d0efa76 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/25320cf9f9b9503f3fff4ed10fe2cd2693206145 [^]
2016-11-17 13:28 adrianromero Note Added: 0091632
2016-11-23 13:47 marvintm Status resolved => closed
2016-11-23 13:47 marvintm Fixed in Version => RR17Q1
2016-11-23 13:48 marvintm Assigned To Retail => adrianromero
2017-01-18 11:46 ranjith_qualiantech_com Relationship added has duplicate 0034337
2017-02-09 12:02 hgbot Checkin
2017-02-09 12:04 hgbot Note Added: 0094172


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker