Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0034494 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Retail Modules] Web POS | major | have not tried | 2016-11-14 14:10 | 2017-02-09 12:02 | |||
Reporter | adrianromero | View Status | public | |||||
Assigned To | adrianromero | |||||||
Priority | urgent | Resolution | fixed | Fixed in Version | RR17Q1 | |||
Status | closed | Fix in branch | Fixed in SCM revision | 25320cf9f9b9 | ||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Merge Request Status | ||||||||
Review Assigned To | marvintm | |||||||
OBNetwork customer | No | |||||||
Support ticket | ||||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0034494: Category Tree performance issue | |||||||
Description | The Category tree in Web POS is very slow when expanding a parent category in a tree that has a high number of categories to display. The technical problem is that the list component used when expanding a parent category, each insertion in the tree of each son category fires a full rebuild of the tree. | |||||||
Steps To Reproduce | * Create a category tree with a high number of parent categories and son categories. * Login in to webPOS and go to the search tab * Open the category tree dialog * Tap on a category with a high number of son categories and that is not the last category listed. Observe it takes minutes to expand the tree. | |||||||
Proposed Solution | See attached patch | |||||||
Tags | No tags attached. | |||||||
Attached Files | ![]() | |||||||
![]() |
||||||||
|
![]() |
|
(0091529) adrianromero (viewer) 2016-11-15 09:24 |
The proposed patch modifies how to insert into the tree list the set of son categories. this way instead of using the "add" method that internally fires one rebuild of the whole tree for each element added it just rebuilds the tree one time for all elements added. It has been explored also to modify internally the behaviour of the tree in order to not to rebuild the whole tree when adding one element in the middle of the tree but we have not found the way to do it properly in Enyo. Enyo only allows to create components at the end of a parent. |
(0091531) adrianromero (viewer) 2016-11-15 09:26 |
Attached patch successfully passes try: http://ci.openbravo.com/view/try-retail/job/try-ret-init/6273/ [^] |
(0091620) hgbot (developer) 2016-11-17 10:04 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: 8fccd642dda61d9a4af31b6e1666f6de7d0efa76 Author: Adrián Romero <adrianromero <at> openbravo.com> Date: Mon Nov 14 14:48:50 2016 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/8fccd642dda61d9a4af31b6e1666f6de7d0efa76 [^] Fixes issue 0034494: Category Tree performance issue * Insert component in createComponent() enyo function --- M web/org.openbravo.mobile.core/source/component/ob-scrollabletable.js --- |
(0091631) hgbot (developer) 2016-11-17 13:27 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: 25320cf9f9b9503f3fff4ed10fe2cd2693206145 Author: Adrián Romero <adrianromero <at> openbravo.com> Date: Thu Nov 17 13:26:52 2016 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/25320cf9f9b9503f3fff4ed10fe2cd2693206145 [^] Fixes issue 0034494: Category Tree performance issue * Inserts all components at a time inside the list instead of one by one --- M web/org.openbravo.mobile.core/source/retail/component/ob-retail-product-browser.js --- |
(0091632) adrianromero (viewer) 2016-11-17 13:28 |
first changeset backed out: https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/a676b64319c1 [^] |
(0094172) hgbot (developer) 2017-02-09 12:02 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: a7c1c0191cd36a2ae230d1f6375b9e4c4b26b189 Author: Adrián Romero <adrianromero <at> openbravo.com> Date: Thu Feb 09 12:01:07 2017 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a7c1c0191cd36a2ae230d1f6375b9e4c4b26b189 [^] Related to issue 0034494: Category Tree performance issue This function allows automated tests do check whether a node is expanded or not --- M web/org.openbravo.retail.posterminal/js/components/rendercategory.js --- |
![]() |
|||
Date Modified | Username | Field | Change |
2016-11-14 14:10 | adrianromero | New Issue | |
2016-11-14 14:10 | adrianromero | Assigned To | => Retail |
2016-11-14 14:10 | adrianromero | OBNetwork customer | => No |
2016-11-14 14:10 | adrianromero | Triggers an Emergency Pack | => No |
2016-11-15 09:20 | adrianromero | File Added: CategoryTreePerformanceIssue.patch | |
2016-11-15 09:24 | adrianromero | Note Added: 0091529 | |
2016-11-15 09:26 | adrianromero | Note Added: 0091531 | |
2016-11-15 09:27 | adrianromero | Review Assigned To | => marvintm |
2016-11-17 10:04 | hgbot | Checkin | |
2016-11-17 10:04 | hgbot | Note Added: 0091620 | |
2016-11-17 10:04 | hgbot | Status | new => resolved |
2016-11-17 10:04 | hgbot | Resolution | open => fixed |
2016-11-17 10:04 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/8fccd642dda61d9a4af31b6e1666f6de7d0efa76 [^] |
2016-11-17 13:27 | hgbot | Checkin | |
2016-11-17 13:27 | hgbot | Note Added: 0091631 | |
2016-11-17 13:27 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/8fccd642dda61d9a4af31b6e1666f6de7d0efa76 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/25320cf9f9b9503f3fff4ed10fe2cd2693206145 [^] |
2016-11-17 13:28 | adrianromero | Note Added: 0091632 | |
2016-11-23 13:47 | marvintm | Status | resolved => closed |
2016-11-23 13:47 | marvintm | Fixed in Version | => RR17Q1 |
2016-11-23 13:48 | marvintm | Assigned To | Retail => adrianromero |
2017-01-18 11:46 | ranjith_qualiantech_com | Relationship added | has duplicate 0034337 |
2017-02-09 12:02 | hgbot | Checkin | |
2017-02-09 12:04 | hgbot | Note Added: 0094172 |
Copyright © 2000 - 2009 MantisBT Group |