Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0034479
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] StoreServerminorhave not tried2016-11-11 17:252016-11-15 11:20
ReporterAugustoMauchView Statuspublic 
Assigned ToAugustoMauch 
PrioritynormalResolutionfixedFixed in VersionRR17Q1
StatusclosedFix in branchFixed in SCM revisionc8499556b98e
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomtaal
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0034479: The pingservice is not always properly fetched

DescriptionThe following code is used to obtain the ping service in :

    String pingService = srv.getPingservice() != null ? srv.getPingservice()
        : MobileServerUtils.OBWSPATH + MobileServerStatusInformation.class.getName();

Usually the srv.getPingservice() returns either null if it is not defined or an String representing the ping service, but sometimes it returns an empty string. If this happens, then the pingService variable contains an empty String, instead of the default ping service (MobileServerStatusInformation.class.getName()).
Steps To ReproduceI have not been able to reproduce it, but I have seen it reproduced in environments when this caused the store server offline->online transition to break.

Proposed SolutionUse !StringUtils.isBlank(srv.getPingservice()) instead of a null check to cover the case when the getPingservice method returns an empty string
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0091407)
hgbot (developer)
2016-11-11 17:54

Repository: erp/pmods/org.openbravo.mobile.core
Changeset: c8499556b98e606775f9e204a7f4c39a7e8c99bf
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Fri Nov 11 17:53:53 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/c8499556b98e606775f9e204a7f4c39a7e8c99bf [^]

Fixes issue 34479: Ping service is properly set even if it is an empty String

Before this fix, if the srv.getPingservice() method returned an empty string the ping service was not properly set. Now StringUtils.isBlank is used to check if the ping service is defined, so it covers both it being null and it being an empty String.

---
M src/org/openbravo/mobile/core/servercontroller/MobileMainServerCheck.java
M src/org/openbravo/mobile/core/servercontroller/ServerStateBackground.java
---
(0091549)
mtaal (manager)
2016-11-15 11:20

Reviewed

- Issue History
Date Modified Username Field Change
2016-11-11 17:25 AugustoMauch New Issue
2016-11-11 17:25 AugustoMauch Assigned To => AugustoMauch
2016-11-11 17:25 AugustoMauch Triggers an Emergency Pack => No
2016-11-11 17:54 AugustoMauch Review Assigned To => mtaal
2016-11-11 17:54 hgbot Checkin
2016-11-11 17:54 hgbot Note Added: 0091407
2016-11-11 17:54 hgbot Status new => resolved
2016-11-11 17:54 hgbot Resolution open => fixed
2016-11-11 17:54 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/c8499556b98e606775f9e204a7f4c39a7e8c99bf [^]
2016-11-15 11:20 mtaal Note Added: 0091549
2016-11-15 11:20 mtaal Status resolved => closed
2016-11-15 11:20 mtaal Fixed in Version => RR17Q1


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker