Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0034439
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminoralways2016-11-09 09:442016-12-16 18:38
ReporterJONHMView Statuspublic 
Assigned Toalostale 
PriorityimmediateResolutionfixedFixed in Version3.0PR17Q1
StatusclosedFix in branchFixed in SCM revisionc767cfbd08b6
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Review Assigned Tocaristu
Web browser
ModulesCore
Regression levelProduction - QA Approved
Regression date2016-04-18
Regression introduced in release3.0PR16Q3
Regression introduced by commithttp://code.openbravo.com/erp/devel/pi/rev/82f27ac1b1497b3a82646b140ab1b6e048f2b766 [^]
Triggers an Emergency PackNo
Summary

0034439: can't add attachment to Invoices after print and attach

DescriptionIf we try to add an attachment in [Purchase Invoice] window when there is already an attachment included, it shows an error "freemarker.template.TemplateModelException".
Steps To ReproduceIn an instance with no modules in development

1) Open [Purchase Invoice] window and select some record
2) Press button "Print Record" and press "Yes" to attach the document
3) Expand attachments section and press "Add" to add a new document
---> It shows the error
Caused by: freemarker.template.TemplateModelException: get(title) failed on instance of org.openbravo.client.application.window.OBViewParameterHandler$OBViewParameter
  ...
Caused by: org.hibernate.LazyInitializationException: could not initialize proxy - no Session
    at org.hibernate.proxy.AbstractLazyInitializer.initialize(AbstractLazyInitializer.java:167)
    at org.hibernate.proxy.AbstractLazyInitializer.getImplementation(AbstractLazyInitializer.java:215)
    at org.hibernate.proxy.pojo.javassist.JavassistLazyInitializer.invoke(JavassistLazyInitializer.java:190)
    at org.openbravo.model.ad.ui.Element_$$_javassist_10.getADElementTrlList(Element_$$_javassist_10.java)
    at org.openbravo.client.application.window.OBViewUtil.getParameterTitle(OBViewUtil.java:105)
    at org.openbravo.client.application.window.OBViewParameterHandler$OBViewParameter.getTitle(OBViewParameterHandler.java:241)
    ... 85 more

Note this happens when 2 is the first action in the current session regarding attachments for that window, in case add attachment is executed before, there is no issue.
Proposed SolutionWorkaround: if in this situation, log out and log in to be able to add new attachments.
TagsNo tags attached.
Attached Filespng file icon Screenshot from 2016-11-09 09:43:35.png [^] (102,545 bytes) 2016-11-09 09:44

- Relationships Relation Graph ] Dependency Graph ]
depends on backport 00344543.0PR16Q4 closedalostale can't add attachment to Invoices after print and attach 
depends on backport 00344553.0PR16Q3.3 closedalostale can't add attachment to Invoices after print and attach 
caused by feature request 0029771 closednaiaramartinez different attachment method infrastructure 

-  Notes
(0091293)
hgbot (developer)
2016-11-09 16:23

Repository: erp/devel/pi
Changeset: 43477851c1be9f9cd4af9036c4f5958466823904
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Nov 09 16:14:06 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/43477851c1be9f9cd4af9036c4f5958466823904 [^]

fixed bug 34439: can't add attachment to Invoices after print and attach

  When trying to add a new attachemnt just after attaching a printed document,
  a LazyInitializationException was thrown because ADCS cache parameter object
  was partially initialized. Programmatic attachement API initialized the parameters
  but not their translation lists.

  Fixed by initializating translation lists for parameters whenever it is added
  to ADCS.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ApplicationDictionaryCachedStructures.java
M src/org/openbravo/dal/security/AcctSchemaStructureProvider.java
M src/org/openbravo/erpCommon/utility/SystemInfo.java
---
(0091294)
hgbot (developer)
2016-11-09 16:34

Repository: erp/devel/pi
Changeset: ad142c9e8d5cace7482a982a8226a13f9a3b1cf5
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Nov 09 16:31:05 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/ad142c9e8d5cace7482a982a8226a13f9a3b1cf5 [^]

related to bug 34439
Backed out changeset 43477851c1be: it contained unwanted changes

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ApplicationDictionaryCachedStructures.java
M src/org/openbravo/dal/security/AcctSchemaStructureProvider.java
M src/org/openbravo/erpCommon/utility/SystemInfo.java
---
(0091295)
hgbot (developer)
2016-11-09 16:34

Repository: erp/devel/pi
Changeset: c767cfbd08b601bc763a4b1e07eff9cbf6b7e7eb
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Nov 09 16:33:22 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/c767cfbd08b601bc763a4b1e07eff9cbf6b7e7eb [^]

fixed bug 34439: can't add attachment to Invoices after print and attach

  When trying to add a new attachemnt just after attaching a printed document,
  a LazyInitializationException was thrown because ADCS cache parameter object
  was partially initialized. Programmatic attachement API initialized the parameters
  but not their translation lists.

  Fixed by initializating translation lists for parameters whenever it is added
  to ADCS.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ApplicationDictionaryCachedStructures.java
---
(0091314)
hgbot (developer)
2016-11-10 09:42

Repository: erp/devel/pi
Changeset: e11aa29da8c9cae5b51a20d4c6cd9c97185267a4
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Nov 10 09:42:06 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/e11aa29da8c9cae5b51a20d4c6cd9c97185267a4 [^]

related to bug 34439: fixed the problem for sales windows

  Paramter translation for sales windows is obtained directly from parameter def
  instead of from element. This was not initialized in cached ADCS.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ApplicationDictionaryCachedStructures.java
---
(0091317)
caristu (developer)
2016-11-10 09:53

Code review + testing OK: working on both sales and purchase flows
(0092604)
hudsonbot (developer)
2016-12-16 18:38

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test
(0092605)
hudsonbot (developer)
2016-12-16 18:38

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test
(0092606)
hudsonbot (developer)
2016-12-16 18:38

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test
(0092608)
hudsonbot (developer)
2016-12-16 18:38

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2016-11-09 09:44 JONHM New Issue
2016-11-09 09:44 JONHM Assigned To => platform
2016-11-09 09:44 JONHM File Added: Screenshot from 2016-11-09 09:43:35.png
2016-11-09 09:44 JONHM Modules => Core
2016-11-09 09:44 JONHM Resolution time => 1481497200
2016-11-09 09:44 JONHM Triggers an Emergency Pack => No
2016-11-09 13:50 jfrances Issue Monitored: jfrances
2016-11-09 15:50 alostale Summary Exception when adding an attachment in [Purchase Invoice] window => can't add attachment to Invoices after print and attach
2016-11-09 15:50 alostale Steps to Reproduce Updated View Revisions
2016-11-09 15:51 alostale Priority high => immediate
2016-11-09 15:51 alostale Severity major => minor
2016-11-09 15:51 alostale Steps to Reproduce Updated View Revisions
2016-11-09 15:51 alostale Proposed Solution updated
2016-11-09 15:52 alostale Assigned To platform => alostale
2016-11-09 15:53 alostale Relationship added caused by 0029771
2016-11-09 15:53 alostale Regression level => Production - QA Approved
2016-11-09 15:53 alostale Regression date => 2016-04-18
2016-11-09 15:53 alostale Regression introduced in release => 3.0PR16Q3
2016-11-09 15:53 alostale Regression introduced by commit => http://code.openbravo.com/erp/devel/pi/rev/82f27ac1b1497b3a82646b140ab1b6e048f2b766 [^]
2016-11-09 15:54 alostale Status new => scheduled
2016-11-09 16:11 alostale Review Assigned To => caristu
2016-11-09 16:23 hgbot Checkin
2016-11-09 16:23 hgbot Note Added: 0091293
2016-11-09 16:23 hgbot Status scheduled => resolved
2016-11-09 16:23 hgbot Resolution open => fixed
2016-11-09 16:23 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/43477851c1be9f9cd4af9036c4f5958466823904 [^]
2016-11-09 16:34 hgbot Checkin
2016-11-09 16:34 hgbot Note Added: 0091294
2016-11-09 16:34 hgbot Checkin
2016-11-09 16:34 hgbot Note Added: 0091295
2016-11-09 16:34 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/43477851c1be9f9cd4af9036c4f5958466823904 [^] => http://code.openbravo.com/erp/devel/pi/rev/c767cfbd08b601bc763a4b1e07eff9cbf6b7e7eb [^]
2016-11-10 09:42 hgbot Checkin
2016-11-10 09:42 hgbot Note Added: 0091314
2016-11-10 09:53 caristu Note Added: 0091317
2016-11-10 09:53 caristu Status resolved => closed
2016-11-10 09:53 caristu Fixed in Version => 3.0PR17Q1
2016-12-16 18:38 hudsonbot Checkin
2016-12-16 18:38 hudsonbot Note Added: 0092604
2016-12-16 18:38 hudsonbot Checkin
2016-12-16 18:38 hudsonbot Note Added: 0092605
2016-12-16 18:38 hudsonbot Checkin
2016-12-16 18:38 hudsonbot Note Added: 0092606
2016-12-16 18:38 hudsonbot Checkin
2016-12-16 18:38 hudsonbot Note Added: 0092608


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker