Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0034426
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Retail Modules] Web POSminoralways2016-11-04 11:122016-12-19 06:24
Reporterjorge-garciaView Statuspublic 
Assigned Tomario_castello 
PrioritynormalResolutionfixedFixed in VersionRR16Q4
StatusclosedFix in branchFixed in SCM revisionf67e5733625d
ProjectionnoneETAnoneTarget VersionRR16Q4
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date2016-09-19
Regression introduced in releaseRR16Q2.3
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/200182f3db29 [^]
Triggers an Emergency PackNo
Summary

0034426: Login window is loaded even if the terminal does not exist in the database

DescriptionLogin window is loaded even if the terminal does not exist in the database.
Steps To ReproduceTry to login here

http://localhost:8080/openbravo/web/org.openbravo.retail.posterminal/?terminal=PEPE#login [^]

Wrong: The login window is rendered.
Solution: The login window should not be rendered and a popup should be shown indication the terminal name doesn't exist (check screenshot attached).

This is happening since 16Q2.3.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks defect 0034396 closedmario_castello Login window is loaded even if the terminal does not exist in the database 

-  Notes
(0092127)
hgbot (developer)
2016-12-06 10:54

 Repository: retail/backports/3.0RR16Q4/org.openbravo.retail.posterminal
Changeset: 98b592247d5ab064a1971328989b2d0e37dad1ff
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Fri Nov 04 16:37:03 2016 -0600
URL: http://code.openbravo.com/retail/backports/3.0RR16Q4/org.openbravo.retail.posterminal/rev/98b592247d5ab064a1971328989b2d0e37dad1ff [^]

Fixes issue 34426, backport of issue 34396: Added validation for the terminal list to prevent throwed an unhandled exception.

When the terminal not exist the terminalList are empty and the process are throwing an exception when try to get an object from an empty list.

---
M src/org/openbravo/retail/posterminal/LoginUtilsServlet.java
---
(0092254)
hgbot (developer)
2016-12-09 15:19

 Repository: retail/backports/3.0RR16Q4/pi-mobile
Changeset: f67e5733625d5b30df59b2c4fa5c99e732df9d05
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Wed Dec 07 10:42:20 2016 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR16Q4/pi-mobile/rev/f67e5733625d5b30df59b2c4fa5c99e732df9d05 [^]

Fixes issue 34426, backport of issue 34396: Added test

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/loginout/I34396_VerifyLoginNotExitsTerminal.java
---
(0092446)
hgbot (developer)
2016-12-16 08:40

 Repository: tools/automation/pi-mobile
Changeset: f67e5733625d5b30df59b2c4fa5c99e732df9d05
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Wed Dec 07 10:42:20 2016 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/f67e5733625d5b30df59b2c4fa5c99e732df9d05 [^]

Fixes issue 34426, backport of issue 34396: Added test

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/loginout/I34396_VerifyLoginNotExitsTerminal.java
---
(0092745)
priyam (administrator)
2016-12-19 06:24

 Closing as merge of pi-mobiles Q4 tag updated the issues.

- Issue History
Date Modified Username Field Change
2016-11-08 15:42 mario_castello Type defect => backport
2016-11-08 15:42 mario_castello Target Version => RR16Q4
2016-12-06 10:54 hgbot Checkin
2016-12-06 10:54 hgbot Note Added: 0092127
2016-12-06 10:54 hgbot Status scheduled => resolved
2016-12-06 10:54 hgbot Resolution open => fixed
2016-12-06 10:54 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/832ae441d73b3fcbc628d1a28ee321f5ae62010c [^] => http://code.openbravo.com/retail/backports/3.0RR16Q4/org.openbravo.retail.posterminal/rev/98b592247d5ab064a1971328989b2d0e37dad1ff [^]
2016-12-09 13:27 marvintm Review Assigned To => marvintm
2016-12-09 13:27 marvintm Status resolved => closed
2016-12-09 13:27 marvintm Fixed in Version => RR16Q4
2016-12-09 15:19 hgbot Checkin
2016-12-09 15:19 hgbot Note Added: 0092254
2016-12-09 15:19 hgbot Status closed => resolved
2016-12-09 15:19 hgbot Fixed in SCM revision http://code.openbravo.com/retail/backports/3.0RR16Q4/org.openbravo.retail.posterminal/rev/98b592247d5ab064a1971328989b2d0e37dad1ff [^] => http://code.openbravo.com/retail/backports/3.0RR16Q4/pi-mobile/rev/f67e5733625d5b30df59b2c4fa5c99e732df9d05 [^]
2016-12-09 15:20 marvintm Status resolved => closed
2016-12-16 08:40 hgbot Checkin
2016-12-16 08:40 hgbot Note Added: 0092446
2016-12-16 08:40 hgbot Status closed => resolved
2016-12-16 08:40 hgbot Fixed in SCM revision http://code.openbravo.com/retail/backports/3.0RR16Q4/pi-mobile/rev/f67e5733625d5b30df59b2c4fa5c99e732df9d05 [^] => http://code.openbravo.com/tools/automation/pi-mobile/rev/f67e5733625d5b30df59b2c4fa5c99e732df9d05 [^]
2016-12-19 06:24 priyam Note Added: 0092745
2016-12-19 06:24 priyam Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker