Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0034405 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | major | always | 2016-11-07 10:25 | 2016-12-16 18:38 | |||
| Reporter | JONHM | View Status | public | |||||
| Assigned To | NaroaIriarte | |||||||
| Priority | high | Resolution | fixed | Fixed in Version | 3.0PR17Q1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 9bfd8bde32b2 | ||||
| Projection | none | ETA | none | Target Version | pi | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | alostale | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0034405: 'Manage Variants' process returns no items to show when filtering | |||||||
| Description | When we run 'Manage Variants' process and filter and selecting some variant, when we delete the filter filed to select another one, the process fails and shows 'no items to show'. | |||||||
| Steps To Reproduce | 1) Create a 'product Characteristic' marked as 'Variant'. 2) Add some values to that created characteristic. 3) Create a new Product and check 'Is Generic' checkbox as true. 4) Add the Characteristic by navigating to the product tab, also marked as 'Variant'. 5) Run process 'Generate Variants'. 6) Now run 'Manage Variants', a pick&execute window is opened. 7) Filter by one of those variants (whatever0) and select it. 8) Now delete that filter text. --> It shows message 'No items to show'. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||||||||||||||||
|
||||||||||||||||||||||
 Relationships |
|
Notes |
|
|
(0091541) hgbot (developer) 2016-11-15 10:58 |
Repository: erp/devel/pi Changeset: 9bfd8bde32b287625174384e8946c72f9aa06f5b Author: Naroa Iriarte <naroa.iriarte <at> openbravo.com> Date: Fri Nov 11 10:10:29 2016 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/9bfd8bde32b287625174384e8946c72f9aa06f5b [^] Fixed issue 34405: The Manage Variants filter was not working fine. If the filter was used, after that a record was selected and after that the filter was cleaned up, the "no items to show" message was shown instead of showing all the records. The problem was that the "ManageVariantsDS" manual datasource was not capable of managing the criteria: "criteria:{"fieldName":"id","operator":"notNull"}" which is the criteria that must return every record. The problem was in this code line: "value = criteria.getString("value")" because the creiteria has not value, it only has fieldName and operator. It was throwing an exception which was not being correctly handled in the catch. This problem has been solved also, by properly handling the exception by showing log. The first problem has been solved by processing the concrete criteria properly. If this criteria is found, it means that every record must be shown, so it continues with doing nothing. There was a another problem that has been solved and it is that the searchKey and the nameFilters were acting as a "Contains" filter instead of like as an "iContains". This has been fixed by changing the "contains" method of StringUtils by the "containsIgnoreCase". --- M src/org/openbravo/materialmgmt/ManageVariantsDS.java --- |
|
(0091804) alostale (manager) 2016-11-25 08:52 |
code reviewed + tested |
|
(0092627) hudsonbot (developer) 2016-12-16 18:38 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2016-11-07 10:25 | JONHM | New Issue | |
| 2016-11-07 10:25 | JONHM | Assigned To | => platform |
| 2016-11-07 10:25 | JONHM | Modules | => Core |
| 2016-11-07 10:25 | JONHM | Triggers an Emergency Pack | => No |
| 2016-11-08 11:23 | JONHM | Resolution time | => 1479682800 |
| 2016-11-08 11:23 | JONHM | Severity | minor => major |
| 2016-11-10 12:41 | NaroaIriarte | Assigned To | platform => NaroaIriarte |
| 2016-11-10 12:41 | NaroaIriarte | Status | new => acknowledged |
| 2016-11-10 12:41 | NaroaIriarte | Status | acknowledged => scheduled |
| 2016-11-11 10:27 | NaroaIriarte | Relationship added | related to 0034469 |
| 2016-11-11 10:56 | NaroaIriarte | Relationship added | related to 0034470 |
| 2016-11-15 10:43 | NaroaIriarte | Review Assigned To | => alostale |
| 2016-11-15 10:58 | hgbot | Checkin | |
| 2016-11-15 10:58 | hgbot | Note Added: 0091541 | |
| 2016-11-15 10:58 | hgbot | Status | scheduled => resolved |
| 2016-11-15 10:58 | hgbot | Resolution | open => fixed |
| 2016-11-15 10:58 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/9bfd8bde32b287625174384e8946c72f9aa06f5b [^] |
| 2016-11-25 08:52 | alostale | Note Added: 0091804 | |
| 2016-11-25 08:52 | alostale | Status | resolved => closed |
| 2016-11-25 08:52 | alostale | Fixed in Version | => 3.0PR17Q1 |
| 2016-11-25 09:05 | alostale | Relationship added | related to 0034628 |
| 2016-12-16 18:38 | hudsonbot | Checkin | |
| 2016-12-16 18:38 | hudsonbot | Note Added: 0092627 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |