Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0034364
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] Service Contract Managementminoralways2016-11-02 10:502016-11-24 14:31
ReportermalsasuaView Statuspublic 
Assigned Tocollazoandy4 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisionf4b2a917de2b
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned Toaferraz
Regression introduced in release
Summary

0034364: when payment term is not selected in contract, null pointer error is returned during "contract billing" process

Descriptionwhen a contract has not set a payment term, and "contract billing" process is run, null pointer exception is returned
Steps To Reproduce. configure a new contract, with payment term field empty
. run "contract billing" process
Error is returned:

org.openbravo.contract.services.process.billing.BaseInvoiceProcess - BaseInvoiceProcess error: null
java.lang.NullPointerException
    at org.openbravo.contract.services.process.billing.StandardContractInvoiceProcess.createInvoiceTempHeaderFromInvoicePlan(StandardContractInvoiceProcess.java:505)
    at org.openbravo.contract.services.process.billing.StandardContractInvoiceProcess.createInvoiceTemp(StandardContractInvoiceProcess.java:432)
    at org.openbravo.contract.services.process.billing.StandardContractInvoiceProcess.createTemporalInvoices(StandardContractInvoiceProcess.java:274)
Proposed Solutionattached diff
TagsNo tags attached.
Attached Filesdiff file icon issueNoPaymentTerm.diff [^] (862 bytes) 2016-11-02 10:50 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0034607 closedcollazoandy4 Error using “Update Invoice Plan” in contract window. 

-  Notes
(0091341)
markmm82 (developer)
2016-11-10 16:57

 Test Plan
1. In the Contract view create a new record in a form view
2. Fill out the Organization, Contract Type, Search Key, Name, Business Partner, Starting Date (initial month) and Ending Date (ending month) fields
3. In the Service Contract group set the Payment Terms field empty and select any Contract Invoice Schedule
4. Save the changes.
5. Create a new record in the Invoice Plan Master
6. Set the Starting Date to today
7. Set the Ending Date to today + 2
8. Select a product and set a quantity
9. Save the Record
10. Clic on the button Update Invoice Plan and OK from the popup
11. Verify a new record was added in the Invoice Plan tab
12. Open the view Contract Billing Process
13. Set the Starting and Ending dates to today
14. In Contract filter select the previously created contract
15. Clic on the Done button and OK from the popup
16. An error is shown indicating that this contract doesn't have a selected Payment Term
(0091759)
hgbot (developer)
2016-11-23 12:21

 Repository: erp/pmods/org.openbravo.contract.services
Changeset: 71eb61053d4702c4c4ed9d6ef8a1c7225d5c8c8e
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Wed Nov 23 12:08:32 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.contract.services/rev/71eb61053d4702c4c4ed9d6ef8a1c7225d5c8c8e [^]

Fixes issue 34364: Contract billing process with empty Payment Term in Contract

While executing a billing process with a Payment Term not selected in Contract, a java lang exception was raised because the contract header is null. Now this is validated, avoiding the uncaptured exception and showing an error message if the contract header is null.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/contract/services/process/billing/StandardContractInvoiceProcess.java
---
(0091760)
hgbot (developer)
2016-11-23 12:21

 Repository: erp/pmods/org.openbravo.contract.services
Changeset: 5fccfbc6883802693ff43de81121309207a45c85
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Wed Nov 23 12:08:55 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.contract.services/rev/5fccfbc6883802693ff43de81121309207a45c85 [^]

Related to issue 34364: Update module version

---
M src-db/database/sourcedata/AD_MODULE.xml
---
(0091761)
hgbot (developer)
2016-11-23 12:29

 Repository: erp/pmods/org.openbravo.contract.services
Changeset: f4b2a917de2bd7b02a75eedbb9aa29ff2664ea99
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Wed Nov 23 12:08:32 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.contract.services/rev/f4b2a917de2bd7b02a75eedbb9aa29ff2664ea99 [^]

Fixes issue 34364: Contract billing process with empty Payment Term in Contract

While executing a billing process with a Payment Term not selected in Contract, a java lang exception was raised because the contract header is null. Now this is validated, avoiding the uncaptured exception and showing an error message if the contract header is null.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/contract/services/process/billing/StandardContractInvoiceProcess.java
---
(0091762)
aferraz (manager)
2016-11-23 12:30

 Code review + Testing OK

- Issue History
Date Modified Username Field Change
2016-11-02 10:50 malsasua New Issue
2016-11-02 10:50 malsasua Assigned To => Triage Finance
2016-11-02 10:50 malsasua File Added: issueNoPaymentTerm.diff
2016-11-02 10:53 malsasua Resolution time => 1479855600
2016-11-03 21:00 aferraz Assigned To Triage Finance => nonofrancisco
2016-11-10 16:55 markmm82 Status new => scheduled
2016-11-10 16:55 markmm82 Assigned To nonofrancisco => markmm82
2016-11-10 16:57 markmm82 Note Added: 0091341
2016-11-22 20:11 aferraz Resolution time 1479855600 =>
2016-11-22 20:11 aferraz Severity major => minor
2016-11-23 12:21 hgbot Checkin
2016-11-23 12:21 hgbot Note Added: 0091759
2016-11-23 12:21 hgbot Status scheduled => resolved
2016-11-23 12:21 hgbot Resolution open => fixed
2016-11-23 12:21 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.contract.services/rev/71eb61053d4702c4c4ed9d6ef8a1c7225d5c8c8e [^]
2016-11-23 12:21 hgbot Checkin
2016-11-23 12:21 hgbot Note Added: 0091760
2016-11-23 12:29 hgbot Checkin
2016-11-23 12:29 hgbot Note Added: 0091761
2016-11-23 12:29 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.contract.services/rev/71eb61053d4702c4c4ed9d6ef8a1c7225d5c8c8e [^] => http://code.openbravo.com/erp/pmods/org.openbravo.contract.services/rev/f4b2a917de2bd7b02a75eedbb9aa29ff2664ea99 [^]
2016-11-23 12:30 aferraz Review Assigned To => aferraz
2016-11-23 12:30 aferraz Note Added: 0091762
2016-11-23 12:30 aferraz Status resolved => closed
2016-11-24 14:30 aferraz Relationship added related to 0034607
2016-11-24 14:31 aferraz Assigned To markmm82 => collazoandy4

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker