0034310: Customer Loader check for organization launch JSONException

Description

When customer loader is checking for organization, it checks the following condition:
if (!jsonCustomer.has("organization") && jsonCustomer.getString("organization").equals("null"))

Steps To Reproduce

Modify the request sent to the WebPOS and delete organization property.

Proposed Solution

    if (!jsonCustomer.has("organization") || jsonCustomer.getString("organization").equals("null")) {
      String errorMessage = "Business partner organization is a mandatory field to create a new customer from Web Pos";
      log.error(errorMessage);
      throw new OBException(errorMessage, null);
    }

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0091048) hgbot (developer) 2016-11-02 05:49	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 17ddee4571c87d990070c4059f948351596206d6 Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Wed Nov 02 10:16:54 2016 +0530 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/17ddee4571c87d990070c4059f948351596206d6 [^] Fixes issue 34310 : Validate Customer Fields attributes while saving in backend --- M src/org/openbravo/retail/posterminal/CustomerLoader.java ---

(0091696) migueldejuana (viewer) 2016-11-21 13:38	Tested and reviewed

Issue History
Date Modified	Username	Field	Change
2016-10-27 09:09	jonibc	New Issue
2016-10-27 09:09	jonibc	Assigned To	=> Retail
2016-10-27 09:09	jonibc	OBNetwork customer	=> No
2016-10-27 09:09	jonibc	Triggers an Emergency Pack	=> No
2016-11-01 10:37	ranjith_qualiantech_com	Assigned To	Retail => ranjith_qualiantech_com
2016-11-01 10:37	ranjith_qualiantech_com	Status	new => scheduled
2016-11-02 05:49	hgbot	Checkin
2016-11-02 05:49	hgbot	Note Added: 0091048
2016-11-02 05:49	hgbot	Status	scheduled => resolved
2016-11-02 05:49	hgbot	Resolution	open => fixed
2016-11-02 05:49	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/17ddee4571c87d990070c4059f948351596206d6 [^]
2016-11-21 13:32	migueldejuana	Review Assigned To	=> migueldejuana
2016-11-21 13:38	migueldejuana	Note Added: 0091696
2016-11-21 13:38	migueldejuana	Status	resolved => closed