Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0034299
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Discounts and Promotionsmajorhave not tried2016-10-26 09:282016-12-16 08:40
Reporterprakashmurugesan88View Statuspublic 
Assigned Tomario_castello 
PrioritynormalResolutionfixedFixed in VersionRR17Q1
StatusclosedFix in branchFixed in SCM revision8eec55651e77
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket
Regression levelProduction - QA Approved
Regression date2016-09-27
Regression introduced in releaseRR16Q3
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/97c95e2c63c9 [^]
Triggers an Emergency PackNo
Summary

0034299: [SER-QA 1942] Error while deleting a receipt that has line with discounts applied.

DescriptionIt appears an error in the console "Divide by 0" when deleting a receipt that has line with discounts applied.

Error occurs in the following line,

https://code.openbravo.com/erp/pmods-branches/org.openbravo.retail.discounts-but-dev/file/6c275711a250/web/org.openbravo.retail.discounts/js/promotion-discount.js#l36 [^]
Steps To ReproduceSteps to reproduce in live builds,

    Backend:
    Set Preference "Web POS Save Removed Tickets" = "Y".

    POS Terminal:
    create a new receipt.
    Add a product GPS handheld.
    Ensure discount GPS_10_per is applied to the line.
    Click on thrash icon and confirm deletion of the receipt.

    Check in browser console "Divide by 0" error will be displayed.
TagsSER-QA
Attached Filespatch file icon DivedByZeroSuggestedFixScenario2.patch [^] (1,182 bytes) 2016-10-28 10:21 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 0034388RR16Q4 closedmario_castello [SER-QA 1942] Error while deleting a receipt that has line with discounts applied. 
has duplicate defect 0034387 closedRetail [RR16Q4] Close a Layaway with discounts in POS throws an error: "Cannot calculate receipt taxes" 
related to defect 0034372 closedranjith_qualiantech_com [RR16Q4] Persistent deleted tickets do not keep manual discounts 

-  Notes
(0090961)
marvintm (viewer)
2016-10-27 15:58

 We have been unable to reproduce the issue with the current code in pi. There have been several fixes in the last days which affected the Save Delete Tickets project, so it's possible that one of them fixed this problem. Can you confirm please?
(0090983)
prakashmurugesan88 (viewer)
2016-10-28 10:20
edited on: 2016-10-28 10:23

 Its working fine for the above mentioned scenario.

But however there is another scenario where similar issue occurs.

Steps to reproduce this issue in live builds,

    Backend:
    Set Preference "Web POS Save Removed Tickets" = "Y".

    POS Terminal:
    create a new receipt.
    Add a product GPS handheld.
    Ensure discount GPS_10_per is applied to the line.
    Pay the receipt.

    From menu select "Verified Returns".
    Select the receipt created above and add all products.
    Now click on thrash icon and confirm deletion of the receipt.
    Shows "Divide by 0" error message.

Suggested Fix:

Please check the attachement(DivedByZeroSuggestedFixScenario2.patch) for suggested fix.
(0091029)
hgbot (developer)
2016-10-31 21:58

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 8eec55651e77c64fb85720d618279c9f01e8e714
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Fri Oct 28 11:22:35 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8eec55651e77c64fb85720d618279c9f01e8e714 [^]

Fixed issue 34299: Fixed divide by zero error while deleting verified return with Web POS Save Removed Tickets preference acivated

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0091030)
hgbot (developer)
2016-10-31 21:59

 Repository: tools/automation/pi-mobile
Changeset: 1c4a6b8c3b6b02156d92e7c9ac9fd09e0691cdf4
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Fri Oct 28 13:02:10 2016 -0600
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/1c4a6b8c3b6b02156d92e7c9ac9fd09e0691cdf4 [^]

Related to issue 34299: Added automated test I34299_VerifiedReturnsWithDiscountAndSaveRemoveTicket

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/returns/I34299_VerifiedReturnsWithDiscountAndSaveRemoveTicket.java
---
(0092250)
hgbot (developer)
2016-12-09 14:58

 Repository: retail/backports/3.0RR16Q4/org.openbravo.retail.posterminal
Changeset: 77ae9fb0ba7de664c844170e8c23ea2eb22be2f7
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Fri Dec 09 14:58:02 2016 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR16Q4/org.openbravo.retail.posterminal/rev/77ae9fb0ba7de664c844170e8c23ea2eb22be2f7 [^]

Related to issue 34388, backport of issue 34299: Fixed divide by zero error while deleting verified return with Web POS Save Removed Tickets preference acivated

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0092251)
hgbot (developer)
2016-12-09 15:19

 Repository: retail/backports/3.0RR16Q4/pi-mobile
Changeset: ea0a16cf68d5517550d495a80e336ded449ae38b
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Wed Dec 07 10:36:22 2016 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR16Q4/pi-mobile/rev/ea0a16cf68d5517550d495a80e336ded449ae38b [^]

Fixes issue 34388, backport of issue 34299: Added test

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/returns/I34299_VerifiedReturnsWithDiscountAndSaveRemoveTicket.java
---
(0092443)
hgbot (developer)
2016-12-16 08:40

 Repository: tools/automation/pi-mobile
Changeset: ea0a16cf68d5517550d495a80e336ded449ae38b
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Wed Dec 07 10:36:22 2016 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/ea0a16cf68d5517550d495a80e336ded449ae38b [^]

Fixes issue 34388, backport of issue 34299: Added test

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/returns/I34299_VerifiedReturnsWithDiscountAndSaveRemoveTicket.java
---

- Issue History
Date Modified Username Field Change
2016-10-26 09:28 prakashmurugesan88 New Issue
2016-10-26 09:28 prakashmurugesan88 Assigned To => Retail
2016-10-26 09:28 prakashmurugesan88 OBNetwork customer => No
2016-10-26 09:28 prakashmurugesan88 Triggers an Emergency Pack => No
2016-10-26 09:50 adrianromero OBNetwork customer No => Yes
2016-10-26 09:50 adrianromero Resolution time => 1478646000
2016-10-26 09:50 adrianromero Summary Error while deleting a receipt that has line with discounts applied. => [SER-QA 1942] Error while deleting a receipt that has line with discounts applied.
2016-10-26 09:50 adrianromero Description Updated View Revisions
2016-10-26 09:50 adrianromero Tag Attached: SER-QA
2016-10-26 14:08 prakashmurugesan88 Description Updated View Revisions
2016-10-27 15:58 marvintm Assigned To Retail => prakashmurugesan88
2016-10-27 15:58 marvintm Note Added: 0090961
2016-10-27 15:58 marvintm Status new => feedback
2016-10-28 10:20 prakashmurugesan88 Note Added: 0090983
2016-10-28 10:21 prakashmurugesan88 File Added: DivedByZeroSuggestedFixScenario2.patch
2016-10-28 10:21 prakashmurugesan88 Status feedback => new
2016-10-28 10:22 prakashmurugesan88 Assigned To prakashmurugesan88 => marvintm
2016-10-28 10:23 prakashmurugesan88 Note Edited: 0090983 View Revisions
2016-10-28 21:12 mario_castello Assigned To marvintm => mario_castello
2016-10-28 21:12 mario_castello Status new => acknowledged
2016-10-28 21:13 mario_castello Status acknowledged => scheduled
2016-10-31 21:58 hgbot Checkin
2016-10-31 21:58 hgbot Note Added: 0091029
2016-10-31 21:58 hgbot Status scheduled => resolved
2016-10-31 21:58 hgbot Resolution open => fixed
2016-10-31 21:58 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8eec55651e77c64fb85720d618279c9f01e8e714 [^]
2016-10-31 21:59 hgbot Checkin
2016-10-31 21:59 hgbot Note Added: 0091030
2016-11-01 08:53 marvintm Review Assigned To => marvintm
2016-11-01 08:53 marvintm Status resolved => closed
2016-11-01 08:53 marvintm Fixed in Version => RR17Q1
2016-11-04 10:11 marvintm Status closed => new
2016-11-04 10:11 marvintm Resolution fixed => open
2016-11-04 10:11 marvintm Fixed in Version RR17Q1 =>
2016-11-04 10:11 marvintm Status new => scheduled
2016-11-04 10:11 marvintm Status scheduled => resolved
2016-11-04 10:11 marvintm Fixed in Version => RR17Q1
2016-11-04 10:11 marvintm Resolution open => fixed
2016-11-04 10:11 marvintm Status resolved => closed
2016-11-04 10:11 marvintm Relationship added has duplicate 0034387
2016-11-04 10:12 marvintm Status closed => new
2016-11-04 10:12 marvintm Resolution fixed => open
2016-11-04 10:12 marvintm Fixed in Version RR17Q1 =>
2016-11-04 10:13 marvintm Status new => scheduled
2016-11-04 10:13 marvintm Status scheduled => resolved
2016-11-04 10:13 marvintm Resolution open => fixed
2016-11-04 10:13 marvintm Status resolved => closed
2016-11-04 10:13 marvintm Fixed in Version => RR17Q1
2016-11-09 11:47 ranjith_qualiantech_com Relationship added related to 0034372
2016-11-16 18:19 mario_castello Regression level => Production - QA Approved
2016-11-16 18:19 mario_castello Regression date => 2016-09-27
2016-11-16 18:19 mario_castello Regression introduced in release => RR16Q3
2016-11-16 18:19 mario_castello Regression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/97c95e2c63c9 [^]
2016-12-06 10:54 hgbot Checkin
2016-12-06 10:54 hgbot Note Added: 0092129
2016-12-09 14:58 hgbot Checkin
2016-12-09 14:58 hgbot Note Added: 0092250
2016-12-09 15:03 Orekaria Note Deleted: 0092129
2016-12-09 15:19 hgbot Checkin
2016-12-09 15:19 hgbot Note Added: 0092251
2016-12-16 08:40 hgbot Checkin
2016-12-16 08:40 hgbot Note Added: 0092443

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker