Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0034293

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Web POS

major

always

2016-10-25 17:57

2016-10-28 18:27

Reporter

daniOpenbravo

View Status

public

Assigned To

mtaal

Priority

high

Resolution

no change required

Fixed in Version

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Linux 64 bit

Database

PostgreSQL

Java version

OS Version

14.04

Database version

9.3

Ant version

Product Version

SCM revision

Review Assigned To

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0034293: [STORE SERVER 2005] Cancel and replace does not work after having cancelled a picking.

Description

Cancel and replace does not work after having cancelled a picking.
CS= 52.17.253.61
SS= 52.31.227.242

Steps To Reproduce

1. Log in Web POS.
2. Layaway this receipt.
3. Add product "Victor" to the ticket (delivery condition: deferred carry away).
4. Pay the ticket.
5. Prepare the order.
6. Select the ticket and click on "Prepare selected".
7. Go to pickings in menu dropdown and select the one related to previous layaway.
8. Assign it to any user.
9. Confirm All.
10. Go to menu dropdown and select "receipts": enter previous ticket document number.
11. Click on Cancel and replace option in dropdown menu: A message will be shown telling us that the order has a picking assigned.
12. Select previous picking in pickings dropdown menu.
13. Click on cancel picking.
14. Repeat steps 10 and 11: now it is possible to do C&R of that order.
15. Pay the ticket that replaces the original one: the system gets blocked and the information is not synchronized neither CS nor SS.

**Sometimes, attached image error is shown.

Tags

c&r_issuePickings.png [^] (256,445 bytes) 2016-10-25 17:57

shipment-handler.diff [^] (878 bytes) 2016-10-28 18:27 [Show Content] [Hide Content]

diff --git a/src/com/openbravo/but/integration/shipment/handler/ShipmentHandler.java b/src/com/openbravo/but/integration/shipment/handler/ShipmentHandler.java
--- a/src/com/openbravo/but/integration/shipment/handler/ShipmentHandler.java
+++ b/src/com/openbravo/but/integration/shipment/handler/ShipmentHandler.java
@@ -70,7 +70,8 @@
     Entity currentEntity = event.getTargetInstance().getEntity();
     if (shipmentInOutEntity == currentEntity) {
       ShipmentInOut shipment = (ShipmentInOut) event.getTargetInstance();
-      if (shipment.isSalesTransaction() && !DRAFT_SHIPMENT.equals(shipment.getDocumentStatus())) {
+      if (Boolean.TRUE.equals(shipment.isSalesTransaction())
+          && !DRAFT_SHIPMENT.equals(shipment.getDocumentStatus())) {
         setShipmentID(shipment.getId());
         logger.debug("Shipment {} is being saved", shipment.getId());
       }

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0091005) mtaal (manager) 2016-10-28 18:26 edited on: 2016-10-28 18:27	I checked and this was not always reproducable, not locally. On the server on which the issue was found it was reproducable. I found the following stack trace [1] in the log. When I changed the code (see attached diff) to prevent the NPE, the issue was not reproducable anymore. [1] java.lang.NullPointerException at com.openbravo.but.integration.shipment.handler.ShipmentHandler.onSave(ShipmentHandler.java:73) at sun.reflect.GeneratedMethodAccessor500.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:622) at org.jboss.weld.util.reflection.SecureReflections$13.work(SecureReflections.java:267) at org.jboss.weld.util.reflection.SecureReflectionAccess.run(SecureReflectionAccess.java:52) at org.jboss.weld.util.reflection.SecureReflectionAccess.runAsInvocation(SecureReflectionAccess.java:137) at org.jboss.weld.util.reflection.SecureReflections.invoke(SecureReflections.java:263)

(0091006) mtaal (manager) 2016-10-28 18:27	Not a store server issue

Issue History
Date Modified	Username	Field	Change
2016-10-25 17:57	daniOpenbravo	New Issue
2016-10-25 17:57	daniOpenbravo	Assigned To	=> mtaal
2016-10-25 17:57	daniOpenbravo	File Added: c&r_issuePickings.png
2016-10-25 17:57	daniOpenbravo	Resolution time	=> 1477954800
2016-10-25 17:57	daniOpenbravo	Triggers an Emergency Pack	=> No
2016-10-25 17:58	daniOpenbravo	Tag Attached: SER-QA
2016-10-25 17:58	daniOpenbravo	Issue Monitored: daniOpenbravo
2016-10-28 18:26	mtaal	Note Added: 0091005
2016-10-28 18:27	mtaal	Note Edited: 0091005	View Revisions
2016-10-28 18:27	mtaal	File Added: shipment-handler.diff
2016-10-28 18:27	mtaal	Note Added: 0091006
2016-10-28 18:27	mtaal	Status	new => closed
2016-10-28 18:27	mtaal	Resolution	open => no change required

Copyright © 2000 - 2009 MantisBT Group