Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0034276
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Openbravo ERP] A. Platformminorhave not tried2016-10-23 10:412016-12-16 18:38
ReportermtaalView Statuspublic 
Assigned Tomtaal 
PrioritynormalResolutionfixedFixed in Version3.0PR17Q1
StatusclosedFix in branchFixed in SCM revisionc50024821eda
ProjectionnoneETAnoneTarget Version3.0PR17Q1
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0034276: Login performance improvements: more precise obcontext cache and allow bypassing specific fill-session code

DescriptionSpecific code in the login functionality is targeted for backoffice users. This code is not used by most webservice or server to server requests. Therefore the proposal is to allow bypassing the more heavy logic which is only for backoffice usage.

Another improvement is to make the obcontext cache better usable, more precise so that cached. This prevents wrong use of a cached OBContext if the user has a different runtime organization/role than his/her default.
Steps To ReproduceSee related issue
Proposed SolutionBy setting a http session variable direct the LoginUtils.fillSessionArgument to bypass specific parts which are only useful for backoffice logins.

For OBContext user cache, make the cache key more precise to also include the org and role.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks defect 0034040 closedmtaal Retail Modules fillSessionArguments method is running twice processing a request 

-  Notes
(0090785)
hgbot (developer)
2016-10-23 10:47

 Repository: erp/devel/pi
Changeset: c50024821eda73c38e90c7708516a580b6567120
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sun Oct 23 10:46:31 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/c50024821eda73c38e90c7708516a580b6567120 [^]

Fixes issue 34276: Login performance improvements: more precise obcontext cache and allow bypassing specific fill-session code

LoginUtils:
- do not create a new obcontext if the current one is already valid
- by setting a http session variable #Light_login to Y the fillSessionArgument will bypass specific logic. The larger diff is because the code is indented in an if-statement.

UserContextCache:
- Make obcontext caching more precise by also using role and org.

---
M src/org/openbravo/base/secureApp/LoginUtils.java
M src/org/openbravo/service/web/UserContextCache.java
---
(0091159)
alostale (viewer)
2016-11-04 08:30

 code reviewed

Note to make use of light_login, it's necessary to set that variable in session programmatically.
(0092545)
hudsonbot (viewer)
2016-12-16 18:38

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2016-10-23 10:41 mtaal New Issue
2016-10-23 10:41 mtaal Assigned To => mtaal
2016-10-23 10:41 mtaal OBNetwork customer => No
2016-10-23 10:41 mtaal Modules => Core
2016-10-23 10:41 mtaal Triggers an Emergency Pack => No
2016-10-23 10:41 mtaal Relationship added blocks 0034040
2016-10-23 10:42 mtaal Review Assigned To => alostale
2016-10-23 10:47 hgbot Checkin
2016-10-23 10:47 hgbot Note Added: 0090785
2016-10-23 10:47 hgbot Status new => resolved
2016-10-23 10:47 hgbot Resolution open => fixed
2016-10-23 10:47 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/c50024821eda73c38e90c7708516a580b6567120 [^]
2016-11-04 08:30 alostale Note Added: 0091159
2016-11-04 08:30 alostale Status resolved => closed
2016-11-04 08:30 alostale Fixed in Version => 3.0PR17Q1
2016-12-16 18:38 hudsonbot Checkin
2016-12-16 18:38 hudsonbot Note Added: 0092545

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker