Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0034267
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Openbravo ERP] A. Platformminorhave not tried2016-10-21 11:102016-12-16 18:38
ReportermtaalView Statuspublic 
Assigned Tomtaal 
PrioritynormalResolutionno change requiredFixed in Version
StatusclosedFix in branchFixed in SCM revision7467958c7690
ProjectionnoneETAnoneTarget Version3.0PR17Q1
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0034267: Let the basekernelservlet handle cors requests

DescriptionMany servlets in retail support cors [1]. The base kernel servlet was missing it. This is however needed for mobile warehouse module which also uses direct datasource requests.

[1]
https://en.wikipedia.org/wiki/Cross-origin_resource_sharing [^]
Steps To ReproduceSet the cors headers in the request

 OBMOBCUtils.setCORSHeaders(request, response);
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to feature request 0034063 closedmtaal Retail Modules [STORE SERVER 1791]Support offline and multi-server for Mobile Warehouse 
related to feature request 00343313.0PR17Q1 closedmtaal Openbravo ERP Support pre-defined allowed domains for cross-domain requests in a multi-server environment 
blocks feature request 0034298RR17Q1 closedmtaal Retail Modules Make use of common method to generate cors response headers 
blocks design defect 0034330RR17Q1 closedmtaal Retail Modules Support multi-server requests in a better more secure way 

-  Notes
(0090784)
hgbot (developer)
2016-10-23 10:37

 Repository: erp/devel/pi
Changeset: 27cdaf759fc805e141848ddf17d597ed4a5b2440
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sun Oct 23 10:36:41 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/27cdaf759fc805e141848ddf17d597ed4a5b2440 [^]

Fixes issue 34267: Let the basekernelservlet handle cors requests
Set the cors headers when serving a request

---
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/BaseKernelServlet.java
---
(0090786)
hgbot (developer)
2016-10-23 11:01

 Repository: erp/devel/pi
Changeset: b61ce156e6a025d7b3d4833c0d8883210be5c729
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sun Oct 23 11:00:57 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/b61ce156e6a025d7b3d4833c0d8883210be5c729 [^]

Related to issue 34267: Let the basekernelservlet handle cors requests
Backout of changeset as unintended dependency on mobile core was created.

---
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/BaseKernelServlet.java
---
(0090795)
hgbot (developer)
2016-10-23 16:10

 Repository: erp/devel/pi
Changeset: e2e7fb70d085771ea0c714dcd9f547b05a1e85e0
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sun Oct 23 16:10:33 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/e2e7fb70d085771ea0c714dcd9f547b05a1e85e0 [^]

Fixes issue 34267: Let the basekernelservlet handle cors requests
Set cors headers in the basekernelservlet

---
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/BaseKernelServlet.java
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/KernelUtils.java
---
(0090984)
alostale (viewer)
2016-10-28 10:20

 Reopening after discussion with MTA
(0091017)
hgbot (developer)
2016-10-31 09:41

 Repository: erp/devel/pi
Changeset: b06a2c5097c19c5cd019c7462f3d83c3c092765e
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Oct 31 09:41:22 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/b06a2c5097c19c5cd019c7462f3d83c3c092765e [^]

Related to issue 34267: Let the basekernelservlet handle cors requests
Backout of changeset

---
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/BaseKernelServlet.java
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/KernelUtils.java
---
(0091019)
hgbot (developer)
2016-10-31 10:39

 Repository: erp/devel/api-checks
Changeset: 7467958c769061e8c4ecb410c177d3dfa06a3ea6
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Oct 31 10:38:58 2016 +0100
URL: http://code.openbravo.com/erp/devel/api-checks/rev/7467958c769061e8c4ecb410c177d3dfa06a3ea6 [^]

Fixes issue 34267: Let the basekernelservlet handle cors requests
Correct api baseline for remove of method which was only temporarily there

---
M java/reference/java.japi.gz
---
(0091158)
alostale (viewer)
2016-11-04 08:10

 Closed with no change, proper solution will be implemented by 0034331
(0092544)
hudsonbot (viewer)
2016-12-16 18:38

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test
(0092546)
hudsonbot (viewer)
2016-12-16 18:38

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test
(0092547)
hudsonbot (viewer)
2016-12-16 18:38

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test
(0092581)
hudsonbot (viewer)
2016-12-16 18:38

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2016-10-21 11:10 mtaal New Issue
2016-10-21 11:10 mtaal Assigned To => mtaal
2016-10-21 11:10 mtaal OBNetwork customer => No
2016-10-21 11:10 mtaal Modules => Core
2016-10-21 11:10 mtaal Triggers an Emergency Pack => No
2016-10-21 20:08 mtaal Review Assigned To => alostale
2016-10-21 20:08 mtaal Relationship added related to 0034063
2016-10-23 10:37 hgbot Checkin
2016-10-23 10:37 hgbot Note Added: 0090784
2016-10-23 10:37 hgbot Status new => resolved
2016-10-23 10:37 hgbot Resolution open => fixed
2016-10-23 10:37 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/27cdaf759fc805e141848ddf17d597ed4a5b2440 [^]
2016-10-23 11:01 hgbot Checkin
2016-10-23 11:01 hgbot Note Added: 0090786
2016-10-23 11:02 mtaal Status resolved => new
2016-10-23 11:02 mtaal Resolution fixed => open
2016-10-23 16:10 hgbot Checkin
2016-10-23 16:10 hgbot Note Added: 0090795
2016-10-23 16:10 hgbot Status new => resolved
2016-10-23 16:10 hgbot Resolution open => fixed
2016-10-23 16:10 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/27cdaf759fc805e141848ddf17d597ed4a5b2440 [^] => http://code.openbravo.com/erp/devel/pi/rev/e2e7fb70d085771ea0c714dcd9f547b05a1e85e0 [^]
2016-10-26 08:49 mtaal Relationship added blocks 0034298
2016-10-28 10:20 alostale Note Added: 0090984
2016-10-28 10:20 alostale Status resolved => new
2016-10-28 10:20 alostale Resolution fixed => open
2016-10-28 10:45 mtaal Relationship added related to 0034331
2016-10-28 10:46 mtaal Relationship added blocks 0034330
2016-10-31 09:41 hgbot Checkin
2016-10-31 09:41 hgbot Note Added: 0091017
2016-10-31 10:39 hgbot Checkin
2016-10-31 10:39 hgbot Note Added: 0091019
2016-10-31 10:39 hgbot Status new => resolved
2016-10-31 10:39 hgbot Resolution open => fixed
2016-10-31 10:39 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/e2e7fb70d085771ea0c714dcd9f547b05a1e85e0 [^] => http://code.openbravo.com/erp/devel/api-checks/rev/7467958c769061e8c4ecb410c177d3dfa06a3ea6 [^]
2016-11-04 08:09 alostale Status resolved => closed
2016-11-04 08:10 alostale Note Added: 0091158
2016-11-04 08:10 alostale Resolution fixed => no change required
2016-12-16 18:38 hudsonbot Checkin
2016-12-16 18:38 hudsonbot Note Added: 0092544
2016-12-16 18:38 hudsonbot Checkin
2016-12-16 18:38 hudsonbot Note Added: 0092546
2016-12-16 18:38 hudsonbot Checkin
2016-12-16 18:38 hudsonbot Note Added: 0092547
2016-12-16 18:38 hudsonbot Checkin
2016-12-16 18:38 hudsonbot Note Added: 0092581

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker