Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0034187 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [Retail Modules] Web POS | major | always | 2016-09-13 11:44 | 2016-12-16 08:39 | |||
| Reporter | marvintm | View Status | public | |||||
| Assigned To | asiermartirena | |||||||
| Priority | urgent | Resolution | fixed | Fixed in Version | RR16Q4 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | e1b8a4e5010b | ||||
| Projection | none | ETA | none | Target Version | RR16Q4 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | marvintm | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0034187: Keeping track of deleted tickets is generating incorrect data | |||||||
| Description | Since 16Q2, it is possible to configure the Openbravo instance so that relevant deleted tickets are synchronized to the backend: http://wiki.openbravo.com/wiki/Projects:Keep_Track_Of_Deleted_Ticket_Lines [^] The idea is that these tickets would be changed so that their ordered quantity is set to zero. This works correctly, but there are several parts of the ticket which should be changed, and currently are not being set correctly. Specifically: - Taxes (at both document and line level) should be zero, and currently are not. - Totals at line level (both net and gross) should be zero, and currently are not. - Discount information should also be discussed. | |||||||
| Steps To Reproduce | - Activate the functionality to keep track of deleted tickets, creating a preference for property "Web POS Save Removed Tickets" - Create a ticket in the Web POS. Add some lines to it. - Delete the ticket via the "Delete ticket" button. - Check the ticket in the backend, and verify that tax information is not empty, and line totals are not zero. | |||||||
| Proposed Solution | Currently there is code in the OrderLoader that zeroes the totals of the header, and also the quantity of the lines. I believe a better approach would be to change the functionality so that the ticket in the client side is modified, by setting the quantity of each line to zero, and then recomputing the ticket using the existing calculateReceipt function in the client side. In this way, the code would be much cleaner, the OrderLoader would not need to even know about the functionality, and would just save the modified ticket as it is. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0090890) hgbot (developer) 2016-10-26 09:20 |
Repository: retail/backports/3.0RR16Q4/org.openbravo.retail.discounts Changeset: e1b8a4e5010b0083fe138438b9f4630c1deb216b Author: Asier Martirena <asier.martirena <at> openbravo.com> Date: Wed Oct 26 08:54:00 2016 +0200 URL: http://code.openbravo.com/retail/backports/3.0RR16Q4/org.openbravo.retail.discounts/rev/e1b8a4e5010b0083fe138438b9f4630c1deb216b [^] Fixed issue 34187: fixed problem deleting ticket with promotion discount --- M web/org.openbravo.retail.discounts/js/promotion-discount.js --- |
|
(0090891) hgbot (developer) 2016-10-26 10:26 |
Repository: retail/backports/3.0RR16Q4/pi-mobile Changeset: 35a76dc591b7a40439c5c7a3312c2e422c8af6ba Author: Asier Martirena <asier.martirena <at> openbravo.com> Date: Wed Oct 26 08:55:31 2016 +0200 URL: http://code.openbravo.com/retail/backports/3.0RR16Q4/pi-mobile/rev/35a76dc591b7a40439c5c7a3312c2e422c8af6ba [^] Related to issue 34187: Automated test for deleting tickets with a promotion discount --- A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I34187_DeleteTicketWithPercentageDiscount.java --- |
|
(0091238) hgbot (developer) 2016-11-08 15:33 |
Repository: retail/backports/3.0RR16Q4/pi-mobile Changeset: 47828b2bc600c7ffa8c25e3f8f2482ba5f6ba338 Author: Jorge Garcia <jorge.garcia <at> openbravo.com> Date: Tue Nov 08 15:06:09 2016 +0100 URL: http://code.openbravo.com/retail/backports/3.0RR16Q4/pi-mobile/rev/47828b2bc600c7ffa8c25e3f8f2482ba5f6ba338 [^] Related to issue 34187: Automated test for deleting tickets with a promotion discount Fix some imports from test --- M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I34187_DeleteTicketWithPercentageDiscount.java --- |
|
(0092435) hgbot (developer) 2016-12-16 08:39 |
Repository: tools/automation/pi-mobile Changeset: 35a76dc591b7a40439c5c7a3312c2e422c8af6ba Author: Asier Martirena <asier.martirena <at> openbravo.com> Date: Wed Oct 26 08:55:31 2016 +0200 URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/35a76dc591b7a40439c5c7a3312c2e422c8af6ba [^] Related to issue 34187: Automated test for deleting tickets with a promotion discount --- A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I34187_DeleteTicketWithPercentageDiscount.java --- |
|
(0092436) hgbot (developer) 2016-12-16 08:39 |
Repository: tools/automation/pi-mobile Changeset: 47828b2bc600c7ffa8c25e3f8f2482ba5f6ba338 Author: Jorge Garcia <jorge.garcia <at> openbravo.com> Date: Tue Nov 08 15:06:09 2016 +0100 URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/47828b2bc600c7ffa8c25e3f8f2482ba5f6ba338 [^] Related to issue 34187: Automated test for deleting tickets with a promotion discount Fix some imports from test --- M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I34187_DeleteTicketWithPercentageDiscount.java --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2016-10-11 12:50 | asiermartirena | Type | defect => backport |
| 2016-10-11 12:50 | asiermartirena | Target Version | => RR16Q4 |
| 2016-10-26 09:20 | hgbot | Checkin | |
| 2016-10-26 09:20 | hgbot | Note Added: 0090890 | |
| 2016-10-26 09:20 | hgbot | Status | scheduled => resolved |
| 2016-10-26 09:20 | hgbot | Resolution | open => fixed |
| 2016-10-26 09:20 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/97c95e2c63c9c9b72f43085bf624a58c6b32a41d [^] => http://code.openbravo.com/retail/backports/3.0RR16Q4/org.openbravo.retail.discounts/rev/e1b8a4e5010b0083fe138438b9f4630c1deb216b [^] |
| 2016-10-26 10:26 | hgbot | Checkin | |
| 2016-10-26 10:26 | hgbot | Note Added: 0090891 | |
| 2016-11-08 15:33 | hgbot | Checkin | |
| 2016-11-08 15:33 | hgbot | Note Added: 0091238 | |
| 2016-12-09 13:50 | marvintm | Review Assigned To | => marvintm |
| 2016-12-09 13:50 | marvintm | Status | resolved => closed |
| 2016-12-09 13:50 | marvintm | Fixed in Version | => RR16Q4 |
| 2016-12-16 08:39 | hgbot | Checkin | |
| 2016-12-16 08:39 | hgbot | Note Added: 0092435 | |
| 2016-12-16 08:39 | hgbot | Checkin | |
| 2016-12-16 08:39 | hgbot | Note Added: 0092436 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |